fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-06-21 16:51:33 +00:00
Code Issues Projects Releases Wiki Activity

fix: Reflec.defineProperty no longer returns Result

Browse Source
This commit is contained in:
Jannik Keye
2018-07-05 08:33:22 +02:00
parent 7790b34c07
commit 8dd8475000
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/js.rs
View File

@ -1003,8 +1003,8 @@ extern "C" {
/// but returns a Boolean.
///
/// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/defineProperty
#[wasm_bindgen(static_method_of = Reflect, js_name = defineProperty, catch)]
pub fn define_property(target: &Object, property_key: &JsValue, attributes: &Object) -> Result<JsValue, JsValue>;
#[wasm_bindgen(static_method_of = Reflect, js_name = defineProperty)]
pub fn define_property(target: &Object, property_key: &JsValue, attributes: &Object) -> bool;
/// The static Reflect.deleteProperty() method allows to delete properties.
/// It is like the delete operator as a function.

10
tests/all/js_globals/Reflect.rs
View File

@ -160,13 +160,8 @@ fn define_property() {
use wasm_bindgen::js;
#[wasm_bindgen]
pub fn define_property(target: &js::Object, property_key: &JsValue, attributes: &js::Object) -> JsValue {
let result = js::Reflect::define_property(target, property_key, attributes);
match result {
Ok(val) => val,
Err(_err) => _err
}
pub fn define_property(target: &js::Object, property_key: &JsValue, attributes: &js::Object) -> bool {
js::Reflect::define_property(target, property_key, attributes)
}
"#,
)
@ -180,7 +175,6 @@ fn define_property() {
const object = {};
assert.equal(wasm.define_property(object, "key", { value: 42}), true)
assert.equal(wasm.define_property("", "key", { value: 42 }), "TypeError: Reflect.defineProperty called on non-object");
}
"#,
)