diff --git a/src/js.rs b/src/js.rs index 77ba922e..1de3d662 100644 --- a/src/js.rs +++ b/src/js.rs @@ -1003,8 +1003,8 @@ extern "C" { /// but returns a Boolean. /// /// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/defineProperty - #[wasm_bindgen(static_method_of = Reflect, js_name = defineProperty, catch)] - pub fn define_property(target: &Object, property_key: &JsValue, attributes: &Object) -> Result; + #[wasm_bindgen(static_method_of = Reflect, js_name = defineProperty)] + pub fn define_property(target: &Object, property_key: &JsValue, attributes: &Object) -> bool; /// The static Reflect.deleteProperty() method allows to delete properties. /// It is like the delete operator as a function. diff --git a/tests/all/js_globals/Reflect.rs b/tests/all/js_globals/Reflect.rs index e3903466..c6cf3b09 100644 --- a/tests/all/js_globals/Reflect.rs +++ b/tests/all/js_globals/Reflect.rs @@ -160,13 +160,8 @@ fn define_property() { use wasm_bindgen::js; #[wasm_bindgen] - pub fn define_property(target: &js::Object, property_key: &JsValue, attributes: &js::Object) -> JsValue { - let result = js::Reflect::define_property(target, property_key, attributes); - - match result { - Ok(val) => val, - Err(_err) => _err - } + pub fn define_property(target: &js::Object, property_key: &JsValue, attributes: &js::Object) -> bool { + js::Reflect::define_property(target, property_key, attributes) } "#, ) @@ -180,7 +175,6 @@ fn define_property() { const object = {}; assert.equal(wasm.define_property(object, "key", { value: 42}), true) - assert.equal(wasm.define_property("", "key", { value: 42 }), "TypeError: Reflect.defineProperty called on non-object"); } "#, )