Commit Graph

360 Commits

Author SHA1 Message Date
0a8721113a First pass of PR updates 2017-12-06 21:08:55 +01:00
4ec7883891 Cleanup 2017-12-06 11:21:01 +01:00
dcb4395604 Refactor throttle timer 2017-12-06 11:17:50 +01:00
3d9113c16e Add a bit more padding to tests so they pass on osx with -race 2017-12-06 09:18:04 +01:00
bfcc0217f1 Merge pull request #93 from tendermint/release/0.5.0
Release/0.5.0
2017-12-06 02:08:29 -05:00
e6be03db31 update license and changelog 2017-12-06 02:05:57 -05:00
b166d627f3 bump up version to 0.5.0 2017-12-05 18:04:28 -06:00
303b6df812 update changelog 2017-12-05 18:04:07 -06:00
283462dfe4 Merge pull request #86 from tendermint/fix-lint
fix warnings
2017-12-05 17:53:38 -06:00
c325ce2182 use NoErrorf and Errorf functions 2017-12-05 17:49:42 -06:00
27ab1f6bd9 Merge pull request #90 from tendermint/feature/throttle-timer
test timers
2017-12-05 14:17:41 -06:00
26abd65e34 Add tests for repeat timer 2017-12-05 15:01:07 +01:00
53cdb6cf82 Demo throttle timer is broken 2017-12-05 14:49:16 +01:00
4769719a4b fix Errorf 2017-12-04 08:54:19 -08:00
d625020c90 Merge pull request #89 from tendermint/license
add license file (Fixes #87) [ci skip]
2017-12-04 10:39:56 -06:00
3af6044fdf add license file (Fixes #87) [ci skip] 2017-12-04 10:38:55 -06:00
ebc543ebe3 fix warnings 2017-12-01 09:51:37 -08:00
21fb781989 Merge pull request #84 from tendermint/85-indexing
query#Conditions for indexing
2017-11-29 12:49:38 -06:00
c9694b1ba1 fix warnings 2017-11-29 12:44:16 -06:00
3822727981 add Conditions function
Refs https://github.com/tendermint/tendermint/pull/835
2017-11-29 12:44:16 -06:00
850fd24ee9 Merge pull request #85 from tendermint/85-indexing-2
IntInSlice and StringInSlice functions
2017-11-29 12:37:33 -06:00
33abe87c5b IntInSlice and StringInSlice functions
Refs https://github.com/tendermint/tendermint/pull/835
2017-11-29 12:18:03 -06:00
1e12754b3a Merge pull request #75 from tendermint/45-change-common-start-signature
change common start signature
2017-11-29 06:05:50 +00:00
4d991acae0 common: comments for Service 2017-11-29 05:16:15 +00:00
ddd141c1c5 Merge branch 'develop' into 45-change-common-start-signature 2017-11-29 05:08:12 +00:00
57fea1335a Makefile and linter 2017-11-29 05:08:05 +00:00
c2fcc093b2 remove bool from Service#Reset 2017-11-27 23:42:36 -06:00
f75339264f Merge pull request #83 from tendermint/gut-process
remove package process
2017-11-27 22:37:35 -06:00
e07ad01f62 remove package process
Fixes https://github.com/tendermint/tmlibs/issues/81

That package is untested and racy, and not used except in
a test, but even that's now gutted with
  https://github.com/tendermint/abci/pull/139
so the general consensus is that we sunset this package.
2017-11-27 21:24:46 -07:00
eb31c04f47 Merge tag 'v0.4.1' into develop
Tagged 0.4.1 release
2017-11-27 21:38:24 -06:00
b854baa1fc Merge branch 'release/0.4.1' 2017-11-27 21:38:12 -06:00
3244f73f32 update version 2017-11-27 21:37:39 -06:00
4e705a3157 update changelog 2017-11-27 21:37:15 -06:00
d3bac7a6fe clist: reduce numTimes in test 2017-11-27 19:49:30 +00:00
135a1a7cd7 db: sort keys for memdb iterator 2017-11-20 03:06:18 +00:00
2442a0a698 Merge pull request #78 from tendermint/editorconfig
add .editorconfig
2017-11-11 11:32:59 -05:00
4ea6340f1a add .editorconfig 2017-11-11 11:25:30 -05:00
176c2ceed6 Merge pull request #77 from tendermint/18-unsupported-value-type
encode complex types as "%+v"
2017-11-07 21:29:54 -05:00
798848320f Merge pull request #76 from tendermint/29-log-logger-errors
log logger's errors
2017-11-07 21:29:35 -05:00
69447564b8 encode complex types as "%+v" (Refs #18) 2017-11-06 15:44:21 -05:00
4b989151ed log logger's errors (Refs #29) 2017-11-06 14:18:42 -05:00
e6164d4052 change service#Stop to be similar to Start 2017-11-06 12:47:23 -05:00
4123d54bf6 change service#Start to return just error (Refs #45)
```
@melekes
yeah, bool is superfluous
@ethanfrey
If I remember correctly when I was writing test code, if I call Start() on a Service that is already running, it returns (false, nil). Only if I try to legitimately start it, but it fails in startup do I get an error.
The distinction is quite important to make it safe for reentrant calls. The other approach would be to have a special error type like ErrAlreadyStarted, then check for that in your code explicitly. Kind of like if I make a db call in gorm, and get an error, I check if it is a RecordNotFound error, or whether there was a real error with the db query.
@melekes
Ah, I see. Thanks. I must say I like ErrAlreadyStarted approach more (not just in Golang)
```
2017-11-06 12:18:04 -05:00
ac0cf0b2e2 Merge pull request #74 from tendermint/73-undefined-syscall-kill
use os.Process#Kill (Fixes #73)
2017-11-04 09:07:03 -05:00
49d75e223e use os.Process#Kill (Fixes #73) 2017-11-04 08:14:47 -05:00
b658294a13 use assert.Contains in cmap_test 2017-11-04 00:10:59 -05:00
88481fc363 Make iterating over keys possible (#63)
* Make iterating over keys possible

* add test for cmap
- test Keys() and Values() respectively

* one cmap per test-case
2017-11-04 00:06:20 -05:00
0f555f8d2c Merge pull request #71 from tendermint/69-read-impl-and-tests
[autofile] test GroupReader more extensively (Refs #69)
2017-11-04 00:02:02 -05:00
d8dd497069 fix metalinter errors 2017-10-30 13:01:18 -05:00
668698584d [autofile] test GroupReader more extensively (Refs #69) 2017-10-30 12:48:51 -05:00