fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-24 10:11:48 +00:00
Code Issues Projects Releases Wiki Activity

remove some TODOs

Browse Source
This commit is contained in:
Ethan Buchman
2017-11-20 04:40:09 +00:00
parent cfbedec719
commit 0f293bfc2b
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
state/execution.go
View File

@ -313,7 +313,6 @@ func (s *State) validateBlock(b *types.Block) error {
if _, err := s.VerifyEvidence(ev); err != nil { if _, err := s.VerifyEvidence(ev); err != nil {
return types.NewEvidenceInvalidErr(ev, err) return types.NewEvidenceInvalidErr(ev, err)
} }
// TODO: mark evidence as committed
} }
return nil return nil

3
types/evidence.go
View File

@ -126,9 +126,6 @@ func (dve *DuplicateVoteEvidence) Hash() []byte {
// Verify returns an error if the two votes aren't conflicting. // Verify returns an error if the two votes aren't conflicting.
// To be conflicting, they must be from the same validator, for the same H/R/S, but for different blocks. // To be conflicting, they must be from the same validator, for the same H/R/S, but for different blocks.
func (dve *DuplicateVoteEvidence) Verify(chainID string) error { func (dve *DuplicateVoteEvidence) Verify(chainID string) error {
// TODO: verify (cs.Height - dve.Height) < MaxHeightDiff
// H/R/S must be the same // H/R/S must be the same
if dve.VoteA.Height != dve.VoteB.Height || if dve.VoteA.Height != dve.VoteB.Height ||
dve.VoteA.Round != dve.VoteB.Round || dve.VoteA.Round != dve.VoteB.Round ||