From 0f293bfc2b64e76fda7aaed3f4a15201aa759736 Mon Sep 17 00:00:00 2001 From: Ethan Buchman Date: Mon, 20 Nov 2017 04:40:09 +0000 Subject: [PATCH] remove some TODOs --- state/execution.go | 1 - types/evidence.go | 3 --- 2 files changed, 4 deletions(-) diff --git a/state/execution.go b/state/execution.go index f6f6a314..a55bc5f8 100644 --- a/state/execution.go +++ b/state/execution.go @@ -313,7 +313,6 @@ func (s *State) validateBlock(b *types.Block) error { if _, err := s.VerifyEvidence(ev); err != nil { return types.NewEvidenceInvalidErr(ev, err) } - // TODO: mark evidence as committed } return nil diff --git a/types/evidence.go b/types/evidence.go index e270a0de..48c2d189 100644 --- a/types/evidence.go +++ b/types/evidence.go @@ -126,9 +126,6 @@ func (dve *DuplicateVoteEvidence) Hash() []byte { // Verify returns an error if the two votes aren't conflicting. // To be conflicting, they must be from the same validator, for the same H/R/S, but for different blocks. func (dve *DuplicateVoteEvidence) Verify(chainID string) error { - - // TODO: verify (cs.Height - dve.Height) < MaxHeightDiff - // H/R/S must be the same if dve.VoteA.Height != dve.VoteB.Height || dve.VoteA.Round != dve.VoteB.Round ||