fluencelabs/rust-libp2p
1
0
Fork 0
mirror of https://github.com/fluencelabs/rust-libp2p synced 2025-04-25 11:02:12 +00:00
Code Issues Projects Releases Wiki Activity

swarm-derive/lib: Don't clone error on inject_dial_failure (#2349)

Browse Source 
`NetworkBehaviour::inject_dial_failure` expects a reference for the error, thus
the error should not be cloned when passing it to the inner behaviours in the
`NetworkBehaviour` derivation.

Fixes Issue #2348.
This commit is contained in:
Elena Frank 2021-11-18 13:21:12 +01:00 committed by GitHub
parent 4bd44c812a
commit 17d6b4ba67
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -42,6 +42,11 @@
# `libp2p` facade crate
## Version 0.41.1 [unreleased]
- Update individual crates.
- `libp2p-swarm-derive`
## Version 0.41.0 [2021-11-16]
- Update individual crates.

4
Cargo.toml
View File

@ -2,7 +2,7 @@
name = "libp2p"
edition = "2018"
description = "Peer-to-peer networking library"
version = "0.41.0"
version = "0.41.1"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
@ -86,7 +86,7 @@ libp2p-relay = { version = "0.5.0", path = "protocols/relay", optional = true }
libp2p-rendezvous = { version = "0.2.0", path = "protocols/rendezvous", optional = true }
libp2p-request-response = { version = "0.14.0", path = "protocols/request-response", optional = true }
libp2p-swarm = { version = "0.32.0", path = "swarm" }
libp2p-swarm-derive = { version = "0.26.0", path = "swarm-derive" }
libp2p-swarm-derive = { version = "0.26.1", path = "swarm-derive" }
libp2p-uds = { version = "0.30.0", path = "transports/uds", optional = true }
libp2p-wasm-ext = { version = "0.30.0", path = "transports/wasm-ext", default-features = false, optional = true }
libp2p-yamux = { version = "0.34.0", path = "muxers/yamux", optional = true }

6
swarm-derive/CHANGELOG.md
View File

@ -1,3 +1,9 @@
# 0.26.1 [unreleased]
- Remove unnecessary clone of error in `inject_dial_failure` (see [PR 2349]).
[PR 2349]: https://github.com/libp2p/rust-libp2p/pull/2349
# 0.26.0 [2021-11-16]
- Adjust to advanced dialing requests API changes (see [PR 2317]).

2
swarm-derive/Cargo.toml
View File

@ -2,7 +2,7 @@
name = "libp2p-swarm-derive"
edition = "2018"
description = "Procedural macros of libp2p-core"
version = "0.26.0"
version = "0.26.1"
authors = ["Parity Technologies <admin@parity.io>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"

4
swarm-derive/src/lib.rs
View File

@ -276,10 +276,10 @@ fn build_struct(ast: &DeriveInput, data_struct: &DataStruct) -> TokenStream {
let inject = match field.ident {
Some(ref i) => {
quote! { self.#i.inject_dial_failure(peer_id, handler, error.clone()) }
quote! { self.#i.inject_dial_failure(peer_id, handler, error) }
}
None => {
quote! { self.#enum_n.inject_dial_failure(peer_id, handler, error.clone()) }
quote! { self.#enum_n.inject_dial_failure(peer_id, handler, error) }
}
};