antirez
4b615eea8f
Added tests for [SHZ]SCAN with MATCH.
2013-11-05 17:24:26 +01:00
antirez
54a5a7dff8
HSCAN/ZSCAN: skip value when matching.
...
This fixes issue #1360 and #1362 .
2013-11-05 17:24:22 +01:00
antirez
bebbc7f9f7
Pass int64_t to intsetGet() instead of long long.
2013-11-05 17:24:17 +01:00
antirez
736e343509
removed not used vars in dictScan().
2013-11-05 17:24:12 +01:00
antirez
59b30b327d
SCAN: no sdsEncodedObject() API in Redis 2.8.
2013-10-31 18:22:29 +01:00
antirez
3d3e350b12
SSCAN with integer encoded object test improved.
2013-10-31 10:38:56 +01:00
antirez
3cc7d486bc
Inverted variable boolean value and name after scanGenericCommand() refactoring.
2013-10-31 10:38:52 +01:00
antirez
06455014aa
scanGenericCommand() refactoring and handling of integer encoded elements.
...
This commit fixes issue #1354 .
2013-10-31 10:38:48 +01:00
antirez
141f30f421
Regression test added for [SHZ]SCAN issue #1354 .
2013-10-31 10:38:45 +01:00
antirez
c53cab5dde
Test: added a SCAN test trying to trigger HT resize.
2013-10-30 16:51:48 +01:00
antirez
ab6f4195dd
Test: added ZSCAN test.
2013-10-30 16:27:43 +01:00
antirez
13e879c9cf
Test: added HSCAN test.
2013-10-30 16:27:39 +01:00
antirez
9ea69a58ac
Test: added SSCAN test.
2013-10-30 16:27:36 +01:00
antirez
bd1962acc4
SCAN test keys sorting turned into more idiomatic Tcl.
2013-10-30 16:27:31 +01:00
antirez
02617b6e92
SCAN: tests moved to unit/scan.tcl.
2013-10-30 16:27:28 +01:00
antirez
bb2df795e0
Aesthetic fix (missing space) into HSCAN and ZSCAN implementations.
...
Thanks to @badboy for reporting.
2013-10-29 16:21:21 +01:00
antirez
35816a2e4d
ZSCAN implemented.
2013-10-29 16:21:18 +01:00
antirez
1cc7e646af
HSCAN implemented.
2013-10-29 16:21:13 +01:00
antirez
24ecabc995
SSCAN implemented.
2013-10-29 16:21:01 +01:00
antirez
17785f40b5
dictScan(): empty hash table requires special handling.
2013-10-29 16:20:13 +01:00
antirez
7f063b1c8c
SCAN is a random command and does not require output sorting.
...
Sorting the output helps when we want to turn a non-deterministic into a
deterministic command, in that case this is not possible.
2013-10-29 16:20:10 +01:00
antirez
9e62d9e79c
SCAN: refactored into scanGenericCommand.
...
The new implementation is capable of iterating the keyspace but also
sets, hashes, and sorted sets, and can be used to implement SSCAN, ZSCAN
and HSCAN.
2013-10-29 16:20:06 +01:00
antirez
1a06bbe430
Fixed typos in dictScan() comment.
2013-10-29 16:20:02 +01:00
antirez
0880bec4e2
dictScan() algorithm documented.
2013-10-29 16:19:57 +01:00
antirez
1d659784f4
SCAN: stay inside 80 cols.
2013-10-29 16:19:54 +01:00
antirez
854b8be616
Revert "Fixed typo in SCAN comment. iff -> if."
...
Probably here Pieter means "if and only if".
This reverts commit 43fdf3b404413f6e3b2c39ac491238c70ecee81c.
2013-10-29 16:19:49 +01:00
antirez
5fa5153bf5
SCAN: simplify keys list cleanup using listSetFreeMethod().
2013-10-29 16:19:45 +01:00
antirez
108c6e6734
SCAN: Fix test after option renamed from PATTERN to MATCH.
2013-10-29 16:19:41 +01:00
antirez
21da9b06a4
SCAN: improve variable names for readability.
2013-10-29 16:19:37 +01:00
antirez
907e06cd61
SCAN: remove additional newlines to conform to Redis code base.
2013-10-29 16:19:33 +01:00
antirez
b44f1589a4
SCAN: remove useless assertion, already enforced by command table.
2013-10-29 16:19:28 +01:00
antirez
d1c1f62ed5
SCAN: use define REDIS_LONGSTR_SIZE instead of fixed len.
2013-10-29 16:19:25 +01:00
antirez
8cdaf604ce
Fixed typo in SCAN comment. iff -> if.
2013-10-29 16:19:21 +01:00
antirez
33409b4c6c
SCAN option name changed: pattern -> match.
2013-10-29 16:19:17 +01:00
Pieter Noordhuis
fd22106a98
Fix error in scan algorithm
...
The irrelevant bits shouldn't be masked to 1. This can result in slots being
skipped when the hash table is resized between calls to the iterator.
2013-10-29 16:19:12 +01:00
Pieter Noordhuis
8c4ff679fe
SCAN requires at least 1 argument
2013-10-29 16:19:08 +01:00
Pieter Noordhuis
0dd95e23ab
Add SCAN command
2013-10-29 16:18:24 +01:00
antirez
9546f7846b
redis-benchmark: update help for new __rand_int__ form.
2013-10-28 18:14:11 +01:00
antirez
508d3c1bb7
Redis 2.7.105 (2.8 Release Candidate 5).
2.8.0-rc5
2013-10-09 13:08:42 +02:00
antirez
df0c96002d
Replication: install the write handler when reusing a cached master.
...
Sometimes when we resurrect a cached master after a successful partial
resynchronization attempt, there is pending data in the output buffers
of the client structure representing the master (likely REPLCONF ACK
commands).
If we don't reinstall the write handler, it will never be installed
again by addReply*() family functions as they'll assume that if there is
already data pending, the write handler is already installed.
This bug caused some slaves after a successful partial sync to never
send REPLCONF ACK, and continuously being detected as timing out by the
master, with a disconnection / reconnection loop.
2013-10-04 16:14:57 +02:00
antirez
d7fa6d9aba
Replication: fix master timeout.
...
Since we started sending REPLCONF ACK from slaves to masters, the
lastinteraction field of the client structure is always refreshed as
soon as there is room in the socket output buffer, so masters in timeout
are detected with too much delay (the socket buffer takes a lot of time
to be filled by small REPLCONF ACK <number> entries).
This commit only counts data received as interactions with a master,
solving the issue.
2013-10-04 13:01:49 +02:00
antirez
c8c1006cf4
PSYNC: safer handling of PSYNC requests.
...
There was a bug that over-esteemed the amount of backlog available,
however this could only happen when a slave was asking for an offset
that was in the "future" compared to the master replication backlog.
Now this case is handled well and logged as an incident in the master
log file.
2013-10-04 12:27:40 +02:00
antirez
81f614ef6f
Add REWRITE to CONFIG subcommands help message.
2013-10-04 12:27:36 +02:00
Michel Martens
20c506f432
Document the redis-cli --csv option.
2013-09-26 10:12:51 +02:00
antirez
af967ff9cb
Allow AUTH / PING when disconnected from slave and serve-stale-data is no.
2013-09-17 09:46:40 +02:00
antirez
2d55f1ca7f
redis-cli: fix big keys search when the key no longer exist.
...
The code freed a reply object that was never created, resulting in a
segfault every time randomkey returned a key that was deleted before we
queried it for size.
2013-09-04 10:37:55 +02:00
Maxim Zakharov
9a0f27a5d0
mistype fixed
2013-09-03 15:15:42 +02:00
Maxim Zakharov
c713b1ebdd
A mistype fixed
2013-09-03 15:15:34 +02:00
antirez
56ce068664
Redis 2.7.104 (2.8 Release Candidate 4).
2.8.0-rc4
2013-08-30 09:52:18 +02:00
antirez
23acf93f97
Test: Lua stack leak regression test added.
2013-08-30 08:59:16 +02:00