4808 Commits

Author SHA1 Message Date
antirez
45ff739cdf Fix iterator for issue #2438.
Itereator misuse due to analyzeLatencyForEvent() accessing the
dictionary during the iteration, without the iterator being
reclared as safe.
2015-03-04 11:49:48 -08:00
antirez
938dfdc1ea Migrate: replace conditional with pre-computed value. 2015-02-27 22:34:18 +01:00
antirez
53659404e4 Improvements to PR #2425
1. Remove useless "cs" initialization.
2. Add a "select" var to capture a condition checked multiple times.
3. Avoid duplication of the same if (!copy) conditional.
4. Don't increment dirty if copy is given (no deletion is performed),
   otherwise we propagate MIGRATE when not needed.
2015-02-26 10:29:02 +01:00
Salvatore Sanfilippo
968ce96474 Merge pull request #2425 from twang817/migrateCacheDbid
Add last_dbid to migrateCachedSocket to avoid redundant SELECT
2015-02-26 10:17:13 +01:00
Tommy Wang
97c4167aa1 Add last_dbid to migrateCachedSocket to avoid redundant SELECT
Avoid redundant SELECT calls when continuously migrating keys to
the same dbid within a target Redis instance.
2015-02-25 13:08:35 -06:00
antirez
2c27b887b1 Merge branch 'testing' into 3.0 2015-02-13 08:55:31 +01:00
antirez
b9602d96e3 Redis 2.9.104 (3.0.0 Release Candidate 4). 3.0.0-rc4 2015-02-13 08:55:23 +01:00
antirez
36c62ae799 Merge branch 'testing' into 3.0 2015-02-12 16:55:43 +01:00
antirez
9e6155f4f8 Extend memory unit support in CONFIG SET.
Related to PR #2357.
2015-02-12 16:54:38 +01:00
antirez
304aa59c49 Better memtoll() error checking.
Related to PR #2357.
2015-02-12 16:54:38 +01:00
Chris Lamb
260cfcf7bd Support "1G" etc. units in CONFIG SET maxmemory
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2015-02-12 16:54:30 +01:00
antirez
5bcaff429d Merge branch 'testing' into 3.0 2015-02-11 11:01:50 +01:00
antirez
967590de6e Separate latency monitoring of eviction loop and eviction DELs. 2015-02-11 11:01:46 +01:00
antirez
541eb23895 dict.c: reset emptylen when bucket is not empty.
Fixed by @oranagra, thank you.
2015-02-11 11:01:46 +01:00
antirez
08ad51762b redis-cli --stat: show LOAD when loading. 2015-02-11 11:01:46 +01:00
antirez
eaae581b55 Remove optional single-key path from evictionPoolPopulate(). 2015-02-11 11:01:46 +01:00
antirez
05a398389f dict.c: add dictGetSomeKeys(), specialized for eviction. 2015-02-11 11:01:46 +01:00
antirez
7014e1afc2 dict.c: avoid code repetition in dictRehash().
Avoid code repetition introduced with PR #2367, also fixes the return
value to always return 0 if there is nothing more to rehash.
2015-02-11 11:01:46 +01:00
Sun He
aa3de04232 dict.c/dictRehash: check again to update 2015-02-11 11:01:46 +01:00
antirez
252ebcd973 dict.c: don't try buckets that are empty for sure in dictGetRandomKey().
This is very similar to the optimization applied to dictGetRandomKeys,
but applied to the single key variant.

Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
a355568c1a dict.c: dictGetRandomKeys() optimization for big->small table case.
Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
eb4859db05 dict.c: dictGetRandomKeys() visit pattern optimization.
We use the invariant that the original table ht[0] is never populated up
to the index before the current rehashing index.

Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
e2ab7be33c dict.c: put a bound to max work dictRehash() call can do.
Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
40f64bc68a dict.c: prevent useless resize to same size.
Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
b7d20a2000 Less blocking dictGetRandomKeys().
Related to issue #2306.
2015-02-11 11:01:46 +01:00
antirez
d4f37363a4 Merge branch 'testing' into 3.0 2015-02-10 14:54:09 +01:00
Charles Hooper
3a0e69f391 override histfile from env - fixes #831 and copies #833 2015-02-10 14:52:32 +01:00
antirez
c3a5ad2018 redis-cli --lru-test implemented (cache workload simulator). 2015-02-10 14:51:25 +01:00
antirez
4793ea982a redis-cli: interactive reconnection for latency modes.
--stat mode already used to reconnect automatically if the server is no
longer available. This is useful since this is an interactive mode used
for debugging, however the same applies to --latency and --latency-dist
modes, so now both use the reconnecting command execution as well.

The reconnection code was modified to use basic VT100 escape sequences
in order to play better with different kinds of output on the screen
when the reconnection happens, and to hide the reconnection attempt
output when finally the reconnection happens.
2015-02-10 14:51:25 +01:00
antirez
9a4d71e92e redis-cli --latecy-dist reverted to gray scale.
So far not able to find a color palette within the 256 colors which is
not confusing. However I believe it is a possible task, so will try
better later.
2015-02-10 14:51:25 +01:00
antirez
ad9976cd90 redis-cli --latency-dist now uses a color palette.
Still not happy with the result but low grays are hard to see in certain
monitors with a non perfect gamma.
2015-02-10 14:51:25 +01:00
antirez
b857578ba2 redis-cli latency dist: add new top HL. 2015-02-10 14:51:25 +01:00
antirez
630634a37a Add missing latency-dest legend symbol. 2015-02-10 14:51:25 +01:00
antirez
cdf30ba8c7 Initial implementation of redis-cli --latency-dist. 2015-02-10 14:51:25 +01:00
antirez
9c40565bbe Faster memory efficiency test.
This test on Linux was extremely slow, since in Tcl we can't enable
easily tcp-nodelay, so the busy loop used to take *a lot* with bigger
writes. Fixed using pipelining.
2015-02-10 14:48:25 +01:00
antirez
bee03daca7 Faster memory efficiency test.
This test on Linux was extremely slow, since in Tcl we can't enable
easily tcp-nodelay, so the busy loop used to take *a lot* with bigger
writes. Fixed using pipelining.
2015-02-10 14:48:19 +01:00
antirez
1475853f20 Ignore config.sh inside create-cluster script dir. 2015-02-03 10:11:43 +01:00
antirez
560823f54c Ignore config.sh inside create-cluster script dir. 2015-02-03 10:11:40 +01:00
mattcollier
1aed310c0c Update redis-cli.c
Code was adding '\n'  (line 521) to the end of NIL values exlusively making csv output inconsistent.  Removed '\n'
2015-02-02 22:50:48 +01:00
mattcollier
7db39b7fd3 Update redis-cli.c
Code was adding '\n'  (line 521) to the end of NIL values exlusively making csv output inconsistent.  Removed '\n'
2015-02-02 22:50:45 +01:00
antirez
9b3a1c3c40 Redis 2.9.103 (3.0.0 Release Candidate 3). 3.0.0-rc3 2015-01-30 15:34:16 +01:00
antirez
9389d050e3 Merge branch 'testing' into 3.0 2015-01-30 12:18:54 +01:00
antirez
19029a4ebc Cluster: Tcl script to check avg pfail->fail time. 2015-01-30 12:18:42 +01:00
antirez
55f2bc646a Cluster: some bias towwards FAIL/PFAIL nodes in gossip sections.
This improves PFAIL -> FAIL switch. Too late at this point in the RC
releases to add proper PFAIL/FAIL separate dictionary to do this in a
less randomized way. Tested in practice with experiments that this
helps. PFAIL -> FAIL average with 20 nodes and node-timeout set to 5
seconds takes 2.5 seconds without this commit, 1 second with this
commit.
2015-01-30 12:18:42 +01:00
antirez
0f1b9c3db1 More correct wanted / maxiterations values in clusterSendPing(). 2015-01-30 12:18:42 +01:00
antirez
96368c2d0b Cluster: create-cluster script improved. 2015-01-30 12:18:42 +01:00
antirez
f2cd2fcdb7 Cluster: initialized not used fileds in gossip section.
Otherwise we risk sending not initialized data to other nodes, that may
contain anything. This was actually not possible only because the
initialization of the buffer where the cluster packets header is created
was larger than the 3 gossip sections we use, so the memory was already
all filled with zeroes by the memset().
2015-01-29 15:52:23 +01:00
antirez
2553f6c9e5 Cluster: initialized not used fileds in gossip section.
Otherwise we risk sending not initialized data to other nodes, that may
contain anything. This was actually not possible only because the
initialization of the buffer where the cluster packets header is created
was larger than the 3 gossip sections we use, so the memory was already
all filled with zeroes by the memset().
2015-01-29 15:52:17 +01:00
antirez
147df6f035 Merge branch 'testing' into 3.0 2015-01-29 15:45:21 +01:00
antirez
2616d6f6dc Cluster: magical 10% of nodes explained in comments. 2015-01-29 15:44:54 +01:00