4535 Commits

Author SHA1 Message Date
antirez
290d33d68e Sentinel: don't set announce-ip if is empty. 2014-09-10 09:26:23 +02:00
antirez
a3adeb284e Sentinel: clarify announce-ip/port options in sentinel.conf. 2014-09-10 09:26:23 +02:00
antirez
e2eb5c8c83 Sentinel: announce ip/port changes + rewrite.
The original implementation was modified in order to allow to
selectively announce a different IP or port, and to rewrite the two
options in the config file after a rewrite.
2014-09-10 09:26:23 +02:00
Dara Kong
869a97b127 sentinel: Decouple bind address from address sent to other sentinels
There are instances such as EC2 where the bind address is private
(behind a NAT) and cannot be accessible from WAN.

https://groups.google.com/d/msg/redis-db/PVVvjO4nMd0/P3oWC036v3cJ
2014-09-10 09:26:23 +02:00
antirez
3d2c82b489 Tests for aof-load-truncated = yes. 2014-09-08 10:57:03 +02:00
antirez
ea6082f1d5 AOF tests fixed turning aof-load-truncated to no.
When aof-load-truncated option was introduced, with a default of "yes",
the past behavior of the server to abort with trunncated AOF changed, so
we need to explicitly configure the tests to abort with truncated AOF
by setting the option to no.
2014-09-08 10:57:03 +02:00
antirez
c65af33c01 Make aof-load-truncated option actually configurable. 2014-09-08 10:57:03 +02:00
antirez
24b3f78f21 Correct cleanup when aborting AOF loading.
Because of the new ability to start with a truncated AOF, we need
to correctly release all the memory on EOF error. Otherwise there is a
small leak, that is not really a problem, but causes a false positive in
the tests that detect memory leaks.
2014-09-08 10:57:03 +02:00
antirez
ea1de5cdf9 AOF ability to load truncated files. 2014-09-08 10:57:03 +02:00
antirez
46ec968326 Test AOF format error detection. 2014-09-08 10:57:03 +02:00
antirez
a4ec67290e AOF loading: split handling of format errors from unexpected EOF. 2014-09-08 10:57:03 +02:00
Matt Stancliff
5bb0da34ba Return empty string if GETRANGE of empty string
Previously, GETRANGE of a key containing nothing ("")
would allocate a large (size_t)-1 return value causing
crashes on 32bit builds when it tried to allocate the
4 GB return string.
2014-09-04 11:47:25 +02:00
Matt Stancliff
682914153c Increase size of range request in getrange
32 bit builds don't have a big enough long to capture
the same range as a 64 bit build.  If we use "long long"
we get proper size limits everywhere.

Also updates size of unsigned comparison to fit new size of `end`.

Fixes #1981
2014-09-04 11:46:59 +02:00
Matt Stancliff
e713dc5a43 Sentinel: Abort Hello quicker if not connected
We can save a little work by aborting when we enter the function
if we're disconnected.
2014-09-01 16:35:06 +02:00
Paddy Byers
98bd223edd Add regression test for issue #1939 2014-09-01 10:42:29 +02:00
Paddy Byers
b790e1d7e5 Store the length of the static argv when first allocated. 2014-09-01 10:42:29 +02:00
antirez
a3f3f823d1 Fix dictRehash assert casting type.
Also related to #1929.
2014-08-26 10:41:03 +02:00
antirez
20f20b832a Cast to right type in dictNext().
This closes issue #1929, the other part was fixed in the context of issue
2014-08-26 10:41:03 +02:00
antirez
723a090861 Use long for rehash and iterator index in dict.h.
This allows to support datasets with more than 2 billion of keys
(possible in very large memory instances, this bug was actually
reported).

Closes issue #1814.
2014-08-26 10:41:03 +02:00
antirez
dfa7ff1c4c Missing va_end also added in hiredis copy of sds.c. 2014-08-26 10:41:03 +02:00
Mariano Pérez Rodríguez
d15c6e5e33 Missing assert removal from sdsIncrLen()
Companion for 8eeb1802ec42682a614a5ebca318a0ba44ca7c03, but dealing with hiredis.
2014-08-26 10:41:03 +02:00
antirez
85b20f1f70 Use modern typedef form in cluster.h. 2014-08-26 10:41:03 +02:00
antirez
6f98a9cd2c No longer useful assert removed from sdsIncrLen(). 2014-08-26 10:41:03 +02:00
Matt Stancliff
660a2f87a1 Fix redis-benchmark abort output 2014-08-26 10:41:03 +02:00
Matt Stancliff
601e06da8a Deny CLIENT command in scripts
We don't want scripts doing CLIENT SETNAME
or CLIENT KILL or CLIENT LIST or CLIENT PAUSE.

Originally reported by Chris Wj then proper
action inspired by Itamar Haber.

Reference: https://groups.google.com/forum/#!topic/redis-db/09B2EYwyVgk
2014-08-26 10:41:03 +02:00
Matt Stancliff
01e0112def redis-benchmark: Remove unused buffer
This just deletes old code that didn't get removed when
logic changed.  We were setting offsets that never
got read anywhere.

Since clients are now just cloned, we don't need to track
per-client buffer offsets anywhere because they are all
the same from the original client.
2014-08-26 10:41:03 +02:00
CharSyam
75ce984723 redis-benchmark: add auth option
Closes #1097
2014-08-26 10:41:03 +02:00
Matt Stancliff
29af582617 Rename two 'buf' vars to 'ip' for better clarity
Clearly ip[32] is wrong, but it's less clear that buf[32] was wrong
without further reading.
2014-08-26 10:41:03 +02:00
Eiichi Sato
4e062ec82e Sentinel: fix bufsize to support IPv6 address
Closes #1914
2014-08-26 10:41:03 +02:00
Jan-Erik Rediger
ef2cb6c722 Use correct github url to find commands.json
Once this is merged:
  - merge the latest changes to commands.json in antirez/redis-doc
  - re-run: utils/generate-command-help.rb > src/help.h

Then we'll have nice and easy tab-completed help in redis-cli again.

Closes #1909
2014-08-26 10:41:03 +02:00
Mariano Pérez Rodríguez
4f29e859cf Stop tests from leaving a black background
Uses ANSI "default background" color code after closing tests
so any non-black terminals don't remain polluted.

Fixes #1649
Closes #1912
2014-08-26 10:41:03 +02:00
Matt Stancliff
21fb95b91e Sentinel: Reject config from STDIN
Sentinel needs to die with a more accurate error message
when attempted to open a config from STDIN.

See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
2014-08-26 10:41:03 +02:00
Matt Stancliff
3e22384193 Cluster: Fix segfault if cluster config corrupt
This commit adds a size check after initial config
line parsing to make sure we have *at least* 8 arguments
per line.

Also, instead of asserting for cluster->myself, we just test
and error out normally (since the error does a hard exit anyway).

Closes #1597
2014-08-26 10:41:03 +02:00
Matt Stancliff
29ff27d430 Fix memory leak in cluster config parsing
The continue stop us from triggering the
free after the long line for loop, so add it
earlier.
2014-08-26 10:41:03 +02:00
Matt Stancliff
7df0636514 Remove unused global variable
It has an important name, but nothing uses it...
2014-08-26 10:41:03 +02:00
antirez
d1e91c3fcc Fix invalid expire error for SET family commands. 2014-08-26 10:41:03 +02:00
Cong Ding
9d046af1e5 Remove unused function
Closes #878
2014-08-26 10:41:03 +02:00
David Palm
55672e06fd Extend range of bytesToHuman to TB and PB
Also adds a fallthrough case for when given
large values (like overflow numbers of 2^64 by mistake).

Closes #858
2014-08-26 10:41:03 +02:00
yoav
512cc03b55 Add error check for writing RDB checksum
Closes #857
2014-08-26 10:41:03 +02:00
Dov Murik
9da7141dc6 redis-cli: fix prompt after shutdown command
Fix redis-cli prompt to state "not connected" after a SHUTDOWN command
is sent.
2014-08-26 10:41:02 +02:00
xiaoyu
b88fe07bc0 Clarify argument to dict macro
d is more clear because the type of argument is dict not dictht

Closes #513
2014-08-26 10:41:02 +02:00
Matt Stancliff
d409b5acd3 Clarify existing slot wording on cluster start 2014-08-26 10:41:02 +02:00
antirez
125ac18944 Fix undefined behavior in ll2string().
The bug was found by @CAFxX, thanks!
See issue #1940.
2014-08-26 10:41:02 +02:00
antirez
d34fade2da Remove warnings and improve integer sign correctness. 2014-08-26 10:41:02 +02:00
antirez
5d6c0b1be3 Add -W to compilation flags. 2014-08-26 10:41:02 +02:00
antirez
3566020acf Use unsigned integers in SDS header.
This raises the max string to 4GB without any downside.
2014-08-26 10:41:02 +02:00
Pieter Noordhuis
327831e59e va_copy must be matched by va_end
Hat tip to @rfuchs. See: https://github.com/redis/hiredis/pull/178.

Fixes #1187
2014-08-26 10:41:02 +02:00
charsyam
748a36cf04 Remove duplicate prototypes in redis.h
Also moves acceptHandler() to be near the other accept...() functions.

Closes #1105
2014-08-26 10:41:02 +02:00
NanXiao
f5e8d29990 Use resolv library in Solaris
For some Solaris flavours, the inet_aton in in resolv library.
Not linking this library will introduce link error.

Improves compatability with older Solaris and still
works on new Solaris.

Closes #1092
2014-08-26 10:41:02 +02:00
Daniel Price
3e6578e32f Define AR to help with lua cross-compilation
Closes #997
2014-08-26 10:41:02 +02:00