Salvatore Sanfilippo
1d9d27c91a
Merge pull request #6438 from daidaotong/unstable
...
resolve typo in test module
2019-10-10 11:18:47 +02:00
antirez
509fe9cba1
Merge branch 'unstable' of github.com:/antirez/redis into unstable
2019-10-10 10:31:43 +02:00
antirez
747be463d2
Cluster: fix memory leak of cached master.
...
This is what happened:
1. Instance starts, is a slave in the cluster configuration, but
actually server.masterhost is not set, so technically the instance
is acting like a master.
2. loadDataFromDisk() calls replicationCacheMasterUsingMyself() even if
the instance is a master, in the case it is logically a slave and the
cluster is enabled. So now we have a cached master even if the instance
is practically configured as a master (from the POV of
server.masterhost value and so forth).
3. clusterCron() sees that the instance requires to replicate from its
master, because logically it is a slave, so it calls
replicationSetMaster() that will in turn call
replicationCacheMasterUsingMyself(): before this commit, this call would
overwrite the old cached master, creating a memory leak.
2019-10-10 10:23:34 +02:00
Daniel Dai
98600c9a11
update typo
2019-10-09 14:15:31 -04:00
Salvatore Sanfilippo
a92921da13
Merge pull request #6430 from jaamison/jj/unstable
...
stream.h: fix typo
2019-10-08 17:40:47 +02:00
Salvatore Sanfilippo
17bf0b25c1
Merge pull request #6427 from oranagra/static-analyzer
...
fix issues found by a static analyzer
2019-10-08 17:10:57 +02:00
antirez
009862ab7e
Geo: output 10 chars of geohash, not 11.
...
This does not limit the actual precision, because the last digit bits were
garbage, and the shift value became even negative in the last iteration.
2019-10-08 17:09:37 +02:00
Jamison Judge
3ef6b79c80
stream.h: fix typo
2019-10-07 11:01:01 -07:00
antirez
c65347ab17
LOLWUT: version 6: change text message & credits.
2019-10-07 19:19:38 +02:00
antirez
c448f6fe55
LOLWUT: version 6: give credits.
2019-10-07 18:57:25 +02:00
antirez
58cdc054e3
LOLWUT: version 6: improve rithm of the image.
2019-10-07 18:41:29 +02:00
antirez
c10889150e
LOLWUT: version 6 initial output. May change a bit.
2019-10-07 18:24:34 +02:00
antirez
f019f28e7b
LOLWUT: version 6 initial concept.
2019-10-07 12:35:17 +02:00
Oran Agra
d1a005ab39
fix issues found by a static analyzer
...
cluster.c - stack buffer memory alignment
The pointer 'buf' is cast to a more strictly aligned pointer type
evict.c - lazyfree_lazy_eviction, lazyfree_lazy_eviction always called
defrag.c - bug in dead code
server.c - casting was missing parenthesis
rax.c - indentation / newline suggested an 'else if' was intended
2019-10-07 09:09:32 +03:00
antirez
bd60447066
LOLWUT: ability to specify VERSION <ver> option.
2019-10-04 19:19:54 +02:00
antirez
9073d56eec
LOLWUT: refactoring + skeleton of LOLWUT 6.
2019-10-04 19:19:48 +02:00
antirez
ee1cef189f
Minor aesthetic changes to #6419 .
2019-10-04 12:00:41 +02:00
Salvatore Sanfilippo
264778af0a
Merge pull request #6419 from oranagra/lua_timeout_sha
...
On LUA script timeout, print the script SHA to the log
2019-10-04 11:58:05 +02:00
Salvatore Sanfilippo
c326f28833
Merge pull request #6308 from oranagra/repl-diskless-load-config
...
fix error handling on config parsing of repl-diskless-load
2019-10-04 11:56:08 +02:00
antirez
3eaff2941e
Modules: RM_Call(): give pointer to documentation.
2019-10-04 11:46:53 +02:00
antirez
2a81e49dde
Modules: RM_Call/Replicate() ability to exclude AOF/replicas.
2019-10-04 11:44:53 +02:00
antirez
1b8b8c029f
Modules: add RM_Replicate() Tcl test file & fix the module.
2019-10-03 18:44:50 +02:00
antirez
55a3da87f8
Modules: RM_Replicate() test with threads.
2019-10-03 13:23:53 +02:00
antirez
45cd8e03ca
Modules: RM_Replicate() test module: initial implementation.
2019-10-03 13:06:13 +02:00
antirez
1bca62c4b7
Modules: RM_Replicate() in thread safe contexts.
2019-10-03 11:03:46 +02:00
antirez
e938bbc543
Modules: implement RM_Replicate() from async callbacks.
2019-10-03 10:56:37 +02:00
antirez
c549513acd
Modules: handle propagation when ctx is freed. Flag modules commands ctx.
2019-10-02 18:33:40 +02:00
antirez
758b39be99
Speedup INFO server section.
2019-10-02 11:30:20 +02:00
antirez
f49f0a6f72
SDS: make sdscatfmt() faster by pre-allocating a bit.
2019-10-02 11:30:20 +02:00
Oran Agra
98426e9886
On LUA script timeout, print the script SHA to the log
...
since the slowlog and other means that can help you detect the bad script
are only exposed after the script is done. it might be a good idea to at least
print the script name (sha) to the log when it timeouts.
2019-10-02 08:40:35 +03:00
antirez
40acb4412d
GEORADIUS reply: fix of the previous fix about #6417 .
2019-10-01 19:18:55 +02:00
Salvatore Sanfilippo
2e2fe98f9c
Merge pull request #6270 from oranagra/modules_info
...
Extend modules API to allow modules report to redis INFO
2019-10-01 18:02:33 +02:00
antirez
3281ebb495
Fix GEORADIUS replies broken after RESP3 introduction.
...
This commit fixes #6417 .
2019-10-01 10:38:56 +02:00
antirez
beebb3c013
Merge branch 'hashed-pass-opcode' into unstable
2019-10-01 10:33:04 +02:00
Oran Agra
1b4f888109
Use sdscatfmt instead of sdscatprintf in module info
...
sdscatfmt is faster
2019-09-30 21:13:13 +03:00
Oran Agra
d5c14c70b7
Merge remote-tracking branch 'antirez/unstable' into modules_info
2019-09-30 20:47:35 +03:00
antirez
a9628142fd
Clarify a comment about memory total_frag field.
2019-09-30 18:37:59 +02:00
antirez
09041b9359
ACLs: change hashed passwords opcode to also remove them.
...
Related to PR #6405
2019-09-30 18:28:45 +02:00
Madelyn Olson
ea7c3fe7fd
Allowed passing in of password hash and fixed config rewrite
2019-09-30 17:57:49 +02:00
Salvatore Sanfilippo
eb2114b9cd
Merge pull request #6411 from nikhilajayk/unstable
...
Added cluster host and protected mode variables to the create cluster script.
2019-09-30 17:46:09 +02:00
Salvatore Sanfilippo
2478b47b89
Merge pull request #6304 from dbenders/fix-issue-6141
...
Fix issue #6141 : cluster rebalance does not support binary key
2019-09-30 17:43:58 +02:00
antirez
6a2831c24a
Fix comments aesthetics.
2019-09-30 17:17:36 +02:00
antirez
23f5cb4233
Change a bit the style of #6385 .
2019-09-30 10:58:15 +02:00
Salvatore Sanfilippo
ad45d7e407
Merge pull request #6385 from filipecosta90/perf-reply-ss-error
...
Improve performance of RM_ReplyWithSimpleString and RM_ReplyWi…
2019-09-30 10:57:05 +02:00
antirez
916c4e5d86
moduleRDBLoadError(): io->ctx may be NULL.
...
The correct way to access the module about a given IO context is to
deference io->type->module, since io->ctx is only populated if the user
requests an explicit context from an IO object.
2019-09-27 18:42:38 +02:00
antirez
8b5848a4f5
Fix memory leak in moduleLoadFromQueue().
2019-09-27 18:33:21 +02:00
antirez
b394817754
Fix memory leak in RM_UnregisterCommandFilter().
2019-09-27 18:33:05 +02:00
antirez
0a07f8ffee
TerminateModuleForkChild(): fix function prototype.
2019-09-27 12:23:07 +02:00
antirez
721d3c9e0c
TerminateModuleForkChild(): move safety checks there.
...
We don't want that the API could be used directly in an unsafe way,
without checking if there is an active child. Now the safety checks are
moved directly in the function performing the operations.
2019-09-27 12:17:47 +02:00
antirez
de1f82aa33
Function renamed hasForkChild() -> hasActiveChildProcess().
2019-09-27 12:03:09 +02:00