fluencelabs/redis
1
0
Fork 0
mirror of https://github.com/fluencelabs/redis synced 2025-06-11 16:21:21 +00:00
Code Issues Projects Releases Wiki Activity

uphold the smove contract to return 0 when the element is not a member of the source set, even if source=dest

Browse Source
This commit is contained in:
Glenn Nethercutt
2015-04-17 09:27:54 -04:00
committed by antirez
parent bea224308b
commit 19382c8be6
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/t_set.c
View File

@ -321,7 +321,10 @@ void smoveCommand(redisClient *c) {
/* If srcset and dstset are equal, SMOVE is a no-op */
if (srcset == dstset) {
addReply(c,shared.cone);
if (setTypeIsMember(srcset,ele))
addReply(c,shared.cone);
else
addReply(c,shared.czero);
return;
}

1
tests/unit/type/set.tcl
View File

@ -450,6 +450,7 @@ start_server {
test "SMOVE non existing key" {
setup_move
assert_equal 0 [r smove myset1 myset2 foo]
assert_equal 0 [r smove myset1 myset1 foo]
assert_equal {1 a b} [lsort [r smembers myset1]]
assert_equal {2 3 4} [lsort [r smembers myset2]]
}