fluencelabs/musl
1
0
Fork 0
mirror of https://github.com/fluencelabs/musl synced 2025-04-24 14:52:13 +00:00
Code Issues Projects Releases Wiki Activity

make getcwd fail if it cannot obtain an absolute path

Browse Source 
Currently getcwd(3) can succeed without returning an absolute path
because the underlying getcwd syscall, starting with linux commit
v2.6.36-rc1~96^2~2, may succeed without returning an absolute path.

This is a conformance issue because "The getcwd() function shall
place an absolute pathname of the current working directory
in the array pointed to by buf, and return buf".

Fix this by checking the path returned by syscall and failing with
ENOENT if the path is not absolute.  The error code is chosen for
consistency with the case when the current directory is unlinked.

Similar issue was fixed in glibc recently, see
https://sourceware.org/bugzilla/show_bug.cgi?id=22679
This commit is contained in:
Dmitry V. Levin 2018-01-12 18:12:24 +03:00 committed by Rich Felker
parent 376b3c54bb
commit 23ddab8569
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/unistd/getcwd.c
View File

@ -14,6 +14,12 @@ char *getcwd(char *buf, size_t size)
errno = EINVAL;
return 0;
}
if (syscall(SYS_getcwd, buf, size) < 0) return 0;
long ret = syscall(SYS_getcwd, buf, size);
if (ret < 0)
return 0;
if (ret == 0 || buf[0] != '/') {
errno = ENOENT;
return 0;
}
return buf == tmp ? strdup(buf) : buf;
}