Fix libp2p/js-libp2p#179 - Don't crash when receiving invalid data

src/dialer.js

@@ -30,11 +30,23 @@ module.exports = (conn, callback) => {
         }
 
         const peerInfo = new PeerInfo(id)
-        input.listenAddrs
-          .map(multiaddr)
-          .forEach((ma) => peerInfo.multiaddrs.add(ma))
+        try {
+          input.listenAddrs
+            .map(multiaddr)
+            .forEach((ma) => peerInfo.multiaddrs.add(ma))
+        } catch (err) {
+          return callback(err)
+        }
 
-        callback(null, peerInfo, getObservedAddrs(input))
+        let observedAddr
+
+        try {
+          observedAddr = getObservedAddrs(input)
+        } catch (err) {
+          return callback(err)
+        }
+
+        callback(null, peerInfo, observedAddr)
       })
     })
   )

test/dialer.spec.js

@@ -60,4 +60,52 @@ describe('identify.dialer', () => {
       done()
     })
   })
+
+  it('does not crash with invalid listen addresses', (done) => {
+    const p = pair()
+    original.multiaddrs.add(multiaddr('/ip4/127.0.0.1/tcp/5002'))
+    const input = msg.encode({
+      protocolVersion: 'ipfs/0.1.0',
+      agentVersion: 'na',
+      publicKey: original.id.pubKey.bytes,
+      listenAddrs: [Buffer.from('ffac010203')],
+      observedAddr: Buffer.from('ffac010203')
+    })
+
+    pull(
+      pull.values([input]),
+      lp.encode(),
+      p[0]
+    )
+
+    identify.dialer(p[1], (err, info, observedAddrs) => {
+      expect(err).to.exist()
+
+      done()
+    })
+  })
+
+  it('does not crash with invalid observed address', (done) => {
+    const p = pair()
+    original.multiaddrs.add(multiaddr('/ip4/127.0.0.1/tcp/5002'))
+    const input = msg.encode({
+      protocolVersion: 'ipfs/0.1.0',
+      agentVersion: 'na',
+      publicKey: original.id.pubKey.bytes,
+      listenAddrs: [multiaddr('/ip4/127.0.0.1/tcp/5002').buffer],
+      observedAddr: Buffer.from('ffac010203')
+    })
+
+    pull(
+      pull.values([input]),
+      lp.encode(),
+      p[0]
+    )
+
+    identify.dialer(p[1], (err, info, observedAddrs) => {
+      expect(err).to.exist()
+
+      done()
+    })
+  })
 })