chore: release version v0.14.4

Bumps [sinon](https://github.com/sinonjs/sinon) from 8.1.1 to 9.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v8.1.1...v9.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

CHANGELOG.md

@@ -1,3 +1,14 @@
+<a name="0.14.4"></a>
+## [0.14.4](https://github.com/libp2p/js-libp2p-tcp/compare/v0.14.3...v0.14.4) (2020-02-24)
+
+
+### Bug Fixes
+
+* catch thrown maConn errors in listener ([#122](https://github.com/libp2p/js-libp2p-tcp/issues/122)) ([86db568](https://github.com/libp2p/js-libp2p-tcp/commit/86db568)), closes [#121](https://github.com/libp2p/js-libp2p-tcp/issues/121)
+* remove use of assert module ([#123](https://github.com/libp2p/js-libp2p-tcp/issues/123)) ([6272876](https://github.com/libp2p/js-libp2p-tcp/commit/6272876))
+
+
+
 <a name="0.14.3"></a>
 ## [0.14.3](https://github.com/libp2p/js-libp2p-tcp/compare/v0.14.2...v0.14.3) (2019-12-20)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "libp2p-tcp",
-  "version": "0.14.3",
+  "version": "0.14.4",
   "description": "Node.js implementation of the TCP module that libp2p uses, which implements the interface-connection and interface-transport interfaces",
   "leadMaintainer": "Jacob Heun <jacobheun@gmail.com>",
   "main": "src/index.js",
@@ -33,12 +33,12 @@
     "npm": ">=3.0.0"
   },
   "devDependencies": {
-    "aegir": "^20.4.1",
+    "aegir": "^21.0.2",
     "chai": "^4.2.0",
     "dirty-chai": "^2.0.1",
     "libp2p-interfaces": "^0.2.0",
     "it-pipe": "^1.1.0",
-    "sinon": "^7.5.0",
+    "sinon": "^9.0.0",
     "streaming-iterables": "^4.1.1"
   },
   "dependencies": {
@@ -52,24 +52,22 @@
     "stream-to-it": "^0.2.0"
   },
   "contributors": [
-    "Alan Shaw <alan.shaw@protocol.ai>",
-    "Alan Shaw <alan@tableflip.io>",
     "David Dias <daviddias.p@gmail.com>",
+    "Jacob Heun <jacobheun@gmail.com>",
+    "Stephen Whitmore <stephen.whitmore@gmail.com>",
+    "Friedel Ziegelmayer <dignifiedquire@gmail.com>",
+    "Vasco Santos <vasco.santos@moxy.studio>",
+    "Richard Littauer <richard.littauer@gmail.com>",
+    "Tom White <tomtinkerer@gmail.com>",
+    "Alan Shaw <alan@tableflip.io>",
+    "Pedro Teixeira <i@pgte.me>",
+    "Prashanth Chandra <coolshanth94@gmail.com>",
+    "João Antunes <j.goncalo.antunes@gmail.com>",
+    "Alex Potsides <alex@achingbrain.net>",
     "Diogo Silva <fsdiogo@gmail.com>",
     "Dmitriy Ryajov <dryajov@gmail.com>",
     "Drew Stone <drewstone329@gmail.com>",
     "Evan Schwartz <evan.mark.schwartz@gmail.com>",
-    "Friedel Ziegelmayer <dignifiedquire@gmail.com>",
-    "Greenkeeper <support@greenkeeper.io>",
-    "Jacob Heun <jacobheun@gmail.com>",
-    "Jacob Heun <jake@andyet.net>",
-    "João Antunes <j.goncalo.antunes@gmail.com>",
-    "Linus Unnebäck <linus@folkdatorn.se>",
-    "Pedro Teixeira <i@pgte.me>",
-    "Prashanth Chandra <coolshanth94@gmail.com>",
-    "Richard Littauer <richard.littauer@gmail.com>",
-    "Stephen Whitmore <stephen.whitmore@gmail.com>",
-    "TomCoded <tomtinkerer@gmail.com>",
-    "Vasco Santos <vasco.santos@moxy.studio>"
+    "Linus Unnebäck <linus@folkdatorn.se>"
   ]
 }

src/index.js

@@ -10,7 +10,6 @@ const createListener = require('./listener')
 const { multiaddrToNetConfig } = require('./utils')
 const { AbortError } = require('abortable-iterator')
 const { CODE_CIRCUIT, CODE_P2P } = require('./constants')
-const assert = require('assert')
 
 /**
  * @class TCP
@@ -22,7 +21,9 @@ class TCP {
    * @param {Upgrader} options.upgrader
    */
   constructor ({ upgrader }) {
-    assert(upgrader, 'An upgrader must be provided. See https://github.com/libp2p/interface-transport#upgrader.')
+    if (!upgrader) {
+      throw new Error('An upgrader must be provided. See https://github.com/libp2p/interface-transport#upgrader.')
+    }
     this._upgrader = upgrader
   }
 

src/listener.js

@@ -20,15 +20,15 @@ module.exports = ({ handler, upgrader }, options) => {
     // Avoid uncaught errors caused by unstable connections
     socket.on('error', err => log('socket error', err))
 
-    const maConn = toConnection(socket, { listeningAddr })
-    log('new inbound connection %s', maConn.remoteAddr)
-
+    let maConn
     let conn
     try {
+      maConn = toConnection(socket, { listeningAddr })
+      log('new inbound connection %s', maConn.remoteAddr)
       conn = await upgrader.upgradeInbound(maConn)
     } catch (err) {
-      log.error('inbound connection failed to upgrade', err)
-      return maConn.close()
+      log.error('inbound connection failed', err)
+      return maConn && maConn.close()
     }
 
     log('inbound connection %s upgraded', maConn.remoteAddr)