fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2025-06-22 05:01:33 +00:00
Code Issues Projects Releases Wiki Activity

Refactor out a compare-and-swap loop function.

Browse Source
This commit is contained in:
Nick Lewycky
2019-09-23 16:08:49 -07:00
parent cd1d06f5a5
commit f021d59a0b
1 changed files with 55 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
lib/singlepass-backend/src/codegen_x64.rs
View File

@ -1586,6 +1586,55 @@ impl X64FunctionCode {
m.release_temp_gpr(tmp_addr); m.release_temp_gpr(tmp_addr);
} }
/// Emits a memory operation.
fn emit_cas_loop_op<F: FnOnce(&mut Assembler, &mut Machine, GPR, GPR)>(
module_info: &ModuleInfo,
config: &CodegenConfig,
a: &mut Assembler,
m: &mut Machine,
loc: Location,
target: Location,
ret: Location,
memarg: &MemoryImmediate,
value_size: usize,
cb: F,
) {
let compare = m.reserve_temp_gpr(GPR::RAX);
let value = if loc == Location::GPR(GPR::R14) {
GPR::R13
} else {
GPR::R14
};
a.emit_push(Size::S64, Location::GPR(value));
a.emit_mov(Size::S32, loc, Location::GPR(value));
let retry = a.get_label();
a.emit_label(retry);
Self::emit_memory_op(
module_info,
config,
a,
m,
target,
memarg,
true,
value_size,
|a, m, addr| {
a.emit_mov(Size::S32, Location::Memory(addr, 0), Location::GPR(compare));
a.emit_mov(Size::S32, Location::GPR(compare), ret);
cb(a, m, compare, value);
a.emit_lock_cmpxchg(Size::S32, Location::GPR(value), Location::Memory(addr, 0));
},
);
a.emit_jmp(Condition::NotEqual, retry);
a.emit_pop(Size::S64, Location::GPR(value));
m.release_temp_gpr(compare);
}
// Checks for underflow/overflow/nan before IxxTrunc{U/S}F32. // Checks for underflow/overflow/nan before IxxTrunc{U/S}F32.
fn emit_f32_int_conv_check( fn emit_f32_int_conv_check(
a: &mut Assembler, a: &mut Assembler,
@ -5596,11 +5645,7 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
self.value_stack.push(ret); self.value_stack.push(ret);
let value = self.machine.acquire_temp_gpr().unwrap(); let value = self.machine.acquire_temp_gpr().unwrap();
a.emit_movzx( a.emit_movzx(Size::S8, loc, Size::S32, Location::GPR(value));
Size::S8,
loc,
Size::S32,
Location::GPR(value));
a.emit_neg(Size::S8, Location::GPR(value)); a.emit_neg(Size::S8, Location::GPR(value));
Self::emit_memory_op( Self::emit_memory_op(
module_info, module_info,
@ -5661,39 +5706,20 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
)[0]; )[0];
self.value_stack.push(ret); self.value_stack.push(ret);
let compare = self.machine.reserve_temp_gpr(GPR::RAX); Self::emit_cas_loop_op(
let value = if loc == Location::GPR(GPR::R14) { GPR::R13 } else { GPR::R14 };
a.emit_push(Size::S64, Location::GPR(value));
a.emit_mov(Size::S32, loc, Location::GPR(value));
let retry = a.get_label();
a.emit_label(retry);
Self::emit_memory_op(
module_info, module_info,
&self.config, &self.config,
a, a,
&mut self.machine, &mut self.machine,
loc,
target, target,
ret,
memarg, memarg,
true,
4, 4,
|a, _m, addr| { |a, _m, src, dst| {
a.emit_mov(Size::S32, Location::Memory(addr, 0), Location::GPR(compare)); a.emit_and(Size::S32, Location::GPR(src), Location::GPR(dst));
a.emit_mov(Size::S32, Location::GPR(compare), ret);
a.emit_and(Size::S32, Location::GPR(compare), Location::GPR(value));
a.emit_lock_cmpxchg(
Size::S32,
Location::GPR(value),
Location::Memory(addr, 0),
);
}, },
); );
a.emit_jmp(Condition::NotEqual, retry);
a.emit_pop(Size::S64, Location::GPR(value));
self.machine.release_temp_gpr(compare);
} }
_ => { _ => {
return Err(CodegenError { return Err(CodegenError {