fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2025-06-22 13:11:32 +00:00
Code Issues Projects Releases Wiki Activity

Expound upon Fence's empty implementation being correct.

Browse Source
This commit is contained in:
Nick Lewycky
2019-08-16 15:23:40 -07:00
parent aecce465c7
commit c8378329c1
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/llvm-backend/src/code.rs
View File

@ -4447,18 +4447,24 @@ impl FunctionCodeGenerator<CodegenError> for LLVMFunctionCodeGenerator {
state.push1(res); state.push1(res);
} }
/* /*
Operator::Wake { ref memarg: _ } => { Operator::Wake { ref memarg: _ } => {
unimplemented!(); unimplemented!();
} }
Operator::I32Wait { ref memarg: _ } => { Operator::I32Wait { ref memarg: _ } => {
unimplemented!(); unimplemented!();
} }
Operator::I64Wait { ref memarg: _ } => { Operator::I64Wait { ref memarg: _ } => {
unimplemented!(); unimplemented!();
} }
*/ */
Operator::Fence { flags: _ } => { Operator::Fence { flags: _ } => {
// fence is a no-op // Fence is a nop.
//
// Fence was added to preserve information about fences from
// source languages. If in the future Wasm extends the memory
// model, and if we hadn't recorded what fences used to be there,
// it would lead to data races that weren't present in the
// original source language.
} }
Operator::I32AtomicLoad { ref memarg } => { Operator::I32AtomicLoad { ref memarg } => {
let effective_address = resolve_memory_ptr( let effective_address = resolve_memory_ptr(