From 9cdfb48d0c4fb6b92d20f9d6757697ac52450fcd Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Mon, 7 Oct 2019 17:11:59 -0700 Subject: [PATCH] The i1 argument is actually named "is_zero_undef" which we want to be false. Fixes the test failures that showed up on mac. --- lib/llvm-backend/src/code.rs | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/lib/llvm-backend/src/code.rs b/lib/llvm-backend/src/code.rs index 8ac76fe26..27cffe059 100644 --- a/lib/llvm-backend/src/code.rs +++ b/lib/llvm-backend/src/code.rs @@ -2420,14 +2420,11 @@ impl FunctionCodeGenerator for LLVMFunctionCodeGenerator { } Operator::I32Clz => { let input = state.pop1()?; - let ensure_defined_zero = intrinsics - .i1_ty - .const_int(1 as u64, false) - .as_basic_value_enum(); + let is_zero_undef = intrinsics.i1_zero.as_basic_value_enum(); let res = builder .build_call( intrinsics.ctlz_i32, - &[input, ensure_defined_zero], + &[input, is_zero_undef], &state.var_name(), ) .try_as_basic_value() @@ -2437,14 +2434,11 @@ impl FunctionCodeGenerator for LLVMFunctionCodeGenerator { } Operator::I64Clz => { let input = state.pop1()?; - let ensure_defined_zero = intrinsics - .i1_ty - .const_int(1 as u64, false) - .as_basic_value_enum(); + let is_zero_undef = intrinsics.i1_zero.as_basic_value_enum(); let res = builder .build_call( intrinsics.ctlz_i64, - &[input, ensure_defined_zero], + &[input, is_zero_undef], &state.var_name(), ) .try_as_basic_value() @@ -2454,14 +2448,11 @@ impl FunctionCodeGenerator for LLVMFunctionCodeGenerator { } Operator::I32Ctz => { let input = state.pop1()?; - let ensure_defined_zero = intrinsics - .i1_ty - .const_int(1 as u64, false) - .as_basic_value_enum(); + let is_zero_undef = intrinsics.i1_zero.as_basic_value_enum(); let res = builder .build_call( intrinsics.cttz_i32, - &[input, ensure_defined_zero], + &[input, is_zero_undef], &state.var_name(), ) .try_as_basic_value() @@ -2471,14 +2462,11 @@ impl FunctionCodeGenerator for LLVMFunctionCodeGenerator { } Operator::I64Ctz => { let input = state.pop1()?; - let ensure_defined_zero = intrinsics - .i1_ty - .const_int(1 as u64, false) - .as_basic_value_enum(); + let is_zero_undef = intrinsics.i1_zero.as_basic_value_enum(); let res = builder .build_call( intrinsics.cttz_i64, - &[input, ensure_defined_zero], + &[input, is_zero_undef], &state.var_name(), ) .try_as_basic_value()