Address feedback, cleanup, fix memory leak in LLVM-backend

This commit is contained in:
Mark McCaskey
2020-04-28 11:36:01 -07:00
parent 50dda38dba
commit 9c5fdd6f69
8 changed files with 49 additions and 15 deletions

View File

@ -79,9 +79,6 @@ impl RunnableModule for Caller {
match res {
Err(err) => {
// probably makes the most sense to actually do a translation here to a
// a generic type defined in runtime-core
// TODO: figure out _this_ error return story
*error_out = Some(err.into());
false
}

View File

@ -48,9 +48,9 @@ fn get_signal_name(code: DWORD) -> &'static str {
EXCEPTION_BREAKPOINT => "breakpoint",
EXCEPTION_SINGLE_STEP => "single step",
EXCEPTION_ARRAY_BOUNDS_EXCEEDED => "array bounds exceeded",
EXCEPTION_INT_DIVIDE_BY_ZERO => "int div by zero",
EXCEPTION_INT_OVERFLOW => "int overflow",
EXCEPTION_PRIV_INSTRUCTION => "priv instruction",
EXCEPTION_INT_DIVIDE_BY_ZERO => "integer division by zero",
EXCEPTION_INT_OVERFLOW => "integer overflow",
EXCEPTION_PRIV_INSTRUCTION => "privileged instruction",
EXCEPTION_IN_PAGE_ERROR => "in page error",
EXCEPTION_NONCONTINUABLE_EXCEPTION => "non continuable exception",
EXCEPTION_STACK_OVERFLOW => "stack overflow",