mirror of
https://github.com/fluencelabs/wasmer
synced 2025-06-22 05:01:33 +00:00
Clean up from feedback
This commit is contained in:
@ -658,36 +658,34 @@ impl X64FunctionCode {
|
||||
sz_dst: Size,
|
||||
dst: Location,
|
||||
) {
|
||||
let tmp_src = m.acquire_temp_gpr().unwrap();
|
||||
let tmp_dst = m.acquire_temp_gpr().unwrap();
|
||||
|
||||
match src {
|
||||
Location::Imm32(_) | Location::Imm64(_) => {
|
||||
a.emit_mov(Size::S64, src, Location::GPR(tmp_src));
|
||||
src = Location::GPR(tmp_src);
|
||||
}
|
||||
Location::GPR(_) => {
|
||||
a.emit_mov(Size::S64, src, Location::GPR(tmp_src));
|
||||
src = Location::GPR(tmp_src);
|
||||
}
|
||||
Location::Memory(_, _) => {}
|
||||
_ => unreachable!(),
|
||||
}
|
||||
|
||||
match dst {
|
||||
let inner = |m: &mut Machine, a: &mut Assembler, src: Location| match dst {
|
||||
Location::Imm32(_) | Location::Imm64(_) => unreachable!(),
|
||||
Location::Memory(_, _) => {
|
||||
let tmp_dst = m.acquire_temp_gpr().unwrap();
|
||||
op(a, sz_src, src, sz_dst, Location::GPR(tmp_dst));
|
||||
a.emit_mov(Size::S64, Location::GPR(tmp_dst), dst);
|
||||
|
||||
m.release_temp_gpr(tmp_dst);
|
||||
}
|
||||
Location::GPR(_) => {
|
||||
op(a, sz_src, src, sz_dst, dst);
|
||||
}
|
||||
_ => unreachable!(),
|
||||
}
|
||||
};
|
||||
|
||||
m.release_temp_gpr(tmp_dst);
|
||||
m.release_temp_gpr(tmp_src);
|
||||
match src {
|
||||
Location::Imm32(_) | Location::Imm64(_) => {
|
||||
let tmp_src = m.acquire_temp_gpr().unwrap();
|
||||
a.emit_mov(Size::S64, src, Location::GPR(tmp_src));
|
||||
src = Location::GPR(tmp_src);
|
||||
|
||||
inner(m, a, src);
|
||||
|
||||
m.release_temp_gpr(tmp_src);
|
||||
}
|
||||
Location::GPR(_) | Location::Memory(_, _) => inner(m, a, src),
|
||||
_ => unreachable!(),
|
||||
}
|
||||
}
|
||||
|
||||
/// Moves `src` and `dst` to valid locations for generic instructions.
|
||||
@ -2964,7 +2962,6 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
|
||||
|
||||
let tmpg1 = self.machine.acquire_temp_gpr().unwrap();
|
||||
a.emit_mov(Size::S32, loc, Location::GPR(tmpg1));
|
||||
a.emit_and(Size::S32, Location::Imm32(0xFF), Location::GPR(tmpg1));
|
||||
Self::emit_relaxed_zx_sx(
|
||||
a,
|
||||
&mut self.machine,
|
||||
@ -2988,7 +2985,6 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
|
||||
|
||||
let tmpg1 = self.machine.acquire_temp_gpr().unwrap();
|
||||
a.emit_mov(Size::S32, loc, Location::GPR(tmpg1));
|
||||
a.emit_and(Size::S32, Location::Imm32(0xFFFF), Location::GPR(tmpg1));
|
||||
Self::emit_relaxed_zx_sx(
|
||||
a,
|
||||
&mut self.machine,
|
||||
@ -3036,7 +3032,6 @@ impl FunctionCodeGenerator<CodegenError> for X64FunctionCode {
|
||||
|
||||
let tmpg1 = self.machine.acquire_temp_gpr().unwrap();
|
||||
a.emit_mov(Size::S32, loc, Location::GPR(tmpg1));
|
||||
a.emit_and(Size::S32, Location::Imm32(0xFFFF), Location::GPR(tmpg1));
|
||||
Self::emit_relaxed_zx_sx(
|
||||
a,
|
||||
&mut self.machine,
|
||||
|
Reference in New Issue
Block a user