fluencelabs/wasmer
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasmer synced 2025-06-24 06:01:33 +00:00
Code Issues Projects Releases Wiki Activity

Fix this regression test to detect the bug it was looking for in release builds too.

Browse Source 
This bug triggered an assertion failure in debug, and by examining the pre-opt IR, we can check for the bug in release mode too.
This commit is contained in:
Nick Lewycky
2019-12-04 10:38:28 -08:00
parent bf04864020
commit 27fe50ce9e
1 changed files with 47 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
lib/llvm-backend-tests/tests/compile.rs
View File

@ -1,40 +1,72 @@
use wasmer_llvm_backend::{InkwellMemoryBuffer, InkwellModule, LLVMBackendConfig, LLVMCallbacks};
use wasmer_llvm_backend_tests::{get_compiler, wat2wasm}; use wasmer_llvm_backend_tests::{get_compiler, wat2wasm};
use wasmer_runtime::imports; use wasmer_runtime::{imports, CompilerConfig};
use wasmer_runtime_core::compile_with; use wasmer_runtime_core::{backend::BackendCompilerConfig, compile_with, compile_with_config};
use std::cell::RefCell;
use std::rc::Rc;
#[test] #[test]
fn crash_return_with_float_on_stack() { fn crash_return_with_float_on_stack() {
const MODULE: &str = r#" const MODULE: &str = r#"
(module (module
(type (;0;) (func)) (type (func))
(type (;1;) (func (param f64) (result f64))) (type (func (param f64) (result f64)))
(func $_start (type 0)) (func $_start (type 0))
(func $fmod (type 1) (param f64) (result f64) (func $fmod (type 1) (param f64) (result f64)
local.get 0 local.get 0
f64.const 0x0p+0 (;=0;) f64.const 0x0p+0
f64.mul f64.mul
return) return))
)
"#; "#;
let wasm_binary = wat2wasm(MODULE.as_bytes()).expect("WAST not valid or malformed"); let wasm_binary = wat2wasm(MODULE.as_bytes()).expect("WAST not valid or malformed");
let module = compile_with(&wasm_binary, &get_compiler()).unwrap(); let module = compile_with(&wasm_binary, &get_compiler()).unwrap();
module.instantiate(&imports! {}).unwrap(); module.instantiate(&imports! {}).unwrap();
} }
#[derive(Debug, Default)]
pub struct RecordPreOptIR {
preopt_ir: String,
}
impl LLVMCallbacks for RecordPreOptIR {
fn preopt_ir_callback(&mut self, module: &InkwellModule) {
self.preopt_ir = module.print_to_string().to_string();
}
fn postopt_ir_callback(&mut self, _: &InkwellModule) {}
fn obj_memory_buffer_callback(&mut self, _: &InkwellMemoryBuffer) {}
}
#[test] #[test]
fn crash_select_with_mismatched_pending() { fn crash_select_with_mismatched_pending() {
const MODULE: &str = r#" const WAT: &str = r#"
(module (module
(func (param f64) (func (param f64) (result f64)
f64.const 0x0p+0 (;=0;) f64.const 0x0p+0
local.get 0 local.get 0
f64.add f64.add
f64.const 0x0p+0 (;=0;) f64.const 0x0p+0
i32.const 0 i32.const 0
select select))
drop))
"#; "#;
let wasm_binary = wat2wasm(MODULE.as_bytes()).expect("WAST not valid or malformed"); let record_pre_opt_ir = Rc::new(RefCell::new(RecordPreOptIR::default()));
let module = compile_with(&wasm_binary, &get_compiler()).unwrap(); let compiler_config = CompilerConfig {
backend_specific_config: Some(BackendCompilerConfig(Box::new(LLVMBackendConfig {
callbacks: Some(record_pre_opt_ir.clone()),
}))),
..Default::default()
};
let wasm_binary = wat2wasm(WAT.as_bytes()).expect("WAST not valid or malformed");
let module = compile_with_config(&wasm_binary, &get_compiler(), compiler_config).unwrap();
module.instantiate(&imports! {}).unwrap(); module.instantiate(&imports! {}).unwrap();
const LLVM: &str = r#"
%s3 = fadd double 0.000000e+00, %s2
%nan = fcmp uno double %s3, 0.000000e+00
%2 = select i1 %nan, double 0x7FF8000000000000, double %s3
%s5 = select i1 false, double %2, double 0.000000e+00
br label %return
"#;
assert!(&record_pre_opt_ir.borrow().preopt_ir.contains(LLVM));
} }