Add updates from feedback

This commit is contained in:
Mark McCaskey
2020-02-20 13:06:50 -08:00
parent 65a9e04f3c
commit 0ec08b5bbd
3 changed files with 4 additions and 11 deletions

View File

@ -213,15 +213,8 @@ impl FuncResolverBuilder {
let compiled_functions = compiled_functions; let compiled_functions = compiled_functions;
let mut total_size = 0; let mut total_size = 0;
// We separate into two iterators, one iterable and one into iterable // We separate into two iterators, one iterable and one into iterable
let (code_bufs, sinks): ( let (code_bufs, sinks): (Vec<Vec<u8>>, Vec<CompileMetadata>) =
Vec<Vec<u8>>, compiled_functions.into_iter().unzip();
Vec<(
LocalFuncIndex,
Option<(CompiledFunctionData, ValueLabelsRanges, Vec<Option<i32>>)>,
RelocSink,
LocalTrapSink,
)>,
) = compiled_functions.into_iter().unzip();
for (code_buf, (_, debug_info, reloc_sink, mut local_trap_sink)) in for (code_buf, (_, debug_info, reloc_sink, mut local_trap_sink)) in
code_bufs.iter().zip(sinks.into_iter()) code_bufs.iter().zip(sinks.into_iter())
{ {

View File

@ -9,7 +9,7 @@ use std::sync::Arc;
/// ///
/// The debugger will wait for this function to be called and then take /// The debugger will wait for this function to be called and then take
/// control to read the data we prepared. /// control to read the data we prepared.
// implementation of this function is from wasmtime and is licensed under // Implementation of this function is derived from wasmtime and is licensed under
// the Apache 2.0 license. See ATTRIBUTIONS.md for full license and more // the Apache 2.0 license. See ATTRIBUTIONS.md for full license and more
// information. // information.
#[no_mangle] #[no_mangle]

View File

@ -79,7 +79,7 @@ where
self.elems self.elems
} }
/// Iterate over the values of the map in order /// Iterate over the values of the map in order.
pub fn values(&self) -> impl Iterator<Item = &V> { pub fn values(&self) -> impl Iterator<Item = &V> {
self.elems.iter() self.elems.iter()
} }