fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-06-14 21:41:23 +00:00
Code Issues Projects Releases Wiki Activity

Check for use-after-move in JS glue when --debug is enabled again

Browse Source 
Fixes #1669
This commit is contained in:
Nick Fitzgerald
2019-07-16 13:35:59 -07:00
parent 1807de74a7
commit 8fd5f4ed6a
3 changed files with 34 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/cli-support/src/js/binding.rs
View File

@ -138,15 +138,20 @@ impl<'a, 'b> Builder<'a, 'b> {
// method, so the leading parameter is the this pointer stored on
// the JS object, so synthesize that here.
match self.method {
Some(true) => {
Some(consumes_self) => {
drop(webidl_params.next());
self.args_prelude.push_str("const ptr = this.ptr;\n");
self.args_prelude.push_str("this.ptr = 0;\n");
arg_names.push("ptr".to_string());
}
Some(false) => {
drop(webidl_params.next());
arg_names.push("this.ptr".to_string());
if self.cx.config.debug {
self.args_prelude.push_str(
"if (this.ptr == 0) throw new Error('Attempt to use a moved value');\n",
);
}
if consumes_self {
self.args_prelude.push_str("const ptr = this.ptr;\n");
self.args_prelude.push_str("this.ptr = 0;\n");
arg_names.push("ptr".to_string());
} else {
arg_names.push("this.ptr".to_string());
}
}
None => {}
}