Js sys once over (#550)

* js-sys: Return `f64` instead of `Number`

* js-sys: remove trailing whitespace

* js-sys: Ensure that all imported types derive Clone and Debug

* js-sys: Imported functions should always take JS object arguments by-ref
This commit is contained in:
Nick Fitzgerald
2018-07-25 14:33:44 -07:00
committed by Alex Crichton
parent 93933f033f
commit 61fc8d2567
18 changed files with 216 additions and 184 deletions

View File

@ -50,7 +50,7 @@ fn is_safe_integer() {
#[wasm_bindgen_test]
fn new() {
let n = Number::new(JsValue::from(42));
let n = Number::new(&JsValue::from(42));
let v = JsValue::from(n);
assert!(v.is_object());
assert_eq!(Number::from(v).value_of(), 42.);
@ -58,17 +58,17 @@ fn new() {
#[wasm_bindgen_test]
fn parse_int_float() {
assert_eq!(Number::parse_int("42", 10).value_of(), 42.);
assert_eq!(Number::parse_int("42", 16).value_of(), 66.); // 0x42 == 66
assert!(Number::parse_int("invalid int", 10).value_of().is_nan());
assert_eq!(Number::parse_int("42", 10), 42.);
assert_eq!(Number::parse_int("42", 16), 66.); // 0x42 == 66
assert!(Number::parse_int("invalid int", 10).is_nan());
assert_eq!(Number::parse_float("123456.789").value_of(), 123456.789);
assert!(Number::parse_float("invalid float").value_of().is_nan());
assert_eq!(Number::parse_float("123456.789"), 123456.789);
assert!(Number::parse_float("invalid float").is_nan());
}
#[wasm_bindgen_test]
fn to_locale_string() {
let number = Number::new(1234.45.into());
let number = Number::new(&1234.45.into());
assert_eq!(number.to_locale_string("en-US"), "1,234.45");
// TODO: these tests seems to be system dependent, disable for now
// assert_eq!(wasm.to_locale_string(number, "de-DE"), "1,234.45");
@ -77,30 +77,30 @@ fn to_locale_string() {
#[wasm_bindgen_test]
fn to_precision() {
assert_eq!(Number::new(0.1.into()).to_precision(3).unwrap(), "0.100");
assert!(Number::new(10.into()).to_precision(101).is_err());
assert_eq!(Number::new(&0.1.into()).to_precision(3).unwrap(), "0.100");
assert!(Number::new(&10.into()).to_precision(101).is_err());
}
#[wasm_bindgen_test]
fn to_string() {
assert_eq!(Number::new(42.into()).to_string(10).unwrap(), "42");
assert_eq!(Number::new(233.into()).to_string(16).unwrap(), "e9");
assert!(Number::new(100.into()).to_string(100).is_err());
assert_eq!(Number::new(&42.into()).to_string(10).unwrap(), "42");
assert_eq!(Number::new(&233.into()).to_string(16).unwrap(), "e9");
assert!(Number::new(&100.into()).to_string(100).is_err());
}
#[wasm_bindgen_test]
fn value_of() {
assert_eq!(Number::new(42.into()).value_of(), 42.);
assert_eq!(Number::new(&42.into()).value_of(), 42.);
}
#[wasm_bindgen_test]
fn to_fixed() {
assert_eq!(Number::new(123.456.into()).to_fixed(2).unwrap(), "123.46");
assert!(Number::new(10.into()).to_fixed(101).is_err());
assert_eq!(Number::new(&123.456.into()).to_fixed(2).unwrap(), "123.46");
assert!(Number::new(&10.into()).to_fixed(101).is_err());
}
#[wasm_bindgen_test]
fn to_exponential() {
assert_eq!(Number::new(123456.into()).to_exponential(2).unwrap(), "1.23e+5");
assert!(Number::new(10.into()).to_exponential(101).is_err());
assert_eq!(Number::new(&123456.into()).to_exponential(2).unwrap(), "1.23e+5");
assert!(Number::new(&10.into()).to_exponential(101).is_err());
}