Js sys once over (#550)

* js-sys: Return `f64` instead of `Number`

* js-sys: remove trailing whitespace

* js-sys: Ensure that all imported types derive Clone and Debug

* js-sys: Imported functions should always take JS object arguments by-ref
This commit is contained in:
Nick Fitzgerald
2018-07-25 14:33:44 -07:00
committed by Alex Crichton
parent 93933f033f
commit 61fc8d2567
18 changed files with 216 additions and 184 deletions

View File

@ -4,20 +4,20 @@ use js_sys::*;
#[wasm_bindgen_test]
fn get_date() {
let date = Date::new("August 19, 1975 23:15:30".into());
let date = Date::new(&"August 19, 1975 23:15:30".into());
assert_eq!(date.get_date(), 19);
}
#[wasm_bindgen_test]
fn get_day() {
let date = Date::new("August 19, 1975 23:15:30".into());
let date = Date::new(&"August 19, 1975 23:15:30".into());
assert_eq!(date.get_day(), 2);
}
#[wasm_bindgen_test]
fn get_full_year() {
let date = Date::new("July 20, 1969 00:20:18".into());
let abbr = Date::new("Thu, 06 Sep 12 00:00:00".into());
let date = Date::new(&"July 20, 1969 00:20:18".into());
let abbr = Date::new(&"Thu, 06 Sep 12 00:00:00".into());
assert_eq!(date.get_full_year(), 1969);
assert_eq!(abbr.get_full_year(), 2012);
@ -25,14 +25,14 @@ fn get_full_year() {
#[wasm_bindgen_test]
fn get_hours() {
let date = Date::new("March 13, 08 04:20".into());
let date = Date::new(&"March 13, 08 04:20".into());
assert_eq!(date.get_hours(), 4);
}
#[wasm_bindgen_test]
fn get_milliseconds() {
let date = Date::new("July 20, 69 00:20:18".into());
let ms = Date::new("July 20, 69 00:20:18:123".into());
let date = Date::new(&"July 20, 69 00:20:18".into());
let ms = Date::new(&"July 20, 69 00:20:18:123".into());
assert_eq!(date.get_milliseconds(), 0);
assert_eq!(ms.get_milliseconds(), 123);
@ -40,51 +40,51 @@ fn get_milliseconds() {
#[wasm_bindgen_test]
fn get_minutes() {
let date = Date::new("March 13, 08 04:20".into());
let date = Date::new(&"March 13, 08 04:20".into());
assert_eq!(date.get_minutes(), 20);
}
#[wasm_bindgen_test]
fn get_month() {
let date = Date::new("July 20, 69 00:20:18".into());
let date = Date::new(&"July 20, 69 00:20:18".into());
assert_eq!(date.get_month(), 6);
}
#[wasm_bindgen_test]
fn get_seconds() {
let date = Date::new("July 20, 69 00:20:18".into());
let date = Date::new(&"July 20, 69 00:20:18".into());
assert_eq!(date.get_seconds(), 18);
}
#[wasm_bindgen_test]
fn get_time() {
let date = Date::new("July 20, 69 00:20:18 GMT+00:00".into());
let date = Date::new(&"July 20, 69 00:20:18 GMT+00:00".into());
assert_eq!(date.get_time(), -14254782000.0);
}
#[wasm_bindgen_test]
fn get_timezone_offset() {
let date1 = Date::new("August 19, 1975 23:15:30 GMT+07:00".into());
let date2 = Date::new("August 19, 1975 23:15:30 GMT-02:00".into());
let date1 = Date::new(&"August 19, 1975 23:15:30 GMT+07:00".into());
let date2 = Date::new(&"August 19, 1975 23:15:30 GMT-02:00".into());
assert_eq!(date1.get_timezone_offset(), date2.get_timezone_offset());
}
#[wasm_bindgen_test]
fn get_utc_date() {
let date1 = Date::new("August 19, 1975 23:15:30 GMT+11:00".into());
let date2 = Date::new("August 19, 1975 23:15:30 GMT-11:00".into());
let date1 = Date::new(&"August 19, 1975 23:15:30 GMT+11:00".into());
let date2 = Date::new(&"August 19, 1975 23:15:30 GMT-11:00".into());
assert_eq!(date1.get_utc_date(), 19);
assert_eq!(date2.get_utc_date(), 20);
}
#[wasm_bindgen_test]
fn get_utc_day() {
let date1 = Date::new("August 19, 1975 23:15:30 GMT+11:00".into());
let date2 = Date::new("August 19, 1975 23:15:30 GMT-11:00".into());
let date1 = Date::new(&"August 19, 1975 23:15:30 GMT+11:00".into());
let date2 = Date::new(&"August 19, 1975 23:15:30 GMT-11:00".into());
assert_eq!(date1.get_utc_day(), 2);
assert_eq!(date2.get_utc_day(), 3);
@ -92,16 +92,16 @@ fn get_utc_day() {
#[wasm_bindgen_test]
fn get_utc_full_year() {
let date1 = Date::new("December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new("December 31, 1975, 23:15:30 GMT-11:00".into());
let date1 = Date::new(&"December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new(&"December 31, 1975, 23:15:30 GMT-11:00".into());
assert_eq!(date1.get_utc_full_year(), 1975);
assert_eq!(date2.get_utc_full_year(), 1976);
}
#[wasm_bindgen_test]
fn get_utc_hours() {
let date1 = Date::new("December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new("December 31, 1975, 23:15:30 GMT-11:00".into());
let date1 = Date::new(&"December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new(&"December 31, 1975, 23:15:30 GMT-11:00".into());
assert_eq!(date1.get_utc_hours(), 12);
assert_eq!(date2.get_utc_hours(), 10);
@ -109,22 +109,22 @@ fn get_utc_hours() {
#[wasm_bindgen_test]
fn get_utc_milliseconds() {
let date = Date::new("2018-01-02T03:04:05.678Z".into());
let date = Date::new(&"2018-01-02T03:04:05.678Z".into());
assert_eq!(date.get_utc_milliseconds(), 678);
}
#[wasm_bindgen_test]
fn get_utc_minutes() {
let date1 = Date::new("1 January 2000 03:15:30 GMT+07:00".into());
let date2 = Date::new("1 January 2000 03:15:30 GMT+03:30".into());
let date1 = Date::new(&"1 January 2000 03:15:30 GMT+07:00".into());
let date2 = Date::new(&"1 January 2000 03:15:30 GMT+03:30".into());
assert_eq!(date1.get_utc_minutes(), 15);
assert_eq!(date2.get_utc_minutes(), 45);
}
#[wasm_bindgen_test]
fn get_utc_month() {
let date1 = Date::new("December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new("December 31, 1975, 23:15:30 GMT-11:00".into());
let date1 = Date::new(&"December 31, 1975, 23:15:30 GMT+11:00".into());
let date2 = Date::new(&"December 31, 1975, 23:15:30 GMT-11:00".into());
assert_eq!(date1.get_utc_month(), 11);
assert_eq!(date2.get_utc_month(), 0);
@ -132,14 +132,14 @@ fn get_utc_month() {
#[wasm_bindgen_test]
fn get_utc_seconds() {
let date = Date::new("July 20, 1969, 20:18:04 UTC".into());
let date = Date::new(&"July 20, 1969, 20:18:04 UTC".into());
assert_eq!(date.get_utc_seconds(), 4);
}
#[wasm_bindgen_test]
fn new() {
assert!(JsValue::from(Date::new(JsValue::undefined())).is_object());
assert!(JsValue::from(Date::new(&JsValue::undefined())).is_object());
}
#[wasm_bindgen_test]
@ -149,8 +149,8 @@ fn now() {
#[wasm_bindgen_test]
fn parse() {
let date = Date::parse("04 Dec 1995 00:12:00 GMT".into());
let zero = Date::parse("01 Jan 1970 00:00:00 GMT".into());
let date = Date::parse(&"04 Dec 1995 00:12:00 GMT".into());
let zero = Date::parse(&"01 Jan 1970 00:00:00 GMT".into());
assert_eq!(date, 818035920000.0);
assert_eq!(zero, 0.0);
@ -158,8 +158,8 @@ fn parse() {
#[wasm_bindgen_test]
fn set_date() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("August 24, 1975 23:15:30".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"August 24, 1975 23:15:30".into());
let ms = event1.set_date(24);
@ -170,8 +170,8 @@ fn set_date() {
#[wasm_bindgen_test]
fn set_full_year() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("August 19, 1976 23:15:30".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"August 19, 1976 23:15:30".into());
let ms = event1.set_full_year(1976);
@ -182,8 +182,8 @@ fn set_full_year() {
#[wasm_bindgen_test]
fn set_hours() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("August 19, 1975 20:15:30".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"August 19, 1975 20:15:30".into());
let ms = event1.set_hours(20);
@ -194,7 +194,7 @@ fn set_hours() {
#[wasm_bindgen_test]
fn set_milliseconds() {
let event = Date::new("August 19, 1975 23:15:30".into());
let event = Date::new(&"August 19, 1975 23:15:30".into());
let ms = event.set_milliseconds(456);
@ -204,8 +204,8 @@ fn set_milliseconds() {
#[wasm_bindgen_test]
fn set_minutes() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("August 19, 1975 23:45:30".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"August 19, 1975 23:45:30".into());
let ms = event1.set_minutes(45);
@ -216,8 +216,8 @@ fn set_minutes() {
#[wasm_bindgen_test]
fn set_month() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("April 19, 1975 23:15:30".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"April 19, 1975 23:15:30".into());
let ms = event1.set_month(3);
@ -228,8 +228,8 @@ fn set_month() {
#[wasm_bindgen_test]
fn set_seconds() {
let event1 = Date::new("August 19, 1975 23:15:30".into());
let event2 = Date::new("August 19, 1975 23:15:42".into());
let event1 = Date::new(&"August 19, 1975 23:15:30".into());
let event2 = Date::new(&"August 19, 1975 23:15:42".into());
let ms = event1.set_seconds(42);
@ -240,8 +240,8 @@ fn set_seconds() {
#[wasm_bindgen_test]
fn set_time() {
let event1 = Date::new("July 1, 1999".into());
let event2 = Date::new(JsValue::undefined());
let event1 = Date::new(&"July 1, 1999".into());
let event2 = Date::new(&JsValue::undefined());
let ms = event2.set_time(event1.get_time());
@ -251,8 +251,8 @@ fn set_time() {
#[wasm_bindgen_test]
fn set_utc_date() {
let event1 = Date::new("August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("August 19, 1975 02:15:30 GMT".into());
let event1 = Date::new(&"August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"August 19, 1975 02:15:30 GMT".into());
let ms = event1.set_utc_date(19);
@ -263,8 +263,8 @@ fn set_utc_date() {
#[wasm_bindgen_test]
fn set_utc_full_year() {
let event1 = Date::new("December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("January 01, 1975 02:15:30 GMT".into());
let event1 = Date::new(&"December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"January 01, 1975 02:15:30 GMT".into());
let ms = event1.set_utc_full_year(1975);
@ -275,8 +275,8 @@ fn set_utc_full_year() {
#[wasm_bindgen_test]
fn set_utc_hours() {
let event1 = Date::new("August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("August 20, 1975 23:15:30 GMT".into());
let event1 = Date::new(&"August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"August 20, 1975 23:15:30 GMT".into());
let ms = event1.set_utc_hours(23);
@ -287,8 +287,8 @@ fn set_utc_hours() {
#[wasm_bindgen_test]
fn set_utc_milliseconds() {
let event1 = Date::new("August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("August 20, 1975 02:15:30.420Z GMT".into());
let event1 = Date::new(&"August 19, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"August 20, 1975 02:15:30.420Z GMT".into());
let ms = event1.set_utc_milliseconds(420);
@ -299,8 +299,8 @@ fn set_utc_milliseconds() {
#[wasm_bindgen_test]
fn set_utc_minutes() {
let event1 = Date::new("December 31, 1975, 23:15:30 GMT-3:00".into());
let event2 = Date::new("January 01, 1976 02:25:30 GMT".into());
let event1 = Date::new(&"December 31, 1975, 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"January 01, 1976 02:25:30 GMT".into());
let ms = event1.set_utc_minutes(25);
@ -311,8 +311,8 @@ fn set_utc_minutes() {
#[wasm_bindgen_test]
fn set_utc_month() {
let event1 = Date::new("December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("December 01, 1976 02:15:30 GMT".into());
let event1 = Date::new(&"December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"December 01, 1976 02:15:30 GMT".into());
let ms = event1.set_utc_month(11);
@ -323,8 +323,8 @@ fn set_utc_month() {
#[wasm_bindgen_test]
fn set_utc_seconds() {
let event1 = Date::new("December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new("January 01, 1976 02:15:39 GMT".into());
let event1 = Date::new(&"December 31, 1975 23:15:30 GMT-3:00".into());
let event2 = Date::new(&"January 01, 1976 02:15:39 GMT".into());
let ms = event1.set_utc_seconds(39);
@ -335,63 +335,63 @@ fn set_utc_seconds() {
#[wasm_bindgen_test]
fn to_date_string() {
let date = Date::new("05 October 2011 14:48 UTC".into());
let date = Date::new(&"05 October 2011 14:48 UTC".into());
assert_eq!(JsValue::from(date.to_date_string()), "Wed Oct 05 2011");
}
#[wasm_bindgen_test]
fn to_iso_string() {
let date = Date::new("05 October 2011 14:48 UTC".into());
let date = Date::new(&"05 October 2011 14:48 UTC".into());
assert_eq!(JsValue::from(date.to_iso_string()), "2011-10-05T14:48:00.000Z");
}
#[wasm_bindgen_test]
fn to_json() {
let date = Date::new("August 19, 1975 23:15:30 UTC".into());
let date = Date::new(&"August 19, 1975 23:15:30 UTC".into());
assert_eq!(JsValue::from(date.to_json()), "1975-08-19T23:15:30.000Z");
}
#[wasm_bindgen_test]
fn to_locale_date_string() {
let date = Date::new("August 19, 1975 23:15:30 UTC".into());
let s = date.to_locale_date_string("de-DE".into(), JsValue::undefined());
let date = Date::new(&"August 19, 1975 23:15:30 UTC".into());
let s = date.to_locale_date_string(&"de-DE".into(), &JsValue::undefined());
assert!(s.length() > 0);
}
#[wasm_bindgen_test]
fn to_locale_string() {
let date = Date::new("August 19, 1975 23:15:30 UTC".into());
let s = date.to_locale_string("de-DE".into(), JsValue::undefined());
let date = Date::new(&"August 19, 1975 23:15:30 UTC".into());
let s = date.to_locale_string(&"de-DE".into(), &JsValue::undefined());
assert!(s.length() > 0);
}
#[wasm_bindgen_test]
fn to_locale_time_string() {
let date = Date::new("August 19, 1975 23:15:30".into());
let date = Date::new(&"August 19, 1975 23:15:30".into());
assert_eq!(
JsValue::from(date.to_locale_time_string("en-US".into())),
JsValue::from(date.to_locale_time_string(&"en-US".into())),
"11:15:30 PM",
);
}
#[wasm_bindgen_test]
fn to_string() {
let date = Date::new("August 19, 1975 23:15:30".into());
let date = Date::new(&"August 19, 1975 23:15:30".into());
let s = JsValue::from(date.to_string()).as_string().unwrap();
assert_eq!(&s[0..15], "Tue Aug 19 1975");
}
#[wasm_bindgen_test]
fn to_time_string() {
let date = Date::new("August 19, 1975 23:15:30".into());
let date = Date::new(&"August 19, 1975 23:15:30".into());
let s = JsValue::from(date.to_time_string()).as_string().unwrap();
assert_eq!(&s[0..8], "23:15:30");
}
#[wasm_bindgen_test]
fn to_utc_string() {
let date = Date::new("14 Jun 2017 00:00:00 PDT".into());
let date = Date::new(&"14 Jun 2017 00:00:00 PDT".into());
let s = JsValue::from(date.to_utc_string()).as_string().unwrap();
assert_eq!(s, "Wed, 14 Jun 2017 07:00:00 GMT");
}
@ -403,6 +403,6 @@ fn utc() {
#[wasm_bindgen_test]
fn value_of() {
let date = Date::new(Date::utc(2018f64, 6f64).into());
let date = Date::new(&Date::utc(2018f64, 6f64).into());
assert_eq!(date.value_of(), 1530403200000.0);
}