fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-06-14 21:41:23 +00:00
Code Issues Projects Releases Wiki Activity

Fix an off-by-one in anyref stack manipulation

Browse Source 
With more than two anyref stack arguments we were accidentally storing
the anyref values one higher in the stack than intended, so fix this
off-by-one by switching up some addition logic.
This commit is contained in:
Alex Crichton
2019-08-01 11:58:23 -07:00
parent 6e3e9d2dae
commit 5aee2f9c6a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/anyref-xform/src/lib.rs
View File

@ -510,14 +510,14 @@ impl Transform<'_> {
// Store an anyref at an offset from our function's stack // Store an anyref at an offset from our function's stack
// pointer frame. // pointer frame.
let get_fp = builder.local_get(fp); let get_fp = builder.local_get(fp);
next_stack_offset += 1; let (index, idx_local) = if next_stack_offset == 0 {
let (index, idx_local) = if next_stack_offset == 1 {
(get_fp, fp) (get_fp, fp)
} else { } else {
let rhs = builder.i32_const(next_stack_offset); let rhs = builder.i32_const(next_stack_offset);
let add = builder.binop(BinaryOp::I32Add, get_fp, rhs); let add = builder.binop(BinaryOp::I32Add, get_fp, rhs);
(builder.local_tee(scratch_i32, add), scratch_i32) (builder.local_tee(scratch_i32, add), scratch_i32)
}; };
next_stack_offset += 1;
let store = builder.table_set(self.table, index, local); let store = builder.table_set(self.table, index, local);
let get = builder.local_get(idx_local); let get = builder.local_get(idx_local);
builder.with_side_effects(vec![store], get, Vec::new()) builder.with_side_effects(vec![store], get, Vec::new())