Clean up Some Clippy Warnings (#478)

* clippy: it is more idiomatic to loop over references to containers instead of using explicit iteration methods

* clippy: useless use of `format!`

* clippy: if/else is an expression

* clippy: use of  followed by a function call

* clippy: large size difference between variants

* clippy: redundant closure

* Revert "clippy: large size difference between variants"

This reverts commit 7e2e660dd47c9718126d1c45ae1caa632e287a14.

* Revert "clippy: it is more idiomatic to loop over references to containers instead of using explicit iteration methods"

This reverts commit 5c4804f790fc6a33a7a0f0d2aacdc4b98529b978.
This commit is contained in:
Stephan Wolski
2018-07-15 12:43:55 -04:00
committed by Alex Crichton
parent babc2134e1
commit 4cc069bd01
4 changed files with 9 additions and 8 deletions

View File

@ -125,7 +125,7 @@ impl FirstPass for webidl::ast::NonPartialMixin {
let entry = record
.mixins
.entry(self.name.clone())
.or_insert(Default::default());
.or_insert_with(Default::default);
if mem::replace(&mut entry.non_partial, Some(self)).is_some() {
warn!(
"Encounterd multiple declarations of {}, using last encountered",
@ -142,7 +142,7 @@ impl FirstPass for webidl::ast::PartialMixin {
let entry = record
.mixins
.entry(self.name.clone())
.or_insert(Default::default());
.or_insert_with(Default::default);
entry.partials.push(self);
Ok(())