fluencelabs/wasm-bindgen
1
0
Fork 0
mirror of https://github.com/fluencelabs/wasm-bindgen synced 2025-06-14 13:31:22 +00:00
Code Issues Projects Releases Wiki Activity

Fix idl_type swap

Browse Source
This commit is contained in:
Chinedu Francis Nwafili
2019-01-22 21:35:22 -05:00
parent 48b64f4cfe
commit 048a22bc77
3 changed files with 28 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crates/web-sys/tests/wasm/element.js
View File

@ -152,6 +152,9 @@ export function new_title() {
}
export function new_webgl_rendering_context() {
const foo = document.createElement('canvas');
console.log('Does get context work? ' + foo.getContext('webgl'));
const canvas = document.createElement('canvas');
return canvas.getContext('webgl');
}

4
crates/webidl-tests/lib.rs
View File

@ -1,3 +1 @@
// intentionally left blank
// QUESTION FOR REVIEWER: WHY? (I'll include this context in the comment)
// Intentionally left blank in order for Cargo to work

32
crates/webidl/src/util.rs
View File

@ -12,6 +12,8 @@ use weedle::literal::{ConstValue, FloatLit, IntegerLit};
use first_pass::{FirstPassRecord, OperationData, OperationId, Signature};
use idl_type::{IdlType, ToIdlType};
// TODO: Remove.. just using this to see what idl types I need to change..
use std::io::Write;
/// For variadic operations an overload with a `js_sys::Array` argument is generated alongside with
/// `operation_name_0`, `operation_name_1`, `operation_name_2`, ..., `operation_name_n` overloads
@ -434,7 +436,7 @@ impl<'src> FirstPassRecord<'src> {
signatures.push((signature, idl_args.clone()));
}
let idl_type = arg.ty.to_idl_type(self);
let mut idl_type = arg.ty.to_idl_type(self);
let idl_type = maybe_adjust(idl_type, id);
idl_args.push(idl_type);
}
@ -719,16 +721,30 @@ pub fn public() -> syn::Visibility {
///
/// Here we implement a whitelist for those cases. This whitelist is currently
/// maintained by hand.
fn maybe_adjust<'a> (idl_type: IdlType<'a>, id: &'a OperationId) -> IdlType<'a> {
fn maybe_adjust<'a> (mut idl_type: IdlType<'a>, id: &'a OperationId) -> IdlType<'a> {
// let mut file = ::std::fs::OpenOptions::new().append(true).create(true).open("foo").unwrap();
match id {
// TODO: `match op` and return an adjusted idl_type if necessary
OperationId::Operation(Some(op)) => {
match *op {
// "vertexAttrib1fv" => {
// IdlType::Float32Array { immutable: true}
// }
_ => idl_type
}
"vertexAttrib1fv" => {
// TODO: Remove.. just using this to see what idl types I need to change..
// file.write(
// format!("{:#?}", idl_type).as_bytes()
// );
// file.write(r#"
// "#.as_bytes());
if let IdlType::Union(ref mut union) = idl_type {
if let IdlType::Float32Array { ref mut immutable } = union[0] {
*immutable = true;
}
}
}
_ => {}
};
return idl_type
}
_ => idl_type
}