2018-07-09 16:35:25 -07:00
|
|
|
# Supporting More Web APIs in `web-sys`
|
|
|
|
|
|
|
|
1. <input type="checkbox"/> Ensure that the `.webidl` file describing the
|
|
|
|
interface exists somewhere within the `crates/web-sys/webidls/enabled`
|
|
|
|
directory.
|
|
|
|
|
|
|
|
First, check to see whether we have the WebIDL definition file for
|
|
|
|
your API:
|
|
|
|
|
|
|
|
```sh
|
|
|
|
grep -rn MyWebApi crates/web-sys/webidls
|
|
|
|
```
|
|
|
|
|
|
|
|
* If your interface is defined in a `.webidl` file that is inside the
|
|
|
|
`crates/web-sys/webidls/enabled` directory, skip to step (3).
|
|
|
|
|
|
|
|
* If your interface isn't defined in any file yet, find the WebIDL definition
|
|
|
|
in the relevant standard and add it as a new `.webidl` file in
|
|
|
|
`crates/web-sys/webidls/enabled`. Make sure that it is a standard Web API!
|
|
|
|
We don't want to add non-standard APIs to this crate.
|
|
|
|
|
|
|
|
* If your interface is defined in a `.webidl` file within the
|
|
|
|
`crates/web-sys/webidls/available` directory, you need to move it into
|
|
|
|
`crates/web-sys/webidls/enabled`:
|
|
|
|
|
|
|
|
```sh
|
|
|
|
cd crates/web-sys
|
|
|
|
git mv webidls/available/MyWebApi.webidl webidls/enabled/MyWebApi.webidl
|
|
|
|
```
|
|
|
|
|
|
|
|
2. <input type="checkbox"/> Verify that the `web-sys` crate still builds and
|
|
|
|
that its tests still pass with the new `.webidl` file enabled:
|
|
|
|
|
|
|
|
```sh
|
|
|
|
cd crates/web-sys
|
|
|
|
cargo build
|
|
|
|
cargo test
|
|
|
|
```
|
|
|
|
|
|
|
|
3. <input type="checkbox"/> Verify that bindings are being generated for your new
|
|
|
|
API by generating the documentation and searching for the new API in it:
|
|
|
|
|
|
|
|
```sh
|
|
|
|
cd crates/web-sys
|
|
|
|
cargo doc --open
|
|
|
|
# search for the new API in the opened docs
|
|
|
|
```
|
|
|
|
|
|
|
|
* <input type="checkbox"/> If the new API is **not** showing up in the docs,
|
2018-07-27 08:48:10 -07:00
|
|
|
rebuild the `web-sys` crate [with logging enabled](web-sys/logging.html)
|
2018-07-09 16:35:25 -07:00
|
|
|
and look for warning messages that mention your new API. Figure out why
|
|
|
|
bindings weren't generated and then add support to `wasm_bindgen_webidl` for
|
|
|
|
whatever is needed to generate your API's bindings.
|
2018-07-27 08:48:10 -07:00
|
|
|
|
|
|
|
> You might find it helpful to view the generated rust bindings, to see if
|
|
|
|
they are what you would expect. The file will be located at
|
2018-07-20 16:41:31 +01:00
|
|
|
`target/wasm32-unknown-unknown/debug/build/web-sys-xxx/out/bindings.rs`,
|
|
|
|
where `xxx` is a combinations of numbers and letters that represents your
|
|
|
|
build. This file is pretty unintelligable until you run `rustfmt` on it, like
|
|
|
|
`rustfmt target/wasm32-unknown-unknown/debug/build/web-sys-xxx/out/bindings.rs`.
|
2018-07-09 16:35:25 -07:00
|
|
|
|
|
|
|
4. <input type="checkbox"/> Add a simple test for your new API to
|
|
|
|
`crates/web-sys/tests/all/`. See the [`web-sys` testing
|
2018-07-27 08:48:10 -07:00
|
|
|
documentation](web-sys/testing.html) for details.
|
2018-07-09 16:35:25 -07:00
|
|
|
|
|
|
|
5. <input type="checkbox"/> Send a pull request! 😊
|