mirror of
https://github.com/fluencelabs/tendermint
synced 2025-05-02 01:52:16 +00:00
* limit number of /subscribe clients and queries per client Add the following config variables (under [rpc] section): * max_subscription_clients * max_subscriptions_per_client * timeout_broadcast_tx_commit Fixes #2826 new HTTPClient interface for subscriptions finalize HTTPClient events interface remove EventSubscriber fix data race ``` WARNING: DATA RACE Read at 0x00c000a36060 by goroutine 129: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe.func1() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:168 +0x1f0 Previous write at 0x00c000a36060 by goroutine 132: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:191 +0x4e0 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 129 (running) created at: github.com/tendermint/tendermint/rpc/client.(*Local).Subscribe() /go/src/github.com/tendermint/tendermint/rpc/client/localclient.go:164 +0x4b7 github.com/tendermint/tendermint/rpc/client.WaitForOneEvent() /go/src/github.com/tendermint/tendermint/rpc/client/helpers.go:64 +0x178 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync.func1() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:139 +0x298 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Goroutine 132 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 github.com/tendermint/tendermint/rpc/client_test.TestTxEventsSentWithBroadcastTxSync() /go/src/github.com/tendermint/tendermint/rpc/client/event_test.go:119 +0x186 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 ================== ``` lite client works (tested manually) godoc comments httpclient: do not close the out channel use TimeoutBroadcastTxCommit no timeout for unsubscribe but 1s Local (5s HTTP) timeout for resubscribe format code change Subscribe#out cap to 1 and replace config vars with RPCConfig TimeoutBroadcastTxCommit can't be greater than rpcserver.WriteTimeout rpc: Context as first parameter to all functions reformat code fixes after my own review fixes after Ethan's review add test stubs fix config.toml * fixes after manual testing - rpc: do not recommend to use BroadcastTxCommit because it's slow and wastes Tendermint resources (pubsub) - rpc: better error in Subscribe and BroadcastTxCommit - HTTPClient: do not resubscribe if err = ErrAlreadySubscribed * fixes after Ismail's review * Update rpc/grpc/grpc_test.go Co-Authored-By: melekes <anton.kalyaev@gmail.com>
138 lines
4.3 KiB
Go
138 lines
4.3 KiB
Go
package mock
|
|
|
|
/*
|
|
package mock returns a Client implementation that
|
|
accepts various (mock) implementations of the various methods.
|
|
|
|
This implementation is useful for using in tests, when you don't
|
|
need a real server, but want a high-level of control about
|
|
the server response you want to mock (eg. error handling),
|
|
or if you just want to record the calls to verify in your tests.
|
|
|
|
For real clients, you probably want the "http" package. If you
|
|
want to directly call a tendermint node in process, you can use the
|
|
"local" package.
|
|
*/
|
|
|
|
import (
|
|
"reflect"
|
|
|
|
cmn "github.com/tendermint/tendermint/libs/common"
|
|
"github.com/tendermint/tendermint/rpc/client"
|
|
"github.com/tendermint/tendermint/rpc/core"
|
|
ctypes "github.com/tendermint/tendermint/rpc/core/types"
|
|
rpctypes "github.com/tendermint/tendermint/rpc/lib/types"
|
|
"github.com/tendermint/tendermint/types"
|
|
)
|
|
|
|
// Client wraps arbitrary implementations of the various interfaces.
|
|
//
|
|
// We provide a few choices to mock out each one in this package.
|
|
// Nothing hidden here, so no New function, just construct it from
|
|
// some parts, and swap them out them during the tests.
|
|
type Client struct {
|
|
client.ABCIClient
|
|
client.SignClient
|
|
client.HistoryClient
|
|
client.StatusClient
|
|
client.EventsClient
|
|
cmn.Service
|
|
}
|
|
|
|
var _ client.Client = Client{}
|
|
|
|
// Call is used by recorders to save a call and response.
|
|
// It can also be used to configure mock responses.
|
|
//
|
|
type Call struct {
|
|
Name string
|
|
Args interface{}
|
|
Response interface{}
|
|
Error error
|
|
}
|
|
|
|
// GetResponse will generate the apporiate response for us, when
|
|
// using the Call struct to configure a Mock handler.
|
|
//
|
|
// When configuring a response, if only one of Response or Error is
|
|
// set then that will always be returned. If both are set, then
|
|
// we return Response if the Args match the set args, Error otherwise.
|
|
func (c Call) GetResponse(args interface{}) (interface{}, error) {
|
|
// handle the case with no response
|
|
if c.Response == nil {
|
|
if c.Error == nil {
|
|
panic("Misconfigured call, you must set either Response or Error")
|
|
}
|
|
return nil, c.Error
|
|
}
|
|
// response without error
|
|
if c.Error == nil {
|
|
return c.Response, nil
|
|
}
|
|
// have both, we must check args....
|
|
if reflect.DeepEqual(args, c.Args) {
|
|
return c.Response, nil
|
|
}
|
|
return nil, c.Error
|
|
}
|
|
|
|
func (c Client) Status() (*ctypes.ResultStatus, error) {
|
|
return core.Status(&rpctypes.Context{})
|
|
}
|
|
|
|
func (c Client) ABCIInfo() (*ctypes.ResultABCIInfo, error) {
|
|
return core.ABCIInfo(&rpctypes.Context{})
|
|
}
|
|
|
|
func (c Client) ABCIQuery(path string, data cmn.HexBytes) (*ctypes.ResultABCIQuery, error) {
|
|
return c.ABCIQueryWithOptions(path, data, client.DefaultABCIQueryOptions)
|
|
}
|
|
|
|
func (c Client) ABCIQueryWithOptions(path string, data cmn.HexBytes, opts client.ABCIQueryOptions) (*ctypes.ResultABCIQuery, error) {
|
|
return core.ABCIQuery(&rpctypes.Context{}, path, data, opts.Height, opts.Prove)
|
|
}
|
|
|
|
func (c Client) BroadcastTxCommit(tx types.Tx) (*ctypes.ResultBroadcastTxCommit, error) {
|
|
return core.BroadcastTxCommit(&rpctypes.Context{}, tx)
|
|
}
|
|
|
|
func (c Client) BroadcastTxAsync(tx types.Tx) (*ctypes.ResultBroadcastTx, error) {
|
|
return core.BroadcastTxAsync(&rpctypes.Context{}, tx)
|
|
}
|
|
|
|
func (c Client) BroadcastTxSync(tx types.Tx) (*ctypes.ResultBroadcastTx, error) {
|
|
return core.BroadcastTxSync(&rpctypes.Context{}, tx)
|
|
}
|
|
|
|
func (c Client) NetInfo() (*ctypes.ResultNetInfo, error) {
|
|
return core.NetInfo(&rpctypes.Context{})
|
|
}
|
|
|
|
func (c Client) DialSeeds(seeds []string) (*ctypes.ResultDialSeeds, error) {
|
|
return core.UnsafeDialSeeds(&rpctypes.Context{}, seeds)
|
|
}
|
|
|
|
func (c Client) DialPeers(peers []string, persistent bool) (*ctypes.ResultDialPeers, error) {
|
|
return core.UnsafeDialPeers(&rpctypes.Context{}, peers, persistent)
|
|
}
|
|
|
|
func (c Client) BlockchainInfo(minHeight, maxHeight int64) (*ctypes.ResultBlockchainInfo, error) {
|
|
return core.BlockchainInfo(&rpctypes.Context{}, minHeight, maxHeight)
|
|
}
|
|
|
|
func (c Client) Genesis() (*ctypes.ResultGenesis, error) {
|
|
return core.Genesis(&rpctypes.Context{})
|
|
}
|
|
|
|
func (c Client) Block(height *int64) (*ctypes.ResultBlock, error) {
|
|
return core.Block(&rpctypes.Context{}, height)
|
|
}
|
|
|
|
func (c Client) Commit(height *int64) (*ctypes.ResultCommit, error) {
|
|
return core.Commit(&rpctypes.Context{}, height)
|
|
}
|
|
|
|
func (c Client) Validators(height *int64) (*ctypes.ResultValidators, error) {
|
|
return core.Validators(&rpctypes.Context{}, height)
|
|
}
|