Marko 513a32a6e3 gocritic (1/2) (#3836) ...

Add gocritic as a linter

    The linting is not complete, but should i complete in this PR or in a following.

    23 files have been touched so it may be better to do in a following PR


Commits:

* Add gocritic to linting

- Added gocritic to linting

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

* gocritic

* pr comments

* remove switch in cmdBatch

2019-08-01 10:28:32 -07:00

..

proto3

deps: update gogo/protobuf from 1.1.1 to 1.2.1 and golang/protobuf from 1.1.0 to 1.3.0 (#3357)

2019-03-04 12:17:38 +04:00

time

types/time: add note about stripping monotonic part

2018-09-06 17:58:52 -04:00

block_meta.go

Updated Marshal and unmarshal methods to make compatible with protobuf (#2918)

2018-11-27 08:07:20 -05:00

block_test.go

types: CommitVotes struct as last step towards #1648 (#3298)

2019-05-05 18:01:35 +02:00

block.go

types: move MakeVote / MakeBlock functions (#3819)

2019-08-01 10:28:32 -07:00

canonical.go

fix order of BlockID and Timestamp in Vote and Proposal (#3078)

2019-01-13 17:56:36 -05:00

codec.go

Renamed wire.go to codec.go (#3827)

2019-08-01 10:28:32 -07:00

encoding_helper.go

crypto/merkle: Remove byter in favor of plain byte slices (#2595)

2018-10-10 12:46:09 -04:00

errors.go

state: add more tests for block validation (#3674)

2019-06-21 17:29:29 -04:00

event_bus_test.go

abci: Refactor tagging events using list of lists (#3643)

2019-06-12 14:03:45 +02:00

event_bus.go

types: do not ignore errors returned by PublishWithEvents (#3722)

2019-06-12 15:25:47 +02:00

events_test.go

crypto: Refactor to move files out of the top level directory

2018-07-18 08:38:44 -07:00

events.go

remove RoundState from EventDataRoundState (#3354)

2019-03-04 12:18:32 +04:00

evidence_test.go

[WIP] Fill in consensus core details in ADR 030 (#2696)

2019-01-13 14:47:00 -05:00

evidence.go

Bucky/fix evidence halt (#34)

2019-01-17 21:46:40 -05:00

genesis_test.go

add staticcheck linting (#3828)

2019-08-01 10:28:32 -07:00

genesis.go

gocritic (1/2) (#3836)

2019-08-01 10:28:32 -07:00

keys.go

Revert "delete everything" (includes everything non-go-crypto)

2018-06-20 17:35:30 -07:00

params_test.go

remove TimeIotaMs from ABCI consensus params (#3403)

2019-03-11 22:21:17 +04:00

params.go

remove TimeIotaMs from ABCI consensus params (#3403)

2019-03-11 22:21:17 +04:00

part_set_test.go

small fixes to spec & http_server & Vagrantfile (#2859)

2018-11-16 12:58:30 -05:00

part_set.go

libs/common: remove deprecated PanicXXX functions (#3595)

2019-04-26 14:23:43 +04:00

priv_validator.go

Add remote signer test harness (KMS) (#3149)

2019-02-07 10:32:32 +04:00

proposal_test.go

Add tests for ValidateBasic methods (#2754)

2018-11-09 15:59:04 +01:00

proposal.go

fix order of BlockID and Timestamp in Vote and Proposal (#3078)

2019-01-13 17:56:36 -05:00

proto3_test.go

libs: Remove usage of custom Fmt, in favor of fmt.Sprintf (#2199)

2018-08-10 09:25:57 +04:00

protobuf_test.go

Changes to files that had linting issue (#3731)

2019-06-21 09:58:32 +04:00

protobuf.go

replace PB2TM.ConsensusParams with a call to params#Update (#3448)

2019-03-21 11:05:39 +01:00

results_test.go

update spec for Merkle RFC 6962 (#3175)

2019-01-21 10:02:57 -05:00

results.go

update spec for Merkle RFC 6962 (#3175)

2019-01-21 10:02:57 -05:00

signable.go

2871 remove proposalHeartbeat infrastructure (#2874)

2018-11-28 08:52:34 -05:00

signed_msg_type.go

Set accum of freshly added validator -(total voting power) (#2785)

2018-11-28 13:12:17 -05:00

test_util.go

types: move MakeVote / MakeBlock functions (#3819)

2019-08-01 10:28:32 -07:00

tx_test.go

Simple merkle rfc compatibility (#2713)

2019-01-13 18:02:38 -05:00

tx.go

alias amino imports (#3219)

2019-01-28 16:13:17 +04:00

validation.go

validate reactor messages (#2711)

2018-11-01 02:07:18 -04:00

validator_set_test.go

types: remove check for priority order of existing validators (#3407)

2019-03-11 18:17:25 +04:00

validator_set.go

gocritic (1/2) (#3836)

2019-08-01 10:28:32 -07:00

validator.go

libs/common: remove deprecated PanicXXX functions (#3595)

2019-04-26 14:23:43 +04:00

vote_set_test.go

libs: minor cleanup (#3794)

2019-07-14 18:02:48 +04:00

vote_set.go

types: CommitVotes struct as last step towards #1648 (#3298)

2019-05-05 18:01:35 +02:00

vote_test.go

libs: minor cleanup (#3794)

2019-07-14 18:02:48 +04:00

vote.go

libs/common: remove deprecated PanicXXX functions (#3595)

2019-04-26 14:23:43 +04:00