Phil Salant d1d517a9b7 linters: enable scopelint (#3963) ...

* Pin range scope vars

* Don't disable scopelint

This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=scopelint

Contributes to #3262

2019-09-11 09:15:18 +04:00

..

proto3

deps: update gogo/protobuf from 1.1.1 to 1.2.1 and golang/protobuf from 1.1.0 to 1.3.0 (#3357)

2019-03-04 12:17:38 +04:00

time

types/time: add note about stripping monotonic part

2018-09-06 17:58:52 -04:00

block_meta.go

Updated Marshal and unmarshal methods to make compatible with protobuf (#2918)

2018-11-27 08:07:20 -05:00

block_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

block.go

replace errors.go with github.com/pkg/errors (1/2) (#3888)

2019-08-08 14:31:13 +04:00

canonical.go

fix order of BlockID and Timestamp in Vote and Proposal (#3078)

2019-01-13 17:56:36 -05:00

codec.go

Renamed wire.go to codec.go (#3827)

2019-07-23 15:35:36 +02:00

encoding_helper.go

crypto/merkle: Remove byter in favor of plain byte slices (#2595)

2018-10-10 12:46:09 -04:00

errors.go

state: add more tests for block validation (#3674)

2019-06-21 17:29:29 -04:00

event_bus_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

event_bus.go

types: do not ignore errors returned by PublishWithEvents (#3722)

2019-06-12 15:25:47 +02:00

events_test.go

crypto: Refactor to move files out of the top level directory

2018-07-18 08:38:44 -07:00

events.go

remove RoundState from EventDataRoundState (#3354)

2019-03-04 12:18:32 +04:00

evidence_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

evidence.go

Bucky/fix evidence halt (#34)

2019-01-17 21:46:40 -05:00

genesis_test.go

add staticcheck linting (#3828)

2019-07-25 09:35:30 +04:00

genesis.go

replace errors.go with github.com/pkg/errors (1/2) (#3888)

2019-08-08 14:31:13 +04:00

keys.go

Revert "delete everything" (includes everything non-go-crypto)

2018-06-20 17:35:30 -07:00

params_test.go

remove TimeIotaMs from ABCI consensus params (#3403)

2019-03-11 22:21:17 +04:00

params.go

replace errors.go with github.com/pkg/errors (2/2) (#3890)

2019-08-11 21:03:40 +04:00

part_set_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

part_set.go

libs/common: remove deprecated PanicXXX functions (#3595)

2019-04-26 14:23:43 +04:00

priv_validator.go

privval: refactor Remote signers (#3370)

2019-08-05 19:09:10 +04:00

proposal_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

proposal.go

fix order of BlockID and Timestamp in Vote and Proposal (#3078)

2019-01-13 17:56:36 -05:00

proto3_test.go

libs: Remove usage of custom Fmt, in favor of fmt.Sprintf (#2199)

2018-08-10 09:25:57 +04:00

protobuf_test.go

Changes to files that had linting issue (#3731)

2019-06-21 09:58:32 +04:00

protobuf.go

replace PB2TM.ConsensusParams with a call to params#Update (#3448)

2019-03-21 11:05:39 +01:00

results_test.go

update spec for Merkle RFC 6962 (#3175)

2019-01-21 10:02:57 -05:00

results.go

remove mentions of go-wire (#3904)

2019-08-16 17:45:19 +04:00

signable.go

2871 remove proposalHeartbeat infrastructure (#2874)

2018-11-28 08:52:34 -05:00

signed_msg_type.go

Set accum of freshly added validator -(total voting power) (#2785)

2018-11-28 13:12:17 -05:00

test_util.go

types: move MakeVote / MakeBlock functions (#3819)

2019-07-25 12:13:19 +04:00

tx_test.go

Simple merkle rfc compatibility (#2713)

2019-01-13 18:02:38 -05:00

tx.go

fix linter errors thrown by unconvert, goconst, and nakedret (#3960)

2019-09-10 11:31:44 +04:00

validation.go

validate reactor messages (#2711)

2018-11-01 02:07:18 -04:00

validator_set_test.go

types: remove check for priority order of existing validators (#3407)

2019-03-11 18:17:25 +04:00

validator_set.go

replace errors.go with github.com/pkg/errors (2/2) (#3890)

2019-08-11 21:03:40 +04:00

validator.go

gocritic (2/2) (#3864)

2019-08-02 10:53:52 +04:00

vote_set_test.go

libs: minor cleanup (#3794)

2019-07-14 18:02:48 +04:00

vote_set.go

enable unconvert, goconst and nakedret linters (#3973)

2019-09-10 21:58:17 +04:00

vote_test.go

linters: enable scopelint (#3963)

2019-09-11 09:15:18 +04:00

vote.go

fix linter errors thrown by unconvert, goconst, and nakedret (#3960)

2019-09-10 11:31:44 +04:00