mirror of
https://github.com/fluencelabs/tendermint
synced 2025-06-01 07:31:20 +00:00
comment out failing consensus tests for now rewrite rpc httpclient to use new pubsub package import pubsub as tmpubsub, query as tmquery make event IDs constants EventKey -> EventTypeKey rename EventsPubsub to PubSub mempool does not use pubsub rename eventsSub to pubsub new subscribe API fix channel size issues and consensus tests bugs refactor rpc client add missing discardFromChan method add mutex rename pubsub to eventBus remove IsRunning from WSRPCConnection interface (not needed) add a comment in broadcastNewRoundStepsAndVotes rename registerEventCallbacks to broadcastNewRoundStepsAndVotes See https://dave.cheney.net/2014/03/19/channel-axioms stop eventBuses after reactor tests remove unnecessary Unsubscribe return subscribe helper function move discardFromChan to where it is used subscribe now returns an err this gives us ability to refuse to subscribe if pubsub is at its max capacity. use context for control overflow cache queries handle err when subscribing in replay_test rename testClientID to testSubscriber extract var set channel buffer capacity to 1 in replay_file fix byzantine_test unsubscribe from single event, not all events refactor httpclient to return events to appropriate channels return failing testReplayCrashBeforeWriteVote test fix TestValidatorSetChanges refactor code a bit fix testReplayCrashBeforeWriteVote add comment fix TestValidatorSetChanges fixes from Bucky's review update comment [ci skip] test TxEventBuffer update changelog fix TestValidatorSetChanges (2nd attempt) only do wg.Done when no errors benchmark event bus create pubsub server inside NewEventBus only expose config params (later if needed) set buffer capacity to 0 so we are not testing cache new tx event format: key = "Tx" plus a tag {"tx.hash": XYZ} This should allow to subscribe to all transactions! or a specific one using a query: "tm.events.type = Tx and tx.hash = '013ABF99434...'" use TimeoutCommit instead of afterPublishEventNewBlockTimeout TimeoutCommit is the time a node waits after committing a block, before it goes into the next height. So it will finish everything from the last block, but then wait a bit. The idea is this gives it time to hear more votes from other validators, to strengthen the commit it includes in the next block. But it also gives it time to hear about new transactions. waitForBlockWithUpdatedVals rewrite WAL crash tests Task: test that we can recover from any WAL crash. Solution: the old tests were relying on event hub being run in the same thread (we were injecting the private validator's last signature). when considering a rewrite, we considered two possible solutions: write a "fuzzy" testing system where WAL is crashing upon receiving a new message, or inject failures and trigger them in tests using something like https://github.com/coreos/gofail. remove sleep no cs.Lock around wal.Save test different cases (empty block, non-empty block, ...) comments add comments test 4 cases: empty block, non-empty block, non-empty block with smaller part size, many blocks fixes as per Bucky's last review reset subscriptions on UnsubscribeAll use a simple counter to track message for which we panicked also, set a smaller part size for all test cases
187 lines
5.0 KiB
Go
187 lines
5.0 KiB
Go
package mempool
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"reflect"
|
|
"time"
|
|
|
|
abci "github.com/tendermint/abci/types"
|
|
wire "github.com/tendermint/go-wire"
|
|
"github.com/tendermint/tmlibs/clist"
|
|
"github.com/tendermint/tmlibs/log"
|
|
|
|
cfg "github.com/tendermint/tendermint/config"
|
|
"github.com/tendermint/tendermint/p2p"
|
|
"github.com/tendermint/tendermint/types"
|
|
)
|
|
|
|
const (
|
|
MempoolChannel = byte(0x30)
|
|
|
|
maxMempoolMessageSize = 1048576 // 1MB TODO make it configurable
|
|
peerCatchupSleepIntervalMS = 100 // If peer is behind, sleep this amount
|
|
)
|
|
|
|
// MempoolReactor handles mempool tx broadcasting amongst peers.
|
|
type MempoolReactor struct {
|
|
p2p.BaseReactor
|
|
config *cfg.MempoolConfig
|
|
Mempool *Mempool
|
|
}
|
|
|
|
// NewMempoolReactor returns a new MempoolReactor with the given config and mempool.
|
|
func NewMempoolReactor(config *cfg.MempoolConfig, mempool *Mempool) *MempoolReactor {
|
|
memR := &MempoolReactor{
|
|
config: config,
|
|
Mempool: mempool,
|
|
}
|
|
memR.BaseReactor = *p2p.NewBaseReactor("MempoolReactor", memR)
|
|
return memR
|
|
}
|
|
|
|
// SetLogger sets the Logger on the reactor and the underlying Mempool.
|
|
func (memR *MempoolReactor) SetLogger(l log.Logger) {
|
|
memR.Logger = l
|
|
memR.Mempool.SetLogger(l)
|
|
}
|
|
|
|
// GetChannels implements Reactor.
|
|
// It returns the list of channels for this reactor.
|
|
func (memR *MempoolReactor) GetChannels() []*p2p.ChannelDescriptor {
|
|
return []*p2p.ChannelDescriptor{
|
|
&p2p.ChannelDescriptor{
|
|
ID: MempoolChannel,
|
|
Priority: 5,
|
|
},
|
|
}
|
|
}
|
|
|
|
// AddPeer implements Reactor.
|
|
// It starts a broadcast routine ensuring all txs are forwarded to the given peer.
|
|
func (memR *MempoolReactor) AddPeer(peer p2p.Peer) {
|
|
go memR.broadcastTxRoutine(peer)
|
|
}
|
|
|
|
// RemovePeer implements Reactor.
|
|
func (memR *MempoolReactor) RemovePeer(peer p2p.Peer, reason interface{}) {
|
|
// broadcast routine checks if peer is gone and returns
|
|
}
|
|
|
|
// Receive implements Reactor.
|
|
// It adds any received transactions to the mempool.
|
|
func (memR *MempoolReactor) Receive(chID byte, src p2p.Peer, msgBytes []byte) {
|
|
_, msg, err := DecodeMessage(msgBytes)
|
|
if err != nil {
|
|
memR.Logger.Error("Error decoding message", "err", err)
|
|
return
|
|
}
|
|
memR.Logger.Debug("Receive", "src", src, "chId", chID, "msg", msg)
|
|
|
|
switch msg := msg.(type) {
|
|
case *TxMessage:
|
|
err := memR.Mempool.CheckTx(msg.Tx, nil)
|
|
if err != nil {
|
|
memR.Logger.Info("Could not check tx", "tx", msg.Tx, "err", err)
|
|
}
|
|
// broadcasting happens from go routines per peer
|
|
default:
|
|
memR.Logger.Error(fmt.Sprintf("Unknown message type %v", reflect.TypeOf(msg)))
|
|
}
|
|
}
|
|
|
|
// BroadcastTx is an alias for Mempool.CheckTx. Broadcasting itself happens in peer routines.
|
|
func (memR *MempoolReactor) BroadcastTx(tx types.Tx, cb func(*abci.Response)) error {
|
|
return memR.Mempool.CheckTx(tx, cb)
|
|
}
|
|
|
|
// PeerState describes the state of a peer.
|
|
type PeerState interface {
|
|
GetHeight() int
|
|
}
|
|
|
|
// Peer describes a peer.
|
|
type Peer interface {
|
|
IsRunning() bool
|
|
Send(byte, interface{}) bool
|
|
Get(string) interface{}
|
|
}
|
|
|
|
// Send new mempool txs to peer.
|
|
// TODO: Handle mempool or reactor shutdown?
|
|
// As is this routine may block forever if no new txs come in.
|
|
func (memR *MempoolReactor) broadcastTxRoutine(peer Peer) {
|
|
if !memR.config.Broadcast {
|
|
return
|
|
}
|
|
|
|
var next *clist.CElement
|
|
for {
|
|
if !memR.IsRunning() || !peer.IsRunning() {
|
|
return // Quit!
|
|
}
|
|
if next == nil {
|
|
// This happens because the CElement we were looking at got
|
|
// garbage collected (removed). That is, .NextWait() returned nil.
|
|
// Go ahead and start from the beginning.
|
|
next = memR.Mempool.TxsFrontWait() // Wait until a tx is available
|
|
}
|
|
memTx := next.Value.(*mempoolTx)
|
|
// make sure the peer is up to date
|
|
height := memTx.Height()
|
|
if peerState_i := peer.Get(types.PeerStateKey); peerState_i != nil {
|
|
peerState := peerState_i.(PeerState)
|
|
if peerState.GetHeight() < height-1 { // Allow for a lag of 1 block
|
|
time.Sleep(peerCatchupSleepIntervalMS * time.Millisecond)
|
|
continue
|
|
}
|
|
}
|
|
// send memTx
|
|
msg := &TxMessage{Tx: memTx.tx}
|
|
success := peer.Send(MempoolChannel, struct{ MempoolMessage }{msg})
|
|
if !success {
|
|
time.Sleep(peerCatchupSleepIntervalMS * time.Millisecond)
|
|
continue
|
|
}
|
|
|
|
next = next.NextWait()
|
|
continue
|
|
}
|
|
}
|
|
|
|
//-----------------------------------------------------------------------------
|
|
// Messages
|
|
|
|
const (
|
|
msgTypeTx = byte(0x01)
|
|
)
|
|
|
|
// MempoolMessage is a message sent or received by the MempoolReactor.
|
|
type MempoolMessage interface{}
|
|
|
|
var _ = wire.RegisterInterface(
|
|
struct{ MempoolMessage }{},
|
|
wire.ConcreteType{&TxMessage{}, msgTypeTx},
|
|
)
|
|
|
|
// DecodeMessage decodes a byte-array into a MempoolMessage.
|
|
func DecodeMessage(bz []byte) (msgType byte, msg MempoolMessage, err error) {
|
|
msgType = bz[0]
|
|
n := new(int)
|
|
r := bytes.NewReader(bz)
|
|
msg = wire.ReadBinary(struct{ MempoolMessage }{}, r, maxMempoolMessageSize, n, &err).(struct{ MempoolMessage }).MempoolMessage
|
|
return
|
|
}
|
|
|
|
//-------------------------------------
|
|
|
|
// TxMessage is a MempoolMessage containing a transaction.
|
|
type TxMessage struct {
|
|
Tx types.Tx
|
|
}
|
|
|
|
// String returns a string representation of the TxMessage.
|
|
func (m *TxMessage) String() string {
|
|
return fmt.Sprintf("[TxMessage %v]", m.Tx)
|
|
}
|