Ethan Buchman 882622ec10

Fixes tendermint/tendermint#3522 ...

* OriginalAddr -> SocketAddr

OriginalAddr records the originally dialed address for outbound peers,
rather than the peer's self reported address. For inbound peers, it was
nil. Here, we rename it to SocketAddr and for inbound peers, set it to
the RemoteAddr of the connection.

* use SocketAddr

Numerous places in the code call peer.NodeInfo().NetAddress().
However, this call to NetAddress() may perform a DNS lookup if the
reported NodeInfo.ListenAddr includes a name. Failure of this lookup
returns a nil address, which can lead to panics in the code.

Instead, call peer.SocketAddr() to return the static address of the
connection.

* remove nodeInfo.NetAddress()

Expose `transport.NetAddress()`, a static result determined
when the transport is created. Removing NetAddress() from the nodeInfo
prevents accidental DNS lookups.

* fixes from review

* linter

* fixes from review

2019-04-01 19:59:57 -04:00

..

client

rpc/client: include NetworkClient interface into Client interface (#3473)

2019-03-26 09:44:49 +01:00

core

Fixes tendermint/tendermint#3522

2019-04-01 19:59:57 -04:00

grpc

limit number of /subscribe clients and queries per client (#3269)

2019-03-11 22:45:58 +04:00

lib

rpc: client disable compression (#3430)

2019-03-19 20:18:18 -04:00

test

3291 follow-up (#3323)

2019-02-18 13:23:40 +04:00