Alessio Treglia 59cc6d36c9 improve ResetTestRootWithChainID() concurrency safety (#3291) ...

* improve ResetTestRootWithChainID() concurrency safety

Rely on ioutil.TempDir() to create test root directories and ensure
multiple same-chain id test cases can run in parallel.

* Update config/toml.go

Co-Authored-By: alessio <quadrispro@ubuntu.com>

* clean up test directories after completion

Closes: #1034

* Remove redundant EnsureDir call

* s/PanicSafety()/panic()/s

* Put create dir functionality back in ResetTestRootWithChainID

* Place test directories in OS's tempdir

In modern UNIX and UNIX-like systems /tmp is very often
mounted as tmpfs. This might speed test execution a bit.

* Set 0700 to a const

* rootsDirs -> configRootDirs

* Don't double remove directories

* Avoid global variables

* Fix consensus tests

* Reduce defer stack

* Address review comments

* Try to fix tests

* Update CHANGELOG_PENDING.md

Co-Authored-By: alessio <quadrispro@ubuntu.com>

* Update consensus/common_test.go

Co-Authored-By: alessio <quadrispro@ubuntu.com>

* Update consensus/common_test.go

Co-Authored-By: alessio <quadrispro@ubuntu.com>

2019-02-18 11:45:27 +04:00

..

config_test.go

config: Add ValidateBasic (#2485)

2018-09-26 12:04:44 +02:00

config.go

R4R: Split immutable and mutable parts of priv_validator.json (#2870)

2018-12-21 16:58:27 -05:00

toml_test.go

improve ResetTestRootWithChainID() concurrency safety (#3291)

2019-02-18 11:45:27 +04:00

toml.go

improve ResetTestRootWithChainID() concurrency safety (#3291)

2019-02-18 11:45:27 +04:00