mirror of
https://github.com/fluencelabs/tendermint
synced 2025-04-24 14:22:16 +00:00
27909e5d2a
* mempool: remove only valid (Code==0) txs on Update so evil proposers can't drop valid txs in Commit stage. Also remove invalid (Code!=0) txs from the cache so they can be resubmitted. Fixes #3322 @rickyyangz: In the end of commit stage, we will update mempool to remove all the txs in current block. // Update mempool. err = blockExec.mempool.Update( block.Height, block.Txs, TxPreCheck(state), TxPostCheck(state), ) Assum an account has 3 transactions in the mempool, the sequences are 100, 101 and 102 separately, So an evil proposal can only package the 101 and 102 transactions into its proposal block, and leave 100 still in mempool, then the two txs will be removed from all validators' mempool when commit. So the account lost the two valid txs. @ebuchman: In the longer term we may want to do something like #2639 so we can validate txs before we commit the block. But even in this case we'd only want to run the equivalent of CheckTx, which means the DeliverTx could still fail even if the CheckTx passes depending on how the app handles the ABCI Code semantics. So more work will be required around the ABCI code. See also #2185 * add changelog entry and tests * improve changelog message * reformat code
103 lines
3.2 KiB
Go
103 lines
3.2 KiB
Go
package mempool
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"crypto/sha256"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/tendermint/tendermint/abci/example/kvstore"
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
"github.com/tendermint/tendermint/proxy"
|
|
"github.com/tendermint/tendermint/types"
|
|
)
|
|
|
|
func TestCacheRemove(t *testing.T) {
|
|
cache := newMapTxCache(100)
|
|
numTxs := 10
|
|
txs := make([][]byte, numTxs)
|
|
for i := 0; i < numTxs; i++ {
|
|
// probability of collision is 2**-256
|
|
txBytes := make([]byte, 32)
|
|
rand.Read(txBytes) // nolint: gosec
|
|
txs[i] = txBytes
|
|
cache.Push(txBytes)
|
|
// make sure its added to both the linked list and the map
|
|
require.Equal(t, i+1, len(cache.map_))
|
|
require.Equal(t, i+1, cache.list.Len())
|
|
}
|
|
for i := 0; i < numTxs; i++ {
|
|
cache.Remove(txs[i])
|
|
// make sure its removed from both the map and the linked list
|
|
require.Equal(t, numTxs-(i+1), len(cache.map_))
|
|
require.Equal(t, numTxs-(i+1), cache.list.Len())
|
|
}
|
|
}
|
|
|
|
func TestCacheAfterUpdate(t *testing.T) {
|
|
app := kvstore.NewKVStoreApplication()
|
|
cc := proxy.NewLocalClientCreator(app)
|
|
mempool, cleanup := newMempoolWithApp(cc)
|
|
defer cleanup()
|
|
|
|
// reAddIndices & txsInCache can have elements > numTxsToCreate
|
|
// also assumes max index is 255 for convenience
|
|
// txs in cache also checks order of elements
|
|
tests := []struct {
|
|
numTxsToCreate int
|
|
updateIndices []int
|
|
reAddIndices []int
|
|
txsInCache []int
|
|
}{
|
|
{1, []int{}, []int{1}, []int{1, 0}}, // adding new txs works
|
|
{2, []int{1}, []int{}, []int{1, 0}}, // update doesn't remove tx from cache
|
|
{2, []int{2}, []int{}, []int{2, 1, 0}}, // update adds new tx to cache
|
|
{2, []int{1}, []int{1}, []int{1, 0}}, // re-adding after update doesn't make dupe
|
|
}
|
|
for tcIndex, tc := range tests {
|
|
for i := 0; i < tc.numTxsToCreate; i++ {
|
|
tx := types.Tx{byte(i)}
|
|
err := mempool.CheckTx(tx, nil)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
updateTxs := []types.Tx{}
|
|
for _, v := range tc.updateIndices {
|
|
tx := types.Tx{byte(v)}
|
|
updateTxs = append(updateTxs, tx)
|
|
}
|
|
mempool.Update(int64(tcIndex), updateTxs, abciResponses(len(updateTxs), abci.CodeTypeOK), nil, nil)
|
|
|
|
for _, v := range tc.reAddIndices {
|
|
tx := types.Tx{byte(v)}
|
|
_ = mempool.CheckTx(tx, nil)
|
|
}
|
|
|
|
cache := mempool.cache.(*mapTxCache)
|
|
node := cache.list.Front()
|
|
counter := 0
|
|
for node != nil {
|
|
require.NotEqual(t, len(tc.txsInCache), counter,
|
|
"cache larger than expected on testcase %d", tcIndex)
|
|
|
|
nodeVal := node.Value.([sha256.Size]byte)
|
|
expectedBz := sha256.Sum256([]byte{byte(tc.txsInCache[len(tc.txsInCache)-counter-1])})
|
|
// Reference for reading the errors:
|
|
// >>> sha256('\x00').hexdigest()
|
|
// '6e340b9cffb37a989ca544e6bb780a2c78901d3fb33738768511a30617afa01d'
|
|
// >>> sha256('\x01').hexdigest()
|
|
// '4bf5122f344554c53bde2ebb8cd2b7e3d1600ad631c385a5d7cce23c7785459a'
|
|
// >>> sha256('\x02').hexdigest()
|
|
// 'dbc1b4c900ffe48d575b5da5c638040125f65db0fe3e24494b76ea986457d986'
|
|
|
|
require.Equal(t, expectedBz, nodeVal, "Equality failed on index %d, tc %d", counter, tcIndex)
|
|
counter++
|
|
node = node.Next()
|
|
}
|
|
require.Equal(t, len(tc.txsInCache), counter,
|
|
"cache smaller than expected on testcase %d", tcIndex)
|
|
mempool.Flush()
|
|
}
|
|
}
|