mirror of
https://github.com/fluencelabs/tendermint
synced 2025-04-24 22:32:15 +00:00
228bba799d
* Expose priv validators for use in testing * Generalize block header validation test past height 1 * Remove ineffectual assignment * Remove redundant SaveState call * Reorder comment for clarity * Use the block executor ApplyBlock function instead of implementing a stripped-down version of it * Remove commented-out code * Remove unnecessary test The required tests already appear to be implemented (implicitly) through the TestValidateBlockHeader test. * Allow for catching of specific error types during TestValidateBlockCommit * Make return error testable * Clean up and add TestValidateBlockCommit code * Fix formatting * Extract function to create a new mock test app * Update comment for clarity * Fix comment * Add skeleton code for evidence-related test * Allow for addressing priv val by address * Generalize test beyond a single validator * Generalize TestValidateBlockEvidence past first height * Reorder code to clearly separate tests and utility code * Use a common constant for stop height for testing in state/validation_test.go * Refactor errors to resemble existing conventions * Fix formatting * Extract common helper functions Having the tests littered with helper functions makes them less easily readable imho, so I've pulled them out into a separate file. This also makes it easier to see what helper functions are available during testing, so we minimize the chance of duplication when writing new tests. * Remove unused parameter * Remove unused parameters * Add field keys * Remove unused height constant * Fix typo * Fix incorrect return error * Add field keys * Use separate package for tests This refactors all of the state package's tests into a state_test package, so as to keep any usage of the state package's internal methods explicit. Any internal methods/constants used by tests are now explicitly exported in state/export_test.go * Refactor: extract helper function to make, validate, execute and commit a block * Rename state function to makeState * Remove redundant constant for number of validators * Refactor mock evidence registration into TestMain * Remove extraneous nVals variable * Replace function-level TODOs with file-level TODO and explanation * Remove extraneous comment * Fix linting issues brought up by GolangCI (pulled in from latest merge from develop)
53 lines
1.8 KiB
Go
53 lines
1.8 KiB
Go
package state
|
|
|
|
import (
|
|
"github.com/tendermint/tendermint/types"
|
|
)
|
|
|
|
//------------------------------------------------------
|
|
// blockchain services types
|
|
// NOTE: Interfaces used by RPC must be thread safe!
|
|
//------------------------------------------------------
|
|
|
|
//------------------------------------------------------
|
|
// blockstore
|
|
|
|
// BlockStoreRPC is the block store interface used by the RPC.
|
|
type BlockStoreRPC interface {
|
|
Height() int64
|
|
|
|
LoadBlockMeta(height int64) *types.BlockMeta
|
|
LoadBlock(height int64) *types.Block
|
|
LoadBlockPart(height int64, index int) *types.Part
|
|
|
|
LoadBlockCommit(height int64) *types.Commit
|
|
LoadSeenCommit(height int64) *types.Commit
|
|
}
|
|
|
|
// BlockStore defines the BlockStore interface used by the ConsensusState.
|
|
type BlockStore interface {
|
|
BlockStoreRPC
|
|
SaveBlock(block *types.Block, blockParts *types.PartSet, seenCommit *types.Commit)
|
|
}
|
|
|
|
//-----------------------------------------------------------------------------------------------------
|
|
// evidence pool
|
|
|
|
// EvidencePool defines the EvidencePool interface used by the ConsensusState.
|
|
// Get/Set/Commit
|
|
type EvidencePool interface {
|
|
PendingEvidence(int64) []types.Evidence
|
|
AddEvidence(types.Evidence) error
|
|
Update(*types.Block, State)
|
|
// IsCommitted indicates if this evidence was already marked committed in another block.
|
|
IsCommitted(types.Evidence) bool
|
|
}
|
|
|
|
// MockEvidencePool is an empty implementation of EvidencePool, useful for testing.
|
|
type MockEvidencePool struct{}
|
|
|
|
func (m MockEvidencePool) PendingEvidence(int64) []types.Evidence { return nil }
|
|
func (m MockEvidencePool) AddEvidence(types.Evidence) error { return nil }
|
|
func (m MockEvidencePool) Update(*types.Block, State) {}
|
|
func (m MockEvidencePool) IsCommitted(types.Evidence) bool { return false }
|