mirror of
https://github.com/fluencelabs/tendermint
synced 2025-04-25 14:52:17 +00:00
5f3048bd09
if we call it after, we might receive a "fresh" transaction from `broadcast_tx_sync` before old transactions (which were not committed). Refs #1091 ``` Commit is called with a lock on the mempool, meaning no calls to CheckTx can start. However, since CheckTx is called async in the mempool connection, some CheckTx might have already "sailed", when the lock is released in the mempool and Commit proceeds. Then, that spurious CheckTx has not yet "begun" in the ABCI app (stuck in transport?). Instead, ABCI app manages to start to process the Commit. Next, the spurious, "sailed" CheckTx happens in the wrong place. ```
94 lines
2.9 KiB
Go
94 lines
2.9 KiB
Go
package types
|
|
|
|
import (
|
|
abci "github.com/tendermint/abci/types"
|
|
)
|
|
|
|
// NOTE/XXX: all type definitions in this file are considered UNSTABLE
|
|
|
|
//------------------------------------------------------
|
|
// blockchain services types
|
|
// NOTE: Interfaces used by RPC must be thread safe!
|
|
//------------------------------------------------------
|
|
|
|
//------------------------------------------------------
|
|
// mempool
|
|
|
|
// Mempool defines the mempool interface as used by the ConsensusState.
|
|
// Updates to the mempool need to be synchronized with committing a block
|
|
// so apps can reset their transient state on Commit
|
|
// UNSTABLE
|
|
type Mempool interface {
|
|
Lock()
|
|
Unlock()
|
|
|
|
Size() int
|
|
CheckTx(Tx, func(*abci.Response)) error
|
|
Reap(int) Txs
|
|
Update(height int64, txs Txs) error
|
|
Flush()
|
|
FlushAppConn() error
|
|
|
|
TxsAvailable() <-chan int64
|
|
EnableTxsAvailable()
|
|
}
|
|
|
|
// MockMempool is an empty implementation of a Mempool, useful for testing.
|
|
// UNSTABLE
|
|
type MockMempool struct {
|
|
}
|
|
|
|
func (m MockMempool) Lock() {}
|
|
func (m MockMempool) Unlock() {}
|
|
func (m MockMempool) Size() int { return 0 }
|
|
func (m MockMempool) CheckTx(tx Tx, cb func(*abci.Response)) error { return nil }
|
|
func (m MockMempool) Reap(n int) Txs { return Txs{} }
|
|
func (m MockMempool) Update(height int64, txs Txs) error { return nil }
|
|
func (m MockMempool) Flush() {}
|
|
func (m MockMempool) FlushAppConn() error { return nil }
|
|
func (m MockMempool) TxsAvailable() <-chan int64 { return make(chan int64) }
|
|
func (m MockMempool) EnableTxsAvailable() {}
|
|
|
|
//------------------------------------------------------
|
|
// blockstore
|
|
|
|
// BlockStoreRPC is the block store interface used by the RPC.
|
|
// UNSTABLE
|
|
type BlockStoreRPC interface {
|
|
Height() int64
|
|
|
|
LoadBlockMeta(height int64) *BlockMeta
|
|
LoadBlock(height int64) *Block
|
|
LoadBlockPart(height int64, index int) *Part
|
|
|
|
LoadBlockCommit(height int64) *Commit
|
|
LoadSeenCommit(height int64) *Commit
|
|
}
|
|
|
|
// BlockStore defines the BlockStore interface used by the ConsensusState.
|
|
// UNSTABLE
|
|
type BlockStore interface {
|
|
BlockStoreRPC
|
|
SaveBlock(block *Block, blockParts *PartSet, seenCommit *Commit)
|
|
}
|
|
|
|
//------------------------------------------------------
|
|
// evidence pool
|
|
|
|
// EvidencePool defines the EvidencePool interface used by the ConsensusState.
|
|
// UNSTABLE
|
|
type EvidencePool interface {
|
|
PendingEvidence() []Evidence
|
|
AddEvidence(Evidence) error
|
|
Update(*Block)
|
|
}
|
|
|
|
// MockMempool is an empty implementation of a Mempool, useful for testing.
|
|
// UNSTABLE
|
|
type MockEvidencePool struct {
|
|
}
|
|
|
|
func (m MockEvidencePool) PendingEvidence() []Evidence { return nil }
|
|
func (m MockEvidencePool) AddEvidence(Evidence) error { return nil }
|
|
func (m MockEvidencePool) Update(*Block) {}
|