tendermint

mirror of https://github.com/fluencelabs/tendermint synced 2025-05-21 18:41:18 +00:00

History

Gustavo Chaín 7b2d018f84 rpc: protect subscription access from race condition (#3910 )

When using the RPC client in my test suite (with -race enabled), I do a lot of Subscribe/Unsubscribe operations, at some point (randomly) the race detector returns the following warning:

WARNING: DATA RACE
Read at 0x00c0009dbe30 by goroutine 31:
runtime.mapiterinit()
/usr/local/go/src/runtime/map.go:804 +0x0
github.com/tendermint/tendermint/rpc/client.(*WSEvents).redoSubscriptionsAfter()
/go/pkg/mod/github.com/tendermint/tendermint@v0.31.5/rpc/client/httpclient.go:364 +0xc0
github.com/tendermint/tendermint/rpc/client.(*WSEvents).eventListener()
/go/pkg/mod/github.com/tendermint/tendermint@v0.31.5/rpc/client/httpclient.go:393 +0x3c6 

Turns out that the redoSubscriptionAfter is not protecting the access to subscriptions.

The following change protects the read access to the subscription map behind the mutex

2019-08-22 13:23:07 +04:00

mock

rpc: /broadcast_evidence (#3481 )

2019-07-22 12:15:29 +04:00

codec.go

Renamed wire.go to codec.go (#3827 )

2019-07-23 15:35:36 +02:00

event_test.go

limit number of /subscribe clients and queries per client (#3269 )

2019-03-11 22:45:58 +04:00

examples_test.go

rpc: add support for batched requests/responses (#3534 )