Ethan Buchman
8073e51b04
Merge pull request #2096 from tendermint/dev/adr_symmetric
...
[ADR] Proposal for encoding symmetric cryptography
2018-08-04 20:27:24 -04:00
Ethan Buchman
3161ebbc2f
Merge pull request #2091 from tendermint/dev/adr_secp_signatures
...
[ADR] Fix malleability problems in Secp256k1 signatures
2018-08-04 20:22:56 -04:00
Ethan Buchman
4cbeb30da2
Merge pull request #2136 from tendermint/1944-update-grpc
...
update genproto
2018-08-03 23:40:21 -04:00
Ethan Buchman
d5b5e5a2e4
Merge pull request #2135 from tendermint/2072-unresponsive-tm-after-cs-failure
...
consensus: non-responsive to CTRL-C if consensus state panics
2018-08-03 23:39:25 -04:00
ValarDragon
6691492540
(squash this) indicate what Ethereum does
2018-08-03 17:49:46 -07:00
Ethan Buchman
0f80a7da82
adr: chain-versions
2018-08-03 20:23:37 -04:00
Ethan Buchman
ae2238efe6
adr: protocol versioning
2018-08-03 20:21:40 -04:00
Anton Kaliaev
2878c7523f
update github bug report template ( #2131 )
2018-08-03 11:39:57 +04:00
Anton Kaliaev
b1cff0f9bf
[libs/autofile] create a Group ticker on Start
...
1) no need to stop the ticker in createTestGroup() method
2) now there is a symmetry - we start the ticker in OnStart(), we stop it
in OnStop()
Refs #2072
2018-08-03 11:34:58 +04:00
Anton Kaliaev
d09a3a6d3a
stop gracefully instead of trying to resume ops
...
Refs #2072
We most probably shouldn't be running any further when there is some
unexpected panic. Some unknown error happened, and so we don't know if
that will result in the validator signing an invalid thing. It might be
worthwhile to explore a mechanism for manual resuming via some console
or secure RPC system, but for now, halting the chain upon unexpected
consensus bugs sounds like the better option.
2018-08-03 11:24:55 +04:00
ValarDragon
87f09adeec
(Squash this) Be more explicit about the exact encoding of the secp signature
2018-08-02 23:27:16 -07:00
ValarDragon
b3a3c8a192
Merge remote-tracking branch 'origin/develop' into dev/adr_secp_signatures
2018-08-02 23:25:14 -07:00
ValarDragon
96fdec0fca
crypto: Add compact bit array for intended usage in the multisig
...
This is in a separate PR for ease of review.
2018-08-02 23:18:09 -07:00
Ethan Buchman
fe5e7808f2
fix Gopkg.lock
2018-08-02 19:15:32 -04:00
Ethan Buchman
2d1c5a1ce6
Merge remote-tracking branch 'origin/develop' into jae/literefactor4
2018-08-02 19:12:22 -04:00
Ethan Buchman
00ebdcd581
update pending changelog
2018-08-02 19:06:29 -04:00
Ethan Buchman
2487210414
Merge pull request #2097 from tendermint/1772-revert
...
revert "make `/status` RPC endpoint resistant to consensus halt"
2018-08-02 17:31:07 -04:00
ValarDragon
a040c36dfb
(squash this) change adr number, remove redundancy in function names
2018-08-02 10:43:47 -07:00
Anton Kaliaev
d579f4c610
update genproto
...
Closes #1944
2018-08-02 17:54:55 +04:00
Anton Kaliaev
b82138b002
update changelog
2018-08-02 16:48:12 +04:00
Anton Kaliaev
8ed99c2c13
exit from initSighupWatcher child goroutine
...
also, remove excessive log message
Refs #2072
2018-08-02 16:42:25 +04:00
Anton Kaliaev
4c5a143a70
respawn receiveRoutine so we can properly exit
...
Closes #2072
2018-08-02 16:36:28 +04:00
Anton Kaliaev
b33f73eaf1
stop autofile and autogroup properly
...
NOTE: from the ticker#Stop documentation:
```
Stop does not close the channel, to prevent a read from the channel
succeeding incorrectly.
https://golang.org/src/time/tick.go?s=1318:1341#L35
```
Refs #2072
2018-08-02 16:33:34 +04:00
Jae Kwon
e719a93d1d
Addressed review for #1815 except those marked as 'TODO make issue'
2018-08-02 03:10:50 -07:00
Jae Kwon
eb9b37e196
Pull out consensus liveness fix, which went to #1815
2018-08-02 01:59:46 -07:00
Dev Ojha
eaa137512c
adr: Encoding for cryptography at launch ( #2121 )
2018-08-01 18:19:21 -04:00
Dev Ojha
023bb99eb0
p2p: Add test vectors for deriving secrets ( #2120 )
...
These test vectors are needed for comparison with the Rust implementation.
To implement this effectively, a "RandBool" method was added to cmn.Rand.
2018-08-01 15:06:29 -04:00
Anton Kaliaev
f2f53442c6
reorder BaseConfig
according to generated version
...
also, add `priv_validator_laddr` to the template
2018-08-01 16:20:59 +04:00
Ismail Khoffi
24ae878b9f
update encoding test to how amino skips empty pointers
2018-08-01 13:29:41 +02:00
Jae Kwon
619bb3b2d7
Merge remote-tracking branch 'remotes/origin/jae/literefactor5' into jae/literefactor6
2018-08-01 03:06:00 -07:00
Dev Ojha
dde96b75ce
abci: Update readme for building protoc ( #2124 )
2018-08-01 13:57:31 +04:00
Dev Ojha
6fb2f44cc3
p2p: Connect to peers from a seed node immediately ( #2115 )
...
This is to reduce wait times when initially connecting. This still runs checks
such as whether you still want additional peers.
A test case has been created, which fails if this change is not included.
2018-07-31 22:09:01 +02:00
Zarko Milosevic
08ad162daa
docs: Modify blockchain spec to reflect validator set changes ( #2107 )
2018-07-31 20:19:57 +02:00
ValarDragon
a83eed104c
libs/cmn: Remove Tempfile, Tempdir, switch to ioutil variants ( #2114 )
...
Our Tempfile was just a wrapper on ioutil that panicked instead of error.
Our Tempdir was a less safe variant of ioutil's Tempdir.
2018-07-31 19:43:36 +02:00
ValarDragon
be642754f5
libs/cmn/writefileatomic: Handle file already exists gracefully ( #2113 )
...
This uses the stdlib's method of creating a tempfile in our write
file atomimc method, with a few modifications. We use a 64 bit number
rather than 32 bit, and therefore a corresponding LCG. This is to
reduce collision probability. (Note we currently used 32 bytes previously,
so this is likely a concern)
We handle reseeding the LCG in such a way that multiple threads are
even less likely to reuse the same seed.
2018-07-31 19:43:36 +02:00
ValarDragon
2608249e5b
libs/common: Refactor tempfile code into its own file
2018-07-31 19:43:36 +02:00
Anton Kaliaev
62b8ee270d
[docs] Validator's address can be skipped ( #2117 )
...
Refs #1712
2018-07-31 18:28:19 +02:00
Anton Kaliaev
0c7338c5f0
abci: Change validators to last_commit_info in RequestBeginBlock ( #2074 )
...
* change validators to last_commit_info in RequestBeginBlock
* do not send pubkeys with RequestBeginBlock
Refs #1856
2018-07-30 17:29:40 +02:00
Dev Ojha
231cdc1320
ci: Reduce log output in test_cover ( #2105 )
...
This commit makes it such that circle CI only shows the module whose
tests it is currently running in the log, unless a test fails. For each
failing test, it will display the name of all failing tests, along with
their log output. This is done to make
our log output far more scrollable. We lose no information in debugging.
2018-07-30 01:05:27 +02:00
Zaki Manian
fef4fe1c66
Link to "The latest gossip on BFT consensus" ( #2102 )
...
The paper is such a useful resource to anyone building on Tendermint. It should be linked in the ReadMe.
2018-07-29 09:49:42 +04:00
Dev Ojha
f00b52b710
libs/autofile/group_test: Remove unnecessary logging ( #2100 )
...
Previously we logged `Testing for i <i>` for all i in [0,100).
This was unnecessary. This changes it to just log the value for i on
error messages, to reduce the unnecessary verbosity in log files.
2018-07-29 09:48:37 +04:00
VenkatDatta
188e459273
Removed unnecessary onStart call ( #2098 )
...
* Removed unnecessary onStart & onStop calls in reactor
* Refactor OnStart & OnStop in reactor
* Removed redundant OnStart func in reactor
2018-07-29 09:46:53 +04:00
ValarDragon
3d5d254932
(squash this) Mixed up field element and curve element. Idea still stands.
2018-07-28 20:41:19 -07:00
ValarDragon
ce9ddc7cd7
(squash this) Note not to overwrite aead's.
2018-07-28 06:33:15 -07:00
ValarDragon
c03ad56d55
(squash this) Note that this breaks existing keys.
2018-07-28 04:23:22 -07:00
ValarDragon
caef5dcd69
(Squash this) forgot to say that algo_name should be length prefixed
2018-07-28 04:14:07 -07:00
Anton Kaliaev
7634073718
revert "make /status
RPC endpoint resistant to consensus halt"
...
Refs #1772
Reasons:
- this was a bad patch for something not well understood
Lessons learned:
- nobody should be modifying code without understanding the problem
first. it will only result in more technical debt and code rot.
- we never hide information when we suspect a bug or we'not sure what's
going on.
2018-07-28 09:17:42 +04:00
ValarDragon
af2894c0f8
(squash this) improve grammar.
2018-07-27 19:27:25 -07:00
ValarDragon
a2debe57c7
[ADR] Proposal for encoding symmetric cryptography
2018-07-27 18:10:41 -07:00
ValarDragon
5955eddc7d
ADR: Fix malleability problems in Secp256k1 signatures
...
Previously you could not assume that your transaction hash would
appear on chain.
2018-07-27 13:18:21 -07:00