Commit Graph

127 Commits

Author SHA1 Message Date
57a83fe73e Merge branch 'develop' into feature/enhance-endblock 2017-12-20 00:11:57 -08:00
3798f9fa8e Reorder README 2017-12-20 00:07:58 -08:00
c14d3982ac ValidatorSetUpdates -> ValidatorUpdates 2017-12-20 00:02:41 -08:00
811dc071aa protoc: "//nolint: gas" directive after pb generation (#164)
* protoc: "//nolint: gas" directive after pb generation

Fixes #138

Since we can't add package directives through the protoc
compiler, yet we need to "//nolint: gas" the Go generated
protobuf file, added a script whose purpose is to
go find the "package (\w+)$" declaration after go fmt
was run by protoc.

The competing solutions were more complex and can be
examined by visiting
https://github.com/tendermint/abci/issues/138#issuecomment-352226217

* simplify script

* rewrite script to work on Mac
2017-12-19 12:29:59 -06:00
66296fe11a updates -> validator_set_updates
ConsensusParamChanges -> ConsensusParamUpdates
2017-12-19 12:13:45 -06:00
eb6d412a82 Add tests to protobuf objects for pr coverage 2017-12-14 09:35:33 +01:00
9c5e1a824d Updated naming of EndBlock parameters
* Changes -> Updates for validators
* ConsensusParams.XXXParams -> ConsensusParams.XXX
* As per feedback from Jae on PR
2017-12-14 09:27:20 +01:00
25f6f6518c Update the ResponseEndBlock values
* Rename diffs -> changes
* Add consensus_param_changes

For context, see:
https://github.com/tendermint/tendermint/issues/924
https://github.com/tendermint/tendermint/issues/952
2017-12-13 17:50:24 +01:00
bbc3b807c6 all: fix vet issues with build tags, formatting
* Build tags need to come before the package name
and have at least a blank line, between them and
the package, please see
  https://golang.org/pkg/go/build/#hdr-Build_Constraints
* fmt.Println doesn't take formatting verbs
* Fix a missing formatting argument to fmt.Printf
2017-12-12 17:23:16 -07:00
310beae63c types: check ResponseCheckTx too 2017-12-12 10:14:50 -05:00
7167d4e4c7 types: compile type assertions to avoid sneaky runtime surprises
Ensure that the types in result.go implement both
json.Marshaler and json.Unmarshaler
and thus avoid any accidental deletions of their respective
methods which would then cause surprises at runtime.
2017-12-12 01:15:39 -07:00
47216538fd types: add UnmarshalJSON funcs for Response types 2017-12-06 03:19:28 -05:00
e1ee4d6bf5 types: add MarshalJSON funcs for Response types with a Code 2017-12-06 01:56:39 -05:00
1b2c383205 ResponseSetOption includes a response Code. Closes #64" 2017-12-05 18:41:52 -05:00
2b804bb5a1 remove custom type int https://github.com/gogo/protobuf/issues/359 2017-12-02 11:47:02 -05:00
82d56571b5 types: int32 with gogo int 2017-12-02 01:48:46 -05:00
3890a2058f types: IsOK() 2017-12-02 01:48:37 -05:00
b20273439d types: RequestBeginBlock includes absent and byzantine validators 2017-12-01 03:00:11 -05:00
9272756c49 types: add note about ReadMessage having no cap 2017-12-01 03:00:11 -05:00
3d3d1288d1 types: consolidate some file 2017-12-01 03:00:11 -05:00
0ad7dea71f uint64 -> int64 2017-12-01 00:41:07 -05:00
e3f6666ecc update changelog; add rudis script for safe keeping 2017-11-30 17:48:05 -05:00
81e4effbdb types: use data.Bytes directly in type.proto via gogo/protobuf. wow 2017-11-30 15:31:12 -05:00
308cb8e454 use gogo/protobuf 2017-11-30 14:47:09 -05:00
42a8e3240c remove CodeType 2017-11-30 14:29:12 -05:00
20befcf6d6 add 2 helper methods for building KVPair(s) 2017-11-30 11:17:35 -06:00
ab51bdef99 types.pb.go isnt linted. use nolint :( 2017-11-27 20:53:03 +00:00
e08885e3cd minor fix 2017-11-27 20:16:35 +00:00
7dc5b746ac types: add gas and fee fields to CheckTx 2017-11-27 20:10:11 +00:00
c7f54fb56c everything takes Request, returns Response; expect DeliverTx/CheckTx/Commit 2017-11-27 19:04:21 +00:00
67d2a5f66d set Code to OK in ResponseQuery in BaseApplication
See https://github.com/tendermint/abci/pull/130#discussion_r152713220
2017-11-24 16:45:36 -06:00
9b30fab4fc preserve behaviour of BaseApplication 2017-11-22 19:38:28 -06:00
2cfad8523a test HumanCode 2017-11-22 18:24:53 -06:00
1726e82865 add IsErr and Error method for ResultQuery 2017-11-22 18:19:41 -06:00
91efacfabc remove types.Result 2017-11-22 17:44:39 -06:00
f01f2bbf3a DeliverTxSync/CheckTxSync/CommitSync now return error as well 2017-11-22 17:34:00 -06:00
01252e8cc8 mark Result as deprecated 2017-11-22 16:18:06 -06:00
5fd83b3eee implement error interface for ResponseDeliverTx/CheckTx/Commit 2017-11-22 16:17:34 -06:00
fbe7234639 remove Result from the client package
plus make Client interface more consistent. All *Sync functions now
return an error as a second return param. Deliver/Check/Commit use Code
to indicate errors and have IsErr() func defined on ResponseXYZ structs.
2017-11-21 17:44:13 -06:00
3a3d508e5c CheckTx and DeliverTx return ResponseCheckTx and ResponseDeliverTx respectively
Commit now returns ResponseCommit
2017-11-20 20:36:42 -06:00
fc7db13fa8 remove tags from CheckTx
add value_type field to KVPair
2017-11-20 18:21:59 -06:00
33b51378f2 reformat types.proto 2017-11-20 16:56:57 -06:00
bb0d7e9526 add tags field to DeliverTx and CheckTx 2017-11-20 16:56:57 -06:00
667c2543ea use request struct for Info 2017-09-22 11:10:55 -04:00
fe426de5d4 lint: couple more fixes 2017-09-22 09:45:50 -04:00
318345f996 fix tests 2017-09-22 00:10:13 -04:00
f279171a28 use request structs for InitChain and BeginBlock 2017-09-18 15:51:48 -04:00
f1094f760b types: remove redundant version file 2017-09-06 02:22:59 -04:00
5dabeffb35 fixes from review 2017-05-15 12:59:44 -04:00
05dc4d12dd result.IsSameCode 2017-05-15 09:50:49 -04:00