Phil Salant
d1d517a9b7
linters: enable scopelint ( #3963 )
...
* Pin range scope vars
* Don't disable scopelint
This PR repairs linter errors seen when running the following commands:
golangci-lint run --no-config --disable-all=true --enable=scopelint
Contributes to #3262
2019-09-11 09:15:18 +04:00
Catalin Pirvu
46d32af055
Add tests for ValidateBasic methods ( #2754 )
...
Fixes #2740
2018-11-09 15:59:04 +01:00
Zarko Milosevic
c5905900eb
Simplify proposal msg ( #2735 )
...
* Align Proposal message with spec
* Update spec
2018-10-31 10:27:11 -04:00
Ismail Khoffi
6643c5dd11
Catch up with amino 0.13.0 ( #2690 )
...
* catch up with amino changes in
https://github.com/tendermint/go-amino/pull/222
* WIP: update to amino v0.13.0
* update to fixed amino release
2018-10-24 21:34:01 -04:00
Ismail Khoffi
fc073746a0
privval: Switch to amino encoding in SignBytes ( #2459 )
...
* switch to amino for SignBytes and add Reply with error message
- currently only Vote is done
* switch Reply type in socket for other messages
- add error description on error
* add TODOs regarding error handling
* address comments from peer review session (thx @xla)
- contains all changes besides the test-coverage / error'ing branches
* increase test coverage:
- add tests for each newly introduced error'ing code path
* return error if received wrong response
* add test for wrong response branches (ErrUnexpectedResponse)
* update CHANGELOG_PENDING and related documentation (spec)
* fix typo: s/CanonicallockID/CanonicalBlockID
* fixes from review
2018-09-28 19:57:29 -04:00
Ethan Buchman
309a6772d7
types: fix formatting when printing signatures
...
- use cmn.Fingerprint and %X
2018-08-05 16:35:43 -04:00
ValarDragon
f903947ff3
crypto: Remove interface from crypto.Signature
...
Signatures are now []byte, which saves on the number of bytes after
amino encoding
(squash this) address Ismail's comment
2018-08-05 15:46:57 -04:00
Liamsi
d2c05bc5b9
Revert "delete everything" (includes everything non-go-crypto)
...
This reverts commit 96a3502
2018-06-20 17:35:30 -07:00
Liamsi
96a3502126
delete everything
2018-06-20 15:19:08 -07:00
Jae Kwon
34974e3932
Make types use Amino; Refactor PrivValidator* to FilePV/SocketPV
2018-03-31 00:18:43 +02:00
Ethan Buchman
3395f5fb0e
types: builds
2018-03-02 01:28:38 -05:00
Ethan Buchman
d2cd079541
types: tests build
2018-03-02 01:28:21 -05:00
Ethan Buchman
8da2a6a147
types/priv_validator: fixes for latest p2p and cmn
2018-02-09 17:24:30 -05:00
Ethan Frey
5ffb5f01cc
Add more tests for Proposal/Vote serialization
...
String() and Proposal valid after serializing.
To be safe, but mainly to increase test coverage for the PR
2017-12-12 12:59:51 +01:00
Ethan Frey
599673690c
Add timestamp to vote canonical encoding
2017-12-12 12:59:51 +01:00
Ethan Frey
7deda53b7c
Add Timestamp to Proposal for issue #929
...
Store it as time.Timestamp locally, encode it as RFC3339 with milliseconds
before signing the canonical form.
2017-12-12 12:59:51 +01:00
Zach Ramsay
68e7983c70
linting errors: afew more
2017-11-27 22:39:11 +00:00
Ethan Buchman
75b97a5a65
PrivValidatorFS is like old PrivValidator, for now
2017-09-21 16:46:31 -04:00
Ethan Buchman
4382c8d28b
fix tests
2017-09-21 15:52:25 -04:00
Ethan Buchman
fd1b0b997a
PrivValidator interface
2017-09-21 15:51:20 -04:00
Ethan Buchman
90c0267bc1
types: privVal.Sign returns an error
2017-09-16 01:07:04 -04:00
Ethan Buchman
1b3766d802
types: canonical_json.go
2016-12-17 21:21:27 -05:00
Ethan Buchman
ed42f70248
types: benchmark WriteSignBytes
2016-12-17 21:21:27 -05:00
Jae Kwon
655d829314
Fix proposal sign bytes. Start tracking blockID in POL
2016-11-15 18:35:17 -05:00
Jae Kwon
ad17090a0f
No global config
2016-05-08 15:00:58 -07:00
Jae Kwon
03115cbf93
Fix tests; Tests run in their own directory
2016-03-06 15:05:50 -08:00
Jae Kwon
e12f9d10e7
Bare consensus refactor
2015-11-01 11:34:08 -08:00
Jae Kwon
c4ed55d801
Refactor to move common libraries out of project
2015-10-22 17:39:06 -07:00
Jae Kwon
1b9fd811a1
RPCResponse.Result && EventData are registered interfaces; -skip_upnp option
2015-08-11 11:01:18 -07:00
