3 Commits

Author	SHA1	Message	Date
Ethan Buchman	47f5e37205	copy RoundState for event	2017-11-07 23:57:23 +00:00
Anton Kaliaev	6d18e2f447	do not send whole round state via eventHub ... Fixes ``` WARNING: DATA RACE Write at 0x00c4200715b8 by goroutine 24: github.com/tendermint/tendermint/consensus.(*ConsensusState).enterPrevote.func1() /go/src/github.com/tendermint/tendermint/consensus/state.go:359 +0x3f github.com/tendermint/tendermint/consensus.(*ConsensusState).enterPrevote() /go/src/github.com/tendermint/tendermint/consensus/state.go:897 +0x8de github.com/tendermint/tendermint/consensus.(*ConsensusState).addProposalBlockPart() /go/src/github.com/tendermint/tendermint/consensus/state.go:1303 +0x701 github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:560 +0x88c github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:525 +0x6d2 Previous read at 0x00c4200715b8 by goroutine 19: github.com/tendermint/tendermint/consensus.makeRoundStepMessages() /go/src/github.com/tendermint/tendermint/consensus/reactor.go:415 +0x192 github.com/tendermint/tendermint/consensus.(*ConsensusReactor).broadcastNewRoundStep() /go/src/github.com/tendermint/tendermint/consensus/reactor.go:377 +0x3c github.com/tendermint/tendermint/consensus.(*ConsensusReactor).broadcastNewRoundStepsAndVotes.func1() /go/src/github.com/tendermint/tendermint/consensus/reactor.go:350 +0x275 ```	2017-10-30 00:32:23 -05:00
Anton Kaliaev	dc0e8de9b0	extract some of the consensus types into ./types ... so they can be used in rpc/core/types/responses.go. ``` So, it seems like we could use the actual structs here, but we don't want to have to import consensus to get them, as then clients are importing too much crap. So probably we should move some types from consensus into consensus/types so we can import. Will these raw messages be identical to: type ResultDumpConsensusState struct { RoundState cstypes.RoundState PeerRoundStates map[string]cstypes.PeerRoundState } ``` https://github.com/tendermint/tendermint/pull/724#discussion_r143598193	2017-10-10 12:39:21 +04:00