Aleksandr Bezobchuk
cfd42be0fe
Improve error and tests
2019-05-22 20:02:00 -04:00
Alessio Treglia
7644d27307
Ensure multisig keys have 20-byte address ( #3103 )
...
* Ensure multisig keys have 20-byte address
Use crypto.AddressHash() to avoid returning 32-byte long address.
Closes : #3102
* fix pointer
* fix test
2019-01-10 18:37:34 -05:00
Alessio Treglia
764cfe33aa
Don't use pointer receivers for PubKeyMultisigThreshold ( #3100 )
...
* Don't use pointer receivers for PubKeyMultisigThreshold
* test that showcases panic when PubKeyMultisigThreshold are used in sdk:
- deserialization will fail in `readInfo` which tries to read a
`crypto.PubKey` into a `localInfo` (called by
cosmos-sdk/client/keys.GetKeyInfo)
* Update changelog
* Rename routeTable to nameTable, multisig key is no longer a pointer
* sed -i 's/PubKeyAminoRoute/PubKeyAminoName/g' `grep -lrw PubKeyAminoRoute .`
upon Jae's request
* AminoRoutes -> AminoNames
* sed -e 's/PrivKeyAminoRoute/PrivKeyAminoName/g'
* Update crypto/encoding/amino/amino.go
Co-Authored-By: alessio <quadrispro@ubuntu.com>
2019-01-10 17:47:20 -05:00
Ethan Buchman
38b401657e
Cleanup up Multisig naming ( #2255 )
...
* crypto/multisig: Pubkey -> PubKey
* crypto/encoding/amino: use pkg vars for routes
* crypto/multisig/bitarray
* crypto/multisig: ThresholdMultiSignaturePubKey -> PubKeyMultisigThreshold
* crypto/encoding/amino: add PubKeyMultisig to table
* remove bA import alias
https://github.com/tendermint/tendermint/pull/2255#discussion_r211900709
2018-08-28 08:41:40 +04:00
Dev Ojha
728d2ed266
crypto: Remove unnecessary prefixes from amino route variable names ( #2205 )
...
* crypto: Remove unnecessary ed25519 and secp256k1 prefixes from amino routes.
* (squash this) add changelog
* (squash this) multisig amino fixes
* (squash this) fix build error
2018-08-14 19:13:25 -04:00
ValarDragon
2fe34491ba
(squash this) Fix build errors
2018-08-14 11:42:40 -07:00
ValarDragon
6beaf6e72d
(squash this) address Jae's comments on NumTrueBitsBefore
2018-08-13 18:46:33 -07:00
ValarDragon
8d28344e84
(Squash this) switch to bare
2018-08-10 13:59:35 -05:00
ValarDragon
4cf1dbd676
(squash this) fix amino route
2018-08-10 13:20:59 -05:00
ValarDragon
00db469fc0
(squash this) begin addressing PR comments
2018-08-10 13:14:43 -05:00
ValarDragon
aab26c3ff7
Merge remote-tracking branch 'origin/develop' into dev/multisig
2018-08-09 01:05:39 -05:00
Dev Ojha
5a8fe61200
crypto: Add compact bit array for intended usage in the multisig ( #2140 )
...
* crypto: Add compact bit array for intended usage in the multisig
This is in a separate PR for ease of review.
* (squash this) add comment
2018-08-09 09:38:23 +04:00
ValarDragon
4e7bf10b59
(squash this) squashed bug with multiple signatures at same index.
2018-08-07 11:37:42 -05:00
ValarDragon
67b6d51ff4
(squash this) address PR comments + fix bug in equality check
2018-08-07 10:44:38 -05:00
ValarDragon
e7dd76c28d
crypto: Threshold multisig implementation
2018-08-06 21:17:38 -05:00
ValarDragon
21448bcf4f
crypto: Add compact bit array for intended usage in the multisig
...
This is in a separate PR for ease of review.
2018-08-06 15:55:02 -05:00
