Commit Graph

6575 Commits

Author SHA1 Message Date
4c2f56626a lite/proxy: Validation* tests and hardening for nil dereferences
Updates https://github.com/tendermint/tendermint/issues/1017

Ensure that the Validate* functions in proxy are tests
and cover the case of sneakish bugs that have been encountered
a few times from nil dereferences. The lite package should
theoretically never panic with a nil dereference. It is meant
to contain the certifiers hence it should never panic with such.

Requires the following bugs to be fixed first;
* https://github.com/tendermint/tendermint/issues/1298
* https://github.com/tendermint/tendermint/issues/1299
2018-03-24 23:54:01 -06:00
a04f2ae5c6 tmlibs 0.8.0-dev; canonical concrete names 2018-03-25 07:15:24 +02:00
e9cf47606c Merge panics into errors in Parallel 2018-03-25 00:04:47 +01:00
c62aed95f2 Lock to 0.8.0-dev tmlibs 2018-03-24 23:51:08 +01:00
87c0473730 New Error (#180)
* New Error can capture Stacktrace
* Intelligent ErrorWrap
* Review fixes
2018-03-24 22:19:44 +01:00
e3337d764a Merge pull request #1354 from tendermint/bucky/dep
update dep
2018-03-24 12:14:56 -04:00
aeb6d14c1c version bump 2018-03-23 09:13:59 -04:00
214817ed17 do not add peer to switch if it fails to start 2018-03-23 13:31:48 +01:00
116a4ec705 temporary fix
I assume there is a deeper issue with how UnmarshalBinary works in
go-amino (i.e., when loading array of some objects, the empty array
becomes []object{nil}). Note when Marshaling, the object is nil.
2018-03-23 12:47:02 +01:00
bbaad22982 update dep 2018-03-23 10:27:00 +01:00
a7250af303 Exponential backoff follow up (#1349)
* document new functionality [ci skip]

Refs #1304

* add fixme [ci skip]

Refs #1304

* ensure that we dial peer after backoff duration

Refs #1304
2018-03-23 09:48:27 +01:00
46686763ba Merge pull request #219 from tendermint/release/v0.10.2
Release/v0.10.2
2018-03-23 00:16:46 -04:00
454db6c12b version and changelog 2018-03-23 00:21:27 -04:00
8fc21cdcd9 remove omitempty 2018-03-22 23:59:25 -04:00
5310e85bbb run make protoc 2018-03-22 23:46:23 -04:00
f3f9f792a5 Merge pull request #218 from tendermint/release/v0.10.1
Release/v0.10.1
2018-03-22 23:18:30 -04:00
968db546ee changelog update 2018-03-22 23:13:55 -04:00
4600f19d9f add nullable=false and omitempty to fee 2018-03-22 22:53:09 -04:00
e0c174b02b remove nullable=false from fee 2018-03-22 22:50:26 -04:00
f9d9d92ea3 fix dep for minor version bumps 2018-03-22 20:01:07 -04:00
c11bcd7890 update dep for tmlibs 2018-03-22 19:44:43 -04:00
24da7009c3 Merge pull request #178 from tendermint/release/v0.7.1
Release/v0.7.1
2018-03-22 19:38:39 -04:00
db3d1cb7fa changelog and version 2018-03-22 19:36:57 -04:00
d46b9afb79 Simplify WriteFileAtomic
We can make the implementation more robust by adjusting our assumptions
and leverage explicit file modes for syncing. Additionally we going to
assume that we want to clean up and can't really recover if thos
operations (file close and removal) fail.

* utilise file mode for majority of concerns
* improve test coverage by covering more assumptions
* signature parity with ioutil.WriteFile
* always clean up

Replaces #160
2018-03-22 19:36:24 -04:00
97bdad8262 common: NewBitArray never crashes on negatives (#170)
Fixes #169
Fixes https://github.com/tendermint/tendermint/issues/1322

The previous code was very trusting assuming that
rational actors will use this code. However, Byzantine
actors don't care and in the case of the linked issue
negative lengths can be sent to this code unfettered
having been received from a peer.

This code is essentially just a sign change from
`==`
to
`<=`

and we've gutted out that attack by being more defensive.
2018-03-22 19:36:24 -04:00
3135fca73b changelog, dep, version 2018-03-22 19:19:16 -04:00
215831d035 update spec and explain more 2018-03-22 19:12:08 -04:00
5306147a2d types: revert CheckTx/DeliverTx changes. make them the same 2018-03-22 19:11:34 -04:00
c0549ec943 Merge pull request #175 from tendermint/bucky/changelog
update version, changelog
2018-03-22 19:09:06 -04:00
dc1042eb5f finish changelog 2018-03-22 13:55:55 -04:00
6545a21369 docs/examples: update quick start guide (#1351) 2018-03-22 08:58:02 +01:00
416f03c05b Add light client spec 2018-03-21 10:00:18 +01:00
b6400af7ac update version, changelog 2018-03-21 05:15:30 +01:00
a86b1d8f75 Merge pull request #171 from tendermint/feature/xla-writefileatomic
Simplify WriteFileAtomic
2018-03-21 05:04:14 +01:00
ced74251e9 maxPacketMsg -> packetMsgMax... 2018-03-21 02:47:38 +01:00
6c345f9fa2 First stab: p2p/conn 2018-03-21 02:27:10 +01:00
8c0c8e8e01 Merge pull request #1301 from tendermint/types-data+header+non-nil-panics
types: Hash invoked for nil Data and Header should not panic
2018-03-20 23:38:55 +01:00
4e5c655944 Parallel reaps automatically before returning 2018-03-20 23:08:51 +01:00
4caf943f49 Parallel returns a TaskResultSet 2018-03-20 21:43:58 +01:00
db48010e81 Add return parameter to Parallel 2018-03-20 19:58:05 +01:00
bf24f2dcc5 Implement better Parallel (#174)
* Implement better Parallel
2018-03-20 19:24:18 +01:00
79315efd1f Merge pull request #1341 from EugeneChung/develop
Remove unnecessary bytes.Compare() call
2018-03-20 16:27:06 +01:00
a61130aebb Remove unnecessary bytes.Compare() call 2018-03-20 23:43:18 +09:00
5a51a0ba06 Merge pull request #1337 from tendermint/1296-follow-up
Follow up for /health endpoint
2018-03-20 10:36:47 +01:00
0d0b56739d Merge pull request #1335 from tendermint/zarko/1146-improve-bft-time-spec
Improve BFT time spec
2018-03-20 01:00:34 +01:00
eb1816c9ff Merge pull request #1338 from tendermint/1266/xla-fix-flaky-testswitchreconnectstopersistentpeer
p2p: Keep reference to connections in test peer
2018-03-20 00:14:38 +01:00
50ae892d5e p2p: Keep reference to connections in test peer
We observed non-deterministic test failures in one of our switch tests,
which would happen if the GC would run between iterations of the accept
loop. As we don't hold any reference to the connection the setup
finalizer might get triggered and therefore the file handle closed. For
the curious check the references on finalizers and the variable scoping
in the spec:

https://groups.google.com/forum/#!topic/golang-nuts/xWkhGJ5PY6c
https://groups.google.com/forum/#!topic/golang-nuts/d8aF4rAob7U/discussion
https://golang.org/ref/spec#Declarations_and_scope

Fixes #1266
2018-03-19 20:35:12 +01:00
5a79b3d74a Improve the spec to make explicit median computation based on voting power 2018-03-19 19:10:02 +01:00
460599ef75 fix comment 2018-03-19 20:01:43 +03:00
830bb72d6f add Health method to clients
Refs #1296
2018-03-19 20:01:43 +03:00