d3e276bf80
Merge pull request #1209 from tendermint/1205-fixes-for-p2p-memory-leak-and-pong
...
Fixes for p2p memory leak and pong
2018-02-12 19:04:31 -05:00
bf70f5e273
Merge pull request #191 from tendermint/tm-1205-quit-method-added
...
Quit method was added to Service/BaseService
2018-02-12 19:04:04 -05:00
c858b3ba78
Merge pull request #150 from tendermint/tm-1205-add-quit-method-to-service
...
add Quit method to Service interface
2018-02-12 18:39:26 -05:00
9bd1f28b8d
Minor package changes
2018-02-12 09:41:54 -05:00
fc585bcdec
do not block when writing to pongTimeoutCh
...
Refs #1205
2018-02-12 17:04:07 +04:00
2a24ae90c1
fixes from Jae's review
...
1. remove pointer
2. add Quit() method to Service interface
2018-02-12 14:32:09 +04:00
5913ae8960
Quit method was added to Service/BaseService
...
Refs https://github.com/tendermint/tendermint/issues/1205
2018-02-12 12:22:32 +04:00
a57340ffb5
add Quit method to Service interface
...
remove deprecated QuitService
2018-02-12 11:40:42 +04:00
8da2a6a147
types/priv_validator: fixes for latest p2p and cmn
2018-02-09 17:24:30 -05:00
7d71e702d8
Integrate privVal client with node secret
2018-02-09 16:54:43 -05:00
38d18ca11a
Harden tests
2018-02-09 16:53:17 -05:00
32d9563a15
Format and consolidate
2018-02-09 16:53:17 -05:00
18f7e52562
Use secret connection
2018-02-09 16:53:17 -05:00
fec541373d
Correct server protocol
2018-02-09 16:53:17 -05:00
ff600e9aa0
wip: check error of wire read
2018-02-09 16:53:17 -05:00
a49357b19e
wip: Avoid underscore in var name
2018-02-09 16:53:17 -05:00
4b997c29ee
wip: fix nil pointer deference
2018-02-09 16:53:17 -05:00
d321839669
wip: fix code block in ADR
2018-02-09 16:53:17 -05:00
c27fda09dd
wip: Comment types
...
* add comments to all public types
* fix comments to adhere to comment standards
2018-02-09 16:53:15 -05:00
23eb84db35
wip: priv val via sockets
2018-02-09 16:52:58 -05:00
bef91ea7fe
adr-008-priv-validator
2018-02-09 16:52:05 -05:00
459633fb4c
types/priv_validator
2018-02-09 16:38:23 -05:00
f1c8489270
Merge pull request #1201 from tendermint/1022-do-not-enforce-1/3-val-changes
...
do not enforce 1/3 validator power change
2018-02-09 16:15:38 -05:00
2d10c8f15b
Merge pull request #1095 from tendermint/804-p2p-issues
...
[p2p] Pong Timeout
2018-02-09 14:38:24 -05:00
106cdb74e5
do not enforce 1/3 validator power change
...
leave it to the app
Refs #1022
2018-02-09 23:30:04 +04:00
22b038810a
do not block in recvRoutine
2018-02-09 23:03:26 +04:00
45750e1b29
fix race by sending signal instead of stopping pongTimer
2018-02-09 21:32:29 +04:00
26419fba28
refactor code plus add one more test
...
* extract stopPongTimer method
* TestMConnectionMultiplePings
2018-02-09 21:32:29 +04:00
ac0123d249
drain pongTimeoutCh and pongTimer's channel to prevent leaks
2018-02-09 21:32:29 +04:00
f4ff66de30
rewrite pong timer to use time.AfterFunc
2018-02-09 21:32:29 +04:00
747b73cb95
fix merge conflicts
2018-02-09 21:32:29 +04:00
161e100a24
close return channel when we're done
...
Benchmark results:
```
BenchmarkSwitchBroadcast-2 30000 71275 ns/op
--- BENCH: BenchmarkSwitchBroadcast-2
switch_test.go:339: success: 1, failure: 0
switch_test.go:339: success: 100, failure: 0
switch_test.go:339: success: 10000, failure: 0
switch_test.go:339: success: 30000, failure: 0
```
2018-02-09 21:32:29 +04:00
3ae738f453
increase timeouts
2018-02-09 21:32:29 +04:00
d14d4a2527
remove TryBroadcast
2018-02-09 21:32:29 +04:00
860da464df
remove weird concurrency testing
2018-02-09 21:32:28 +04:00
4e2000abfe
control order by sending msgs from one goroutine
2018-02-09 21:32:28 +04:00
5834a59816
read ping
2018-02-09 21:32:28 +04:00
b28b76ddf7
rename pingTimeout to pingInterval, pongTimer is now time.Timer
2018-02-09 21:32:28 +04:00
91e4f4b786
ping/pong timeout in config
2018-02-09 21:32:28 +04:00
9b554fb2c4
switch test modification
2018-02-09 21:32:28 +04:00
f97ead4f5f
prep for merge
2018-02-09 21:32:28 +04:00
5af22d6ee6
remove SwitchEventNewPeer, SwitchEventDonePeer
2018-02-09 21:32:28 +04:00
1d16df6a92
add test, TrySend in broadcast
2018-02-09 21:32:27 +04:00
e7bc946760
Merge pull request #1200 from tendermint/update-deps
...
Update tmlibs & protobuf deps
2018-02-09 11:00:43 -05:00
cf1e1f5899
Merge pull request #1194 from tendermint/1177-semantics-of-currate-low-msg
...
improve "curRate too low" message
2018-02-09 11:00:09 -05:00
2f8372d629
update protobuf
2018-02-09 13:58:36 +04:00
d84e4effce
update tmlibs
2018-02-09 13:47:51 +04:00
52ce4c20f8
Fix RepeatTimer memory leak ( #137 )
...
fix RepeatTimer memory leak (Refs #137 )
* test case
* drain channels on reset
Leaking memory:
```
leaktest.go:144: leaktest: leaked goroutine: goroutine 116 [chan send]:
github.com/tendermint/tmlibs/common.(*RepeatTimer).fireRoutine(0xc42006a410, 0xc4203403c0, 0xc42031b2c0)
/go/src/github.com/tendermint/tmlibs/common/repeat_timer.go:160 +0x6e
created by github.com/tendermint/tmlibs/common.(*RepeatTimer).reset
/go/src/github.com/tendermint/tmlibs/common/repeat_timer.go:196 +0xe9
```
The alternative solution could be draining channels on the client side.
* add one more select instead of draining
thanks to Jae
2018-02-09 13:31:32 +04:00
0c1b91b762
revert back curRate != 0
2018-02-09 13:02:44 +04:00
c8990d06d9
remove curRate != 0
2018-02-09 12:01:13 +04:00
