259 Commits

Author SHA1 Message Date
Emmanuel Odeke
62115b55ef
CRandHex: fix up doc to mention length of digits
The previous doc seemed misleading and was out of date i.e.
RandHex(24)
not
CRandHex.

Anyways provide a doc of what the function does in relation to
the length of digits of the hex value returned i.e.
  floor(numDigits / 2) * 2
so the even lowest number
  e.g:
  * len(CRandHex(5)) = 4
  * len(CRandHex(4)) = 4
2017-12-22 23:16:34 -07:00
Ethan Buchman
43cc4fb645
Merge pull request #53 from tendermint/constant-time-equals
Constant time equals
2017-12-21 20:03:53 -05:00
Ethan Buchman
eaf4b8c795 fix Equals 2017-12-21 19:51:57 -05:00
Ethan Frey
468c4188c1
Merge pull request #51 from tendermint/keystore
Keybase
2017-11-29 15:25:59 +01:00
Ethan Frey
086e1f6508 Make vetshadow and zach happy 2017-11-15 13:57:17 +01:00
Ethan Frey
2649c056cd Minor cleanup 2017-11-13 14:54:14 +01:00
Ethan Frey
9d78be41b5 Update tmlibs to sdk-develop, fix broken test 2017-11-13 14:41:00 +01:00
Ethan Frey
2d4544d6ce Tests compile 2017-11-13 14:36:43 +01:00
Ethan Frey
4173d1031e go build compiles 2017-11-13 14:36:43 +01:00
Ethan Frey
9ef978c5ec Fix errors except for es missing 2017-11-13 14:36:43 +01:00
Ethan Frey
946c9c573e Handle generating keys 2017-11-13 14:36:43 +01:00
Ethan Frey
ac841a6124 Fixed imports 2017-11-13 14:36:43 +01:00
Jae Kwon
a2583e2783 Draft of suggested changes 2017-11-13 14:36:43 +01:00
Ethan Buchman
b4f04f196c
Merge pull request #49 from tendermint/pubKey-invalid-data-returns-empty-pubKey
PubKeyFromBytes: return zero value PubKey on error
2017-11-06 13:05:06 -06:00
Emmanuel Odeke
b0cf4b4757
PubKeyFromBytes: return zero value PubKey on error
Fixes https://github.com/tendermint/go-crypto/issues/48.

This previously skewed up my fuzzing tests so ensure
that on error we return the zero value PubKey.
2017-10-28 14:11:22 -07:00
Ethan Buchman
dd20358a26
Merge pull request #47 from tendermint/release-v0.4.1
Release v0.4.1
2017-10-27 22:28:35 -04:00
Ethan Buchman
d2b1a7096e changelog 2017-10-27 22:17:34 -04:00
Ethan Buchman
377d3c7e11 fix from revert 2017-10-27 22:04:22 -04:00
Ethan Buchman
6405618220 Revert "Upgrade keys to use bcrypt with salts (#38)"
This reverts commit 8e7f0e7701f92206679ad093d013b9b162427631.
2017-10-27 22:02:44 -04:00
Ethan Buchman
87badb090f Revert "Parameterize and lower bcrypt cost"
This reverts commit dfc4cdd2d71513e4a9922d679c74f36357c4c862.
2017-10-27 21:58:02 -04:00
Ethan Buchman
d1f00be7a0
Merge pull request #46 from tendermint/develop
Develop
2017-10-27 12:57:37 -04:00
Ethan Buchman
8630b724b2 version and changelog 2017-10-27 12:57:26 -04:00
Ethan Frey
ad31f6a953 osx + hid = <3 2017-10-27 18:46:21 +02:00
Ethan Buchman
944d36ab00 changelog 2017-10-27 12:04:31 -04:00
Ethan Buchman
57346134a5 keys: transactions.go -> types.go 2017-10-26 16:43:32 -04:00
Ethan Frey
db5603e374 Merge pull request #45 from tendermint/bugfix/nano-hid
Bugfix: ledger nano/hid compiles on osx/golang1.9
2017-10-26 06:52:52 -07:00
Ethan Frey
5d8890530a Update glide deps, nano/hid for osx/golang1.9 2017-10-26 12:00:42 +02:00
Ethan Frey
c496dea2e5 Merge pull request #42 from tendermint/feature/bcrypt-usability
Bcrypt usability
2017-10-26 11:59:32 +02:00
Emmanuel Odeke
3df2ca128d
make PrivateKey + Signature comparisons use constant time comparisons
Fixes https://github.com/tendermint/go-crypto/issues/43

Avoid susceptibility to timing/side channel attacks by ensuring
that private key and signature comparisons use
`subtle.ConstantTimeCompare`
instead of
`bytes.Equal`
2017-10-25 19:56:13 -07:00
Ethan Frey
dfc4cdd2d7 Parameterize and lower bcrypt cost 2017-10-24 12:19:45 +02:00
Ethan Frey
0a5b1d979a Merge pull request #37 from tendermint/nano
Nano Support
2017-10-24 12:18:45 +02:00
Ethan Frey
0219ba2a63 Fix bug introduced by metalinting... 2017-10-24 12:14:20 +02:00
Ethan Frey
69a7b389b8 Removed keys/server as it is now in cosmos-sdk 2017-10-24 11:59:44 +02:00
Ethan Frey
6f6bbf718e Fix metalinter complaints 2017-10-24 11:56:37 +02:00
Ethan Frey
2d04544088 Addressed Buckys PR review comments 2017-10-24 11:38:06 +02:00
Ethan Frey
4a2c63f5e1 Update ledger names to specify ed25519 2017-10-24 11:38:06 +02:00
Ethan Frey
9601e48ab4 Improve error message 2017-10-24 11:38:06 +02:00
Ethan Frey
61d1bdb5ed Test error handling, load without ledger 2017-10-24 11:38:06 +02:00
Ethan Frey
9afceb7ee8 ledger pubkey serializes properly, better load checks 2017-10-24 11:38:06 +02:00
Ethan Frey
2490952515 nano validates key on load 2017-10-24 11:38:06 +02:00
Ethan Frey
bce88a20df Enable privkey validity checking on load 2017-10-24 11:38:06 +02:00
Ethan Frey
1b8d52bb82 Rename NameLedger to NameLedgerEd25519 2017-10-24 11:38:06 +02:00
Ethan Frey
ae078ee915 Generate/recover can return error, not panic on ledger 2017-10-24 11:38:06 +02:00
Ethan Frey
085d72d212 Cleanup nano calls, cannot run parallel test on one hardware device 2017-10-24 11:38:06 +02:00
Ethan Frey
91fccb8b14 Add test for cryptostore working with ledger 2017-10-24 11:38:06 +02:00
Ethan Frey
88475230c4 Re-enabled crypostore example usage 2017-10-24 11:38:06 +02:00
Ethan Frey
34b9309f24 Re-enable signing tests with cryptostore 2017-10-24 11:38:06 +02:00
Ethan Frey
8c98c4fdf4 Add nano ledger to key manager 2017-10-24 11:38:06 +02:00
Ethan Frey
0383feab49 Add and test serialization of ledger privkey 2017-10-24 11:38:06 +02:00
Ethan Frey
3edeb0cd45 Ledger caches pubkey, works with newer firmware 2017-10-24 11:38:06 +02:00