tendermint

fluencelabs/tendermint

Fork 0

mirror of https://github.com/fluencelabs/tendermint synced 2025-04-25 06:42:16 +00:00

Commit Graph

Author	SHA1	Message	Date
Ismail Khoffi	b089587b42	make gosec linter pass (#3294 ) * not related to linter: remove obsolete constants: - `Insecure` and `Secure` and type `Security` are not used anywhere * not related to linter: update example - NewInsecure was deleted; change example to NewRemoteDB * address: Binds to all network interfaces (gosec): - bind to localhost instead of 0.0.0.0 - regenerate test key and cert for this purpose (was valid for ::) and otherwise we would see: transport: authentication handshake failed: x509: certificate is valid for ::, not 127.0.0.1\" (used https://github.com/google/keytransparency/blob/master/scripts/gen_server_keys.sh to regenerate certs) * use sha256 in tests instead of md5; time difference is negligible * nolint usage of math/rand in test and add comment on its import - crypto/rand is slower and we do not need sth more secure in tests * enable linter in circle-ci * another nolint math/rand in test * replace another occurrence of md5 * consistent comment about importing math/rand	2019-02-12 08:54:12 +04:00
zhangzheng	c6c0b52d0c	tools/tm-bench: bounds check for txSize and improving test cases (#2410 ) Fixes #2409	2018-09-17 13:08:47 +04:00
ValarDragon	1dbe7b7e68	tools/tmbench: Improve accuracy with large tx sizes. At larger tx sizes (e.g. > 10000) we were spending non-neglible amounts of time in tx creation, due to making the final bytes random. The slower the send loop, the less accurate it is at measuring the time tendermint took. (As we can't reach the promised contract of the given rate) There really isn't much need for that randomness, so this PR makes it such that only the txNumber gets bumped between txs from the same connection, thereby improving sendloop speed and accuracy.	2018-07-12 23:47:40 -07:00

Author

SHA1

Message

Date

Ismail Khoffi

b089587b42

make gosec linter pass (#3294 )

* not related to linter: remove obsolete constants:
 - `Insecure` and `Secure` and type `Security` are not used anywhere

* not related to linter: update example

 - NewInsecure was deleted; change example to NewRemoteDB

* address: Binds to all network interfaces (gosec):

 - bind to localhost instead of 0.0.0.0
 - regenerate test key and cert for this purpose (was valid for ::) and
 otherwise we would see:
 transport: authentication handshake failed: x509: certificate is
 valid for ::, not 127.0.0.1\"

(used https://github.com/google/keytransparency/blob/master/scripts/gen_server_keys.sh
to regenerate certs)

* use sha256 in tests instead of md5; time difference is negligible

* nolint usage of math/rand in test and add comment on its import

 - crypto/rand is slower and we do not need sth more secure in tests

* enable linter in circle-ci

* another nolint math/rand in test

* replace another occurrence of md5

* consistent comment about importing math/rand

2019-02-12 08:54:12 +04:00

zhangzheng

c6c0b52d0c

tools/tm-bench: bounds check for txSize and improving test cases (#2410 )

Fixes #2409

2018-09-17 13:08:47 +04:00

ValarDragon

1dbe7b7e68

tools/tmbench: Improve accuracy with large tx sizes.

At larger tx sizes (e.g. > 10000) we were spending non-neglible
amounts of time in tx creation, due to making the final bytes random.
The slower the send loop, the less accurate it is at measuring the time
tendermint took. (As we can't reach the promised contract of the given rate)

There really isn't much need for that randomness, so this PR makes it
such that only the txNumber gets bumped between txs from the same
connection, thereby improving sendloop speed and accuracy.

2018-07-12 23:47:40 -07:00

3 Commits