Pass http.ServeTLS() errors back to the caller (#2461)

Closes: #2460

* Pass http.ServeTLS() errors back to the caller
* Update CHANGELOG
* Amend StartHTTPServer() too for consistency's sake
* Revert "Amend StartHTTPServer() too for consistency's sake"
This reverts commit 23bfb4c2e917f581702291fe3ea69fce23f8c89d.
This commit is contained in:
Alessio Treglia
2018-09-21 17:12:29 +01:00
committed by Alexander Simmerl
parent 886a83dfb8
commit f11db8c1b0
3 changed files with 25 additions and 8 deletions

View File

@ -102,15 +102,16 @@ func StartHTTPAndTLSServer(
listener = netutil.LimitListener(listener, config.MaxOpenConnections)
}
go func() {
err := http.ServeTLS(
listener,
RecoverAndLogHandler(maxBytesHandler{h: handler, n: maxBodyBytes}, logger),
certFile,
keyFile,
)
err = http.ServeTLS(
listener,
RecoverAndLogHandler(maxBytesHandler{h: handler, n: maxBodyBytes}, logger),
certFile,
keyFile,
)
if err != nil {
logger.Error("RPC HTTPS server stopped", "err", err)
}()
return nil, err
}
return listener, nil
}