fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-24 18:21:38 +00:00
Code Issues Projects Releases Wiki Activity

rpc: return err if page is incorrect (less than 0 or greater than tot… (#3825)

Browse Source 
* rpc: return err if page is incorrect (less than 0 or greater than total pages)

Fixes #3813

* fix rpc_test
This commit is contained in:
Anton Kaliaev
2019-07-23 12:25:59 +04:00
committed by Jack Zampolin
parent df6df61ea9
commit e89991c445
4 changed files with 43 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
rpc/core/pipe_test.go
View File

@ -14,33 +14,39 @@ func TestPaginationPage(t *testing.T) {
perPage int
page int
newPage int
expErr bool
}{
{0, 0, 1, 1},
{0, 10, 1, 1, false},
{0, 10, 0, 1},
{0, 10, 1, 1},
{0, 10, 2, 1},
{0, 10, 0, 1, false},
{0, 10, 1, 1, false},
{0, 10, 2, 0, true},
{5, 10, -1, 1},
{5, 10, 0, 1},
{5, 10, 1, 1},
{5, 10, 2, 1},
{5, 10, 2, 1},
{5, 10, -1, 0, true},
{5, 10, 0, 1, false},
{5, 10, 1, 1, false},
{5, 10, 2, 0, true},
{5, 10, 2, 0, true},
{5, 5, 1, 1},
{5, 5, 2, 1},
{5, 5, 3, 1},
{5, 5, 1, 1, false},
{5, 5, 2, 0, true},
{5, 5, 3, 0, true},
{5, 3, 2, 2},
{5, 3, 3, 2},
{5, 3, 2, 2, false},
{5, 3, 3, 0, true},
{5, 2, 2, 2},
{5, 2, 3, 3},
{5, 2, 4, 3},
{5, 2, 2, 2, false},
{5, 2, 3, 3, false},
{5, 2, 4, 0, true},
}
for _, c := range cases {
p := validatePage(c.page, c.perPage, c.totalCount)
p, err := validatePage(c.page, c.perPage, c.totalCount)
if c.expErr {
assert.Error(t, err)
continue
}
assert.Equal(t, c.newPage, p, fmt.Sprintf("%v", c))
}