fluencelabs/tendermint
1
0
Fork 0
mirror of https://github.com/fluencelabs/tendermint synced 2025-06-10 12:01:18 +00:00
Code Issues Projects Releases Wiki Activity

consensus: flush wal on stop (#3297)

Browse Source 
Should fix #3295
Also partial fix of #3043
This commit is contained in:
Ethan Buchman
2019-02-12 06:32:40 +01:00
committed by Anton Kaliaev
parent 08dabab024
commit dc6567c677
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -89,7 +89,7 @@ Special thanks to external contributors on this release:
- [p2p] [\#3247](https://github.com/tendermint/tendermint/issues/3247) Fix panic in SeedMode when calling FlushStop and OnStop - [p2p] [\#3247](https://github.com/tendermint/tendermint/issues/3247) Fix panic in SeedMode when calling FlushStop and OnStop
concurrently concurrently
- [p2p] [\#3040](https://github.com/tendermint/tendermint/issues/3040) Fix MITM on secret connection by checking low-order points - [p2p] [\#3040](https://github.com/tendermint/tendermint/issues/3040) Fix MITM on secret connection by checking low-order points
- [privval] [\#3258](https://github.com/tendermint/tendermint/issues/3258) Fix race between sign requests and ping requests in socket - [privval] [\#3258](https://github.com/tendermint/tendermint/issues/3258) Fix race between sign requests and ping requests in socket that was causing messages to be corrupted
## v0.29.1 ## v0.29.1

2
CHANGELOG_PENDING.md
View File

@ -21,3 +21,5 @@ Special thanks to external contributors on this release:
### IMPROVEMENTS: ### IMPROVEMENTS:
### BUG FIXES: ### BUG FIXES:
- [consensus] \#3297 Flush WAL on stop to prevent data corruption during
graceful shutdown

1
consensus/wal.go
View File

@ -116,6 +116,7 @@ func (wal *baseWAL) OnStart() error {
// Use Wait() to ensure it's finished shutting down // Use Wait() to ensure it's finished shutting down
// before cleaning up files. // before cleaning up files.
func (wal *baseWAL) OnStop() { func (wal *baseWAL) OnStop() {
wal.group.Flush()
wal.group.Stop() wal.group.Stop()
wal.group.Close() wal.group.Close()
} }